Michael Kublin has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java
Line 9: private Guid domainId;
Line 10: private Guid vdsId;
Line 11: private String description;
Line 12:
Line 13: public Event(Guid storagePoolId, Guid domainId, Guid vdsId,
EventType eventType) {
why I need this constructor, Event it is simple class that should not contain
any logic.
Now we can pass description we can not, it used in 5-6 places and in 2 two of
them used a new construct what for?
Line 14: this(storagePoolId, domainId, vdsId, eventType, null);
Line 15: }
Line 16:
Line 17: public Event(Guid storagePoolId, Guid domainId, Guid vdsId,
EventType eventType, String description) {
--
To view, visit http://gerrit.ovirt.org/13311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If192b3ccc5f5310de4fd80ca7fb4a7d74d52e1df
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
