Michael Kublin has posted comments on this change. Change subject: core: use local TX in AddVm flow ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java Line 31: tempVar.setSessionId(getParameters().getSessionId()); Line 32: tempVar.setDontAttachToDefaultTag(true); Line 33: returnValueFromAddVm = Line 34: Backend.getInstance().runInternalAction(VdcActionType.AddVmFromScratch, Line 35: tempVar, And why our code still not work in such way? How passing of context helps me in case than 5 from 10 action failed? Line 36: ExecutionHandler.createDefaultContexForTasks(getExecutionContext())); Line 37: } else { Line 38: VmManagementParametersBase tempVar2 = new VmManagementParametersBase(vmStatic); Line 39: tempVar2.setSessionId(getParameters().getSessionId()); -- To view, visit http://gerrit.ovirt.org/13805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If93240cca8bee4988f28c3de574b44c9db31e8f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches