Michael Kublin has posted comments on this change. Change subject: core: InitVdsOnUp- proceed regardless of ConnectHostToStoragePoolServers ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java Line 51: .RunVdsCommand( Line 52: VDSCommandType.ConnectStorageServer, Line 53: new ConnectStorageServerVDSCommandParameters(getVds().getId(), Line 54: getStoragePool().getId(), type, connections)).getReturnValue(); Line 55: } StorageHelperDirector.getInstance().getItem(type).isConnectSucceeded - actually this can be left for log messages, but name can be changed, because result is not important anymore Line 56: } .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java Line 383 Line 384 Line 385 Line 386 Line 387 I think better to left this event, user need to know that host did not success to connect to some storages, user can fix this afterwards -- To view, visit http://gerrit.ovirt.org/13880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia69b62807331d4a47482f71fe88aa3e2ad7b7448 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
