Idan Shaby has posted comments on this change.
Change subject: core: Add disk alias to "Scan Alignment" error message
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42483
To unsubscribe, visit https://ge
Idan Shaby has uploaded a new change for review.
Change subject: core: Add disk alias to "Scan Alignment" error message
..
core: Add disk alias to "Scan Alignment" error message
When running "Scan Alignment" on a disk based on b
Idan Shaby has posted comments on this change.
Change subject: core: log the selected storage domain for memory volumes
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42143
To unsubscribe, visit https://
Idan Shaby has abandoned this change.
Change subject: uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor
..
Abandoned
See Greg's feature - https://gerrit.ovirt.org/#/c/41296/
--
To view, visit https://gerrit.ovir
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
..
Patch Set 6: Verified+1
Works nice except for the missing dotted underline. After Greg fixes the
infrastructu
Idan Shaby has posted comments on this change.
Change subject: core: log the selected storage domain for memory volumes
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42143
To unsubscribe, visit https://
Idan Shaby has posted comments on this change.
Change subject: core: log the selected storage domain for memory volumes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42143
To unsubscribe, visit https://
Idan Shaby has uploaded a new change for review.
Change subject: core: log the selected storage domain for memory volumes
..
core: log the selected storage domain for memory volumes
This patch adds an info log for the storage do
Idan Shaby has posted comments on this change.
Change subject: restapi: Ability to specify alias on Glance disk import
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42089
To unsubscribe, visit https://g
Idan Shaby has posted comments on this change.
Change subject: core, webadmin: Override image name in import image view
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/41394
To unsubscribe, visit https://
Idan Shaby has uploaded a new change for review.
Change subject: restapi: Ability to specify alias on Glance disk import
..
restapi: Ability to specify alias on Glance disk import
This patch adds the ability to specify the disk
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
..
Patch Set 4: Code-Review-1
Please don't review this patch set yet.
--
To view, visit https://gerrit.ovirt.or
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
..
Patch Set 3:
I am working on it, thanks.
--
To view, visit https://gerrit.ovirt.org/38663
To unsubscribe, vi
Idan Shaby has posted comments on this change.
Change subject: webadmin: override image name in import image view
..
Patch Set 3: -Verified Code-Review-1
Since I want to separate this patch into two patches - one for the webadm
Idan Shaby has posted comments on this change.
Change subject: webadmin: override image name in import image view
..
Patch Set 3: Verified+1
Rebased and added the REST API side.
In rsdl_metadata, added line number 1115.
No chan
Idan Shaby has posted comments on this change.
Change subject: webadmin: override image name in import image view
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/41394/1/backend/manager/modules/bll/src/main/java/org/
Idan Shaby has posted comments on this change.
Change subject: core: add MemoryStorageHandler the ability to sort
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/40438
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandler to use filters
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/40437
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: add MemoryStorageHandler the ability to sort
..
Patch Set 7: Verified+1
Rebased on master, fixed a bug in StorageDomainNumberOfVmDisksComparator and
renamed
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandlerTest to use mocks
..
Patch Set 6: Verified+1
Rebased on master.
--
To view, visit https://gerrit.ovirt.org/40435
To unsubscribe
Idan Shaby has posted comments on this change.
Change subject: core: move logic regarding memory storage handling
..
Patch Set 3: Verified+1
Rebased on master
--
To view, visit https://gerrit.ovirt.org/40433
To unsubscribe, v
Idan Shaby has posted comments on this change.
Change subject: core: add MemoryStorageHandler the ability to sort
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/40438
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandler to use filters
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/40437
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandlerTest to use mocks
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/40435
To unsubscribe, visit https://gerr
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandlerTest to use mocks
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/40435/4/backend/manager/modules/bll/src/test/java/org
Idan Shaby has posted comments on this change.
Change subject: core: add more tests to MemoryStorageHandlerTest
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/40436
To unsubscribe, visit https://gerrit.o
Idan Shaby has posted comments on this change.
Change subject: core: add more tests to MemoryStorageHandlerTest
..
Patch Set 4:
(7 comments)
https://gerrit.ovirt.org/#/c/40436/4/backend/manager/modules/bll/src/test/java/org/ov
Idan Shaby has posted comments on this change.
Change subject: webadmin: override image name in import image view
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41394
To unsubscribe, visit https://gerrit
Idan Shaby has uploaded a new change for review.
Change subject: webadmin: override image name in import image view
..
webadmin: override image name in import image view
This patch adds the ability to edit the alias of a disk im
Idan Shaby has posted comments on this change.
Change subject: core: add MemoryStorageHandler the ability to sort
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/40438
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandlerTest to use mocks
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/40435
To unsubscribe, visit https://gerr
Idan Shaby has posted comments on this change.
Change subject: core: add MemoryStorageHandler the ability to sort
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/40438
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandler to use filters
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/40437
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: add more tests to MemoryStorageHandlerTest
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/40436
To unsubscribe, visit https://gerrit.o
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandlerTest to use mocks
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/40435
To unsubscribe, visit https://gerr
Idan Shaby has posted comments on this change.
Change subject: core: add MemoryStorageHandler the ability to sort
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/40438/1/backend/manager/modules/bll/src/main/java/org/
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandler to use filters
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/40437/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9:
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandler to use filters
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40437
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandlerTest to use mocks
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/40435/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandlerTest to use mocks
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40435
To unsubscribe, visit https://gerr
Idan Shaby has posted comments on this change.
Change subject: core: move logic regarding memory storage handling
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40433
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: move logic regarding memory storage handling
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/40433/1/backend/manager/modules/bll/src/main/java/org/
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandlerTest to use mocks
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/40435/1/backend/manager/modules/bll/src/test/java/org
Idan Shaby has posted comments on this change.
Change subject: core: add MemoryStorageHandler the ability to sort
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40438
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandler to use filters
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40437
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: core: add more tests to MemoryStorageHandlerTest
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40436
To unsubscribe, visit https://gerrit.o
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandlerTest to use mocks
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40435
To unsubscribe, visit https://gerr
Idan Shaby has posted comments on this change.
Change subject: core: redesign MemoryStorageHandler to be a singleton
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40434
To unsubscribe, visit https://ger
Idan Shaby has posted comments on this change.
Change subject: core: move logic regarding memory storage handling
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40433
To unsubscribe, visit https://gerrit
Idan Shaby has uploaded a new change for review.
Change subject: core: add MemoryStorageHandler the ability to sort
..
core: add MemoryStorageHandler the ability to sort
This patch adds the MemoryStorageHandler mechanism the abi
Idan Shaby has uploaded a new change for review.
Change subject: core: redesign MemoryStorageHandlerTest to use mocks
..
core: redesign MemoryStorageHandlerTest to use mocks
This patch redesigns the test class of MemoryStorageHa
Idan Shaby has uploaded a new change for review.
Change subject: core: redesign MemoryStorageHandler to use filters
..
core: redesign MemoryStorageHandler to use filters
This patch doesn't change the behavior of MemoryStorageHan
Idan Shaby has uploaded a new change for review.
Change subject: core: move logic regarding memory storage handling
..
core: move logic regarding memory storage handling
This patch moves the logic regarding memory storage handli
Idan Shaby has uploaded a new change for review.
Change subject: core: redesign MemoryStorageHandler to be a singleton
..
core: redesign MemoryStorageHandler to be a singleton
This patch redesignes MemoryStorageHandler to be a s
Idan Shaby has uploaded a new change for review.
Change subject: core: add more tests to MemoryStorageHandlerTest
..
core: add more tests to MemoryStorageHandlerTest
This patch adds more tests to MemoryStorageHandlerTest.
Chang
Idan Shaby has posted comments on this change.
Change subject: core: add a getActiveSnapshot method to VmHandler
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39882
To unsubscribe, visit https://gerrit.
Idan Shaby has uploaded a new change for review.
Change subject: core: add a getActiveSnapshot method to VmHandler
..
core: add a getActiveSnapshot method to VmHandler
The method getActiveSnapshot can be useful in other places o
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
..
Patch Set 3: Code-Review-1
Waiting for Greg to add the option of using the HTML tag for a tooltip.
--
To vi
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor
..
Patch Set 4: Code-Review-1
Waiting for Greg to add the option of using the HTML tag for a toolti
Idan Shaby has posted comments on this change.
Change subject: webadmin: Add wipe after delete to Disks general tab
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/38854
To unsubscribe, visit https://gerr
Idan Shaby has posted comments on this change.
Change subject: webadmin: Add wipe after delete to Disks general tab
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38854/1/frontend/webadmin/modules/webadmin/src/main/j
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/38662
To unsubscribe, visit h
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38662/3/frontend/webadmin/modules/gwt-comm
Idan Shaby has posted comments on this change.
Change subject: webadmin: Add wipe after delete to Disks general tab
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38854
To unsubscribe, visit https://gerr
Idan Shaby has uploaded a new change for review.
Change subject: webadmin: Add wipe after delete to Disks general tab
..
webadmin: Add wipe after delete to Disks general tab
This patch adds the "Wipe After Delete" property to th
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
..
Patch Set 1:
(9 comments)
https://gerrit.ovirt.org/#/c/38663/1/frontend/webadmin/modules/gwt-common/src/main/
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/38663
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38662/1/frontend/webadmin/modules/gwt-comm
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/38662
To unsubscribe, visit h
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38663/1/frontend/webadmin/modules/uicompat/src/main/jav
Idan Shaby has posted comments on this change.
Change subject: webadmin: Disabling unsupported storage types when adding a
domain.
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38544
To unsubscribe,
Idan Shaby has posted comments on this change.
Change subject: webadmin: Disabling unsupported storage types when adding a
domain.
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/38544/5/frontend/webadmin/modules/ui
Idan Shaby has posted comments on this change.
Change subject: core: Extract DiskStorageType from Disk entity to a standalone
class
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38652
To unsubscribe
Idan Shaby has posted comments on this change.
Change subject: core: Move Disk entity to the storate package
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38651/1/backend/manager/modules/restapi/jaxrs/src/test/java/
Idan Shaby has posted comments on this change.
Change subject: core: Move BaseDisk entity to the storage package
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38650
To unsubscribe, visit https://gerr
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38663
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38662
To unsubscribe, visit h
Idan Shaby has posted comments on this change.
Change subject: webadmin: Moved textWithTooltip() to CommonApplicationTemplates
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38661
To unsubscribe, visit h
Idan Shaby has posted comments on this change.
Change subject: webadmin: Re-indent lines in VmDiskAttachPopupWidget.ui.xml
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38660
To unsubscribe, visit https
Idan Shaby has uploaded a new change for review.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
..
uicommonweb: Attach virtual IDE disks new behavior
When a user tries to hot plug an IDE disk, he gets an erro
Idan Shaby has uploaded a new change for review.
Change subject: uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor
..
uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor
Enabled to set an HTML label wit
Idan Shaby has uploaded a new change for review.
Change subject: webadmin: Moved textWithTooltip() to CommonApplicationTemplates
..
webadmin: Moved textWithTooltip() to CommonApplicationTemplates
The method textWithTooltip() can
Idan Shaby has uploaded a new change for review.
Change subject: webadmin: Re-indent lines in VmDiskAttachPopupWidget.ui.xml
..
webadmin: Re-indent lines in VmDiskAttachPopupWidget.ui.xml
Replaced tabs with 4 spaces.
Change-Id:
Idan Shaby has posted comments on this change.
Change subject: webadmin: Add disk snapshot ID column to two tables
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/38266
To unsubscribe, visit https://gerri
Idan Shaby has posted comments on this change.
Change subject: webadmin: Add disk snapshot ID column to snapshot disks table
..
Patch Set 3: Code-Review-1
I was noted by Daniel that the same column should also appear in Storage
Idan Shaby has posted comments on this change.
Change subject: webadmin: Add disk snapshot ID column to snapshot disks table
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/38266
To unsubscribe, visit htt
Idan Shaby has posted comments on this change.
Change subject: webadmin: Add disk snapshot ID column to snapshot disks table
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38266/2/frontend/webadmin/modules/gwt-common
Idan Shaby has posted comments on this change.
Change subject: webadmin: Add imageID column to snapshot disks table
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38266/2/frontend/webadmin/modules/gwt-common/src/main
Idan Shaby has posted comments on this change.
Change subject: packaging: setup: Add SANWipeAfterDelete to answer file
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38278
To unsubscribe, visit https://g
Idan Shaby has uploaded a new change for review.
Change subject: packaging: setup: Add SANWipeAfterDelete to answer file
..
packaging: setup: Add SANWipeAfterDelete to answer file
This patch updates the answer file with the user
Idan Shaby has posted comments on this change.
Change subject: webadmin: Add imageID column to snapshot disks table
..
Patch Set 1:
Verified by taking snapshots of VMs with disks on NFS and iSCSI domains and
checking that thei
Idan Shaby has posted comments on this change.
Change subject: webadmin: Add imageID column to snapshot disks table
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38266
To unsubscribe, visit https://gerr
Idan Shaby has uploaded a new change for review.
Change subject: webadmin: Add imageID column to snapshot disks table
..
webadmin: Add imageID column to snapshot disks table
This patch adds an imageID column in the table that sh
Idan Shaby has uploaded a new change for review.
Change subject: Revert "restapi: optimize getUriBuilder"
..
Revert "restapi: optimize getUriBuilder"
This reverts commit d83d67ff715c0707b1715e09249532ca14c7e21a.
The original pat
Idan Shaby has posted comments on this change.
Change subject: Revert "restapi: optimize getUriBuilder"
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38165
To unsubscribe, visit https://gerrit.ovirt.org
Idan Shaby has posted comments on this change.
Change subject: packaging: setup: SANWipeAfterDelete configuration
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/37397/4/packaging/setup/plugins/ovirt-engine-setup/ovirt
Idan Shaby has posted comments on this change.
Change subject: core: Fix error message with non-existent storage domains status
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/37253/1/backend/manager/modu
Idan Shaby has restored this change.
Change subject: packaging: setup: SANWipeAfterDelete configuration
..
Restored
Sorry for the mess.
Patch set 4 is fine.
--
To view, visit http://gerrit.ovirt.org/37397
To unsubscribe, visi
Idan Shaby has posted comments on this change.
Change subject: packaging: setup: SANWipeAfterDelete configuration
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/37397
To unsubscribe, visit http://gerrit.o
Idan Shaby has posted comments on this change.
Change subject: packaging: setup: SANWipeAfterDelete configuration
..
Patch Set 3:
(9 comments)
http://gerrit.ovirt.org/#/c/37397/3/packaging/setup/plugins/ovirt-engine-setup/ovir
1 - 100 of 338 matches
Mail list logo
