Idan Shaby has uploaded a new change for review. Change subject: core: add more tests to MemoryStorageHandlerTest ......................................................................
core: add more tests to MemoryStorageHandlerTest This patch adds more tests to MemoryStorageHandlerTest. Change-Id: I5ff159f0482872844b274f2c5b20b171e08e8b08 Bug-Url: https://bugzilla.redhat.com/1186230 Signed-off-by: Idan Shaby <ish...@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/40436/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java index 45c268c..14c3af4 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java @@ -4,6 +4,7 @@ import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNull; import static org.mockito.Matchers.any; +import static org.mockito.Matchers.anyCollectionOf; import static org.mockito.Matchers.anyListOf; import static org.mockito.Mockito.doNothing; import static org.mockito.Mockito.doReturn; @@ -54,17 +55,54 @@ } @Test + public void verifyFirstDomainForMemory() { + verifyDomainForMemory(Arrays.asList(validStorageDomain, invalidStorageDomain1, invalidStorageDomain2)); + } + + @Test + public void verifyMiddleDomainForMemory() { + verifyDomainForMemory(Arrays.asList(invalidStorageDomain1, validStorageDomain, invalidStorageDomain2)); + } + + @Test public void verifyLastDomainForMemory() { verifyDomainForMemory(Arrays.asList(invalidStorageDomain1, invalidStorageDomain2, validStorageDomain)); } @Test + public void verifyNoDomainForMemoryWhenDomainIsNotDataDomain() { + for (StorageDomainType storageDomainType : StorageDomainType.values()) { + if (!storageDomainType.isDataDomain()) { + validStorageDomain.setStorageDomainType(storageDomainType); + verifyNoDomainForMemory(Arrays.asList(validStorageDomain)); + } + } + } + + @Test + public void verifyNoDomainForMemoryWhenDomainIsNotActive() { + for (StorageDomainStatus storageDomainStatus : StorageDomainStatus.values()) { + if (storageDomainStatus != StorageDomainStatus.Active) { + validStorageDomain.setStatus(storageDomainStatus); + verifyNoDomainForMemory(Arrays.asList(validStorageDomain)); + } + } + } + + @Test public void verifyNoDomainForMemoryWhenDomainHasLowSpace() { when(validStorageDomainValidator.isDomainWithinThresholds()) .thenReturn(new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN)); verifyNoDomainForMemory(Arrays.asList(validStorageDomain)); } + @Test + public void verifyNoDomainForMemoryWhenDomainHasNoSpaceForClonedDisks() { + when(validStorageDomainValidator.hasSpaceForClonedDisks(anyCollectionOf(DiskImage.class))) + .thenReturn(new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN)); + verifyNoDomainForMemory(Arrays.asList(validStorageDomain)); + } + private void initStorageDomains() { validStorageDomain = initStorageDomain(); invalidStorageDomain1 = initStorageDomain(); -- To view, visit https://gerrit.ovirt.org/40436 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ff159f0482872844b274f2c5b20b171e08e8b08 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
