Idan Shaby has posted comments on this change. Change subject: core: move logic regarding memory storage handling ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40433/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 212: } Line 213: Line 214: public Guid getStorageDomainIdForVmMemory(List<DiskImage> memoryDisksList) { Line 215: if (cachedStorageDomainId.equals(Guid.Empty) && getVm() != null) { Line 216: StorageDomain storageDomain = MemoryStorageHandler.findStorageDomainForMemory(getVm().getStoragePoolId(), > Why the newline? The new line is after "getStoragePoolId()," (although it doesn't look like this), and it's there because of the convention of 120 characters per line. Line 217: memoryDisksList); Line 218: if (storageDomain != null) { Line 219: cachedStorageDomainId = storageDomain.getId(); Line 220: } https://gerrit.ovirt.org/#/c/40433/1/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java: Line 72: storageDomain.setStatus(StorageDomainStatus.Active); Line 73: storageDomain.setAvailableDiskSize(size); Line 74: return storageDomain; Line 75: } Line 76: > Please lose this newline Done -- To view, visit https://gerrit.ovirt.org/40433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367ee3b1e902495472e687b6dad63bc305b2c8bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
