Idan Shaby has posted comments on this change.

Change subject: uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38662/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java:

Line 210:     public void setLabel(String labelText) {
Line 211:         label.getElement().setInnerText(labelText);
Line 212:     }
Line 213: 
Line 214:     public void setHtmlLabel(SafeHtml htmlLabel) {
> actually, I think 'setLabelHTML' looks better... :)
Done
Line 215:         label.getElement().setInnerSafeHtml(htmlLabel);
Line 216:     }
Line 217: 
Line 218:     @Override


-- 
To view, visit https://gerrit.ovirt.org/38662
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I081b223ed16991f82b5c2ebb90aa7dd7ec3d398a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ish...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Idan Shaby <ish...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to