Idan Shaby has posted comments on this change. Change subject: packaging: setup: SANWipeAfterDelete configuration ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/37397/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py: Line 58: ) Line 59: def _configureSANWipeAfterDelete(self): Line 60: if self.environment[SAN_WIPE_AFTER_DELETE] is None: Line 61: # Value for SAN_WIPE_AFTER_DELETE is not forced. Line 62: sanWipeAfterDelete = dialog.queryBoolean( > What you suggest will make the code harder to read for no benefit. Simone, I agree with Nir that your suggestion will make the code harder to read. However, I don't think that this case requires creating a new function. Anyway, I won't delay this patch from progress on this. Is there an option among those two that both of you can agree on? Line 63: dialog=self.dialog, Line 64: name='OVESETUP_CONFIG_SAN_WIPE_AFTER_DELETE', Line 65: note=_( Line 66: 'Default SAN wipe after delete ' -- To view, visit http://gerrit.ovirt.org/37397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I911f87ad34eafc83eb2c7aa346fc4278ada28b5b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
