Frank Kobzik has posted comments on this change.
Change subject: engine: Phase 4: Query for generating console descriptor
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/37975
To unsubscribe, visit https
Frank Kobzik has posted comments on this change.
Change subject: engine: Phase 3: Configuring ConsoleOptions on backend
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/37974
To unsubscribe, visit https:/
Frank Kobzik has posted comments on this change.
Change subject: restapi: Phase 5: Add graphics console representation
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/39057
To unsubscribe, visit https://g
Frank Kobzik has posted comments on this change.
Change subject: frontend: Phase 2: Make console clients use ConsoleOptions
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/37973
To unsubscribe, visit http
Frank Kobzik has posted comments on this change.
Change subject: engine: Phase 1: Move console options to backend
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/37972
To unsubscribe, visit https://gerrit
Frank Kobzik has posted comments on this change.
Change subject: engine: Phase 1: Move console options to backend
..
Patch Set 5:
pushed a new patchset, I'll start verifying tomorrow.
--
To view, visit https://gerrit.ovirt.or
Frank Kobzik has posted comments on this change.
Change subject: engine: Phase 3: Configuring ConsoleOptions on backend
..
Patch Set 7:
(6 comments)
https://gerrit.ovirt.org/#/c/37974/7/backend/manager/modules/bll/src/main/jav
Frank Kobzik has posted comments on this change.
Change subject: engine: Phase 4: Query for generating console descriptor
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/37975/7/backend/manager/modules/common/src/main
Frank Kobzik has posted comments on this change.
Change subject: engine: Phase 1: Move console options to backend
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/37972/4/backend/manager/modules/common/src/main/java/or
Frank Kobzik has posted comments on this change.
Change subject: core: fix creating instance type via ui
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/37562
To unsubscribe, visit https://gerrit.ovirt.or
Frank Kobzik has posted comments on this change.
Change subject: restapi: Phase 5: Add graphics console representation
..
Patch Set 2:
updated. extracting stuff from matrix/query params or headers are still to be
done.
--
To
Frank Kobzik has posted comments on this change.
Change subject: restapi: Phase 5: Add graphics console representation
..
Patch Set 2:
(oops, I forgot to update rsdl_metadata)
--
To view, visit https://gerrit.ovirt.org/39057
Frank Kobzik has posted comments on this change.
Change subject: restapi: Phase 5: Retrieve console descriptor file
..
Patch Set 1:
(I merged the patch to a previous one).
--
To view, visit https://gerrit.ovirt.org/39058
To u
Frank Kobzik has abandoned this change.
Change subject: restapi: Phase 5: Retrieve console descriptor file
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/39058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Frank Kobzik has uploaded a new change for review.
Change subject: tools: Allow setting RemapCtrlAltDelDefault boolean
..
tools: Allow setting RemapCtrlAltDelDefault boolean
This will affect preselected value of "Remap Ctrl-Alt-
Frank Kobzik has posted comments on this change.
Change subject: frontend: Load default value for "Remap Ctrl-Alt-Delete"
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/39071
To unsubscribe, visit https:
Frank Kobzik has posted comments on this change.
Change subject: tools: Allow setting RemapCtrlAltDelDefault boolean
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/39072
To unsubscribe, visit https://ger
Frank Kobzik has uploaded a new change for review.
Change subject: backend: Add RemapCtrlAltDelDefault to config
..
backend: Add RemapCtrlAltDelDefault to config
This will affect preselected value of "Remap Ctrl-Alt-Delete to
Ct
Frank Kobzik has uploaded a new change for review.
Change subject: frontend: Load default value for "Remap Ctrl-Alt-Delete"
..
frontend: Load default value for "Remap Ctrl-Alt-Delete"
... from backend config. This affects defaul
Frank Kobzik has posted comments on this change.
Change subject: backend: Add RemapCtrlAltDelDefault to config
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/39070
To unsubscribe, visit https://gerrit.ov
Frank Kobzik has uploaded a new change for review.
Change subject: restapi: Phase 5: Add graphics console representation
..
restapi: Phase 5: Add graphics console representation
as a part of display subresource.
GraphicsConsole
Frank Kobzik has uploaded a new change for review.
Change subject: restapi: Phase 5: Retrieve console descriptor file
..
restapi: Phase 5: Retrieve console descriptor file
via request on /vms/{vmid}/display/graphics_consoles/{co
Frank Kobzik has abandoned this change.
Change subject: restapi: [WIP!] Phase 5: REST part for console descriptor
generator
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/37976
To unsubscribe, visit https://gerrit.ov
Frank Kobzik has posted comments on this change.
Change subject: core: Fix reporting user name in console events
..
Patch Set 2:
Not sure, I wouldn't say so, at least it doesn't solve it completely.
This only fixes the message
Frank Kobzik has posted comments on this change.
Change subject: core: Fix reporting user name in console events
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/38881
To unsubscribe, visit https://gerrit.
Frank Kobzik has uploaded a new change for review.
Change subject: core: Fix reporting user name in console events
..
core: Fix reporting user name in console events
When connecting/disconnecting to/from a console user name is n
Frank Kobzik has posted comments on this change.
Change subject: Fix on mouse over behavior in basic user portal
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/38820
To unsubscribe, visit https://gerrit.
Frank Kobzik has posted comments on this change.
Change subject: Fix on mouse over behavior in basic user portal
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38820
To unsubscribe, visit https://gerrit.
Frank Kobzik has uploaded a new change for review.
Change subject: Fix on mouse over behavior in basic user portal
..
Fix on mouse over behavior in basic user portal
previously hand cursor was not respected in certain situations
Frank Kobzik has abandoned this change.
Change subject: core: adjust test for searchquery
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/38581
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageTyp
Frank Kobzik has posted comments on this change.
Change subject: core: adjust test for searchquery
..
Patch Set 1:
Hi Eli, can you take a look? It seems one recent test doesn't comply to search
query generating.
--
To view,
Frank Kobzik has posted comments on this change.
Change subject: core: adjust test for searchquery
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38581
To unsubscribe, visit https://gerrit.ovirt.org/sett
Frank Kobzik has uploaded a new change for review.
Change subject: core: adjust test for searchquery
..
core: adjust test for searchquery
...when sorting by ip
Change-Id: I536f4fe82e2fde6057a032f943429373f24e50ad
Signed-off-by:
Frank Kobzik has posted comments on this change.
Change subject: core: Fix splitting logic for ip addresses
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/36946/3/packaging/dbscripts/create_functions.sql
File packagi
Frank Kobzik has posted comments on this change.
Change subject: core: Fix splitting logic for ip addresses
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/36946/3/packaging/dbscripts/create_functions.sql
File packagi
Frank Kobzik has posted comments on this change.
Change subject: core: Fix search for templates on username
..
Patch Set 1:
To be honest, I don't know what was the supposed behavior of the query. But
it's good that you get at
Frank Kobzik has posted comments on this change.
Change subject: core: Fix splitting logic for ip addresses
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/36946/3/packaging/dbscripts/create_functions.sql
File packagi
Frank Kobzik has posted comments on this change.
Change subject: core: Fix search for templates on username
..
Patch Set 1:
Hi guys, I had precisely this fix but then when I tried verifying with
"Templates: Users.usrname = adm
Frank Kobzik has posted comments on this change.
Change subject: core: Fix splitting logic for ip addresses
..
Patch Set 3: Verified+1
I spent some time with finding "the one" solution but was unsuccessful.
Therefore I propose
Frank Kobzik has uploaded a new change for review.
Change subject: engine: Phase 3: Configuring ConsoleOptions on backend
..
engine: Phase 3: Configuring ConsoleOptions on backend
Move filling ConsoleOptions from *ConsoleModel(s
Frank Kobzik has uploaded a new change for review.
Change subject: engine: Phase 4: Query for generating console descriptor
..
engine: Phase 4: Query for generating console descriptor
Move generating console descriptor file (aka
Frank Kobzik has posted comments on this change.
Change subject: frontend: Phase 2: Make console clients use ConsoleOptions
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/37973
To unsubscribe, visit http
Frank Kobzik has uploaded a new change for review.
Change subject: frontend: Phase 2: Make console clients use ConsoleOptions
..
frontend: Phase 2: Make console clients use ConsoleOptions
VNC and SPICE clients now use ConsoleOpt
Frank Kobzik has posted comments on this change.
Change subject: core: Restrict graphics for older CC
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/38274
To unsubscribe, visit https://gerrit.ovirt.org/s
Frank Kobzik has posted comments on this change.
Change subject: core: Restrict graphics for older CC
..
Patch Set 1: -Verified
--
To view, visit https://gerrit.ovirt.org/38274
To unsubscribe, visit https://gerrit.ovirt.org/se
Frank Kobzik has posted comments on this change.
Change subject: core: Restrict graphics for older CC
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38274
To unsubscribe, visit https://gerrit.ovirt.org/s
Frank Kobzik has uploaded a new change for review.
Change subject: core: Restrict graphics for older CC
..
core: Restrict graphics for older CC
For old CC (< 3.6) allow only setting SPICE on QXL and VNC on CIRRUS by
default (old
Frank Kobzik has abandoned this change.
Change subject: api: Prevent NPEx when using reloadconfigurations res
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/34202
To unsubscribe, visit https://gerrit.ovirt.org/setting
Frank Kobzik has posted comments on this change.
Change subject: frontend: Add NONE to GraphicsTypes enum & clean code
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/38171
To unsubscribe, visit https://g
Frank Kobzik has posted comments on this change.
Change subject: frontend: Add NONE to GraphicsTypes enum & clean code
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/38171
To unsubscribe, visit https://g
Frank Kobzik has posted comments on this change.
Change subject: core: Adjust websockify to the new API
..
Patch Set 1: -Verified
--
To view, visit https://gerrit.ovirt.org/32138
To unsubscribe, visit https://gerrit.ovirt.org/
Frank Kobzik has posted comments on this change.
Change subject: core: Adjust websockify to the new API
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/32138
To unsubscribe, visit https://gerrit.ovirt.org
Frank Kobzik has posted comments on this change.
Change subject: frontend: Add NONE to GraphicsTypes enum & clean code
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38171/2/frontend/webadmin/modules/uicommonweb/src/
Frank Kobzik has posted comments on this change.
Change subject: frontend: Add NONE to GraphicsTypes enum & clean code
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/38171
To unsubscribe, visit https://g
Frank Kobzik has uploaded a new change for review.
Change subject: frontend: Add NONE to GraphicsTypes enum
..
frontend: Add NONE to GraphicsTypes enum
This is useful for expressing
- that a VM/Template is headless, or
- graph
Frank Kobzik has posted comments on this change.
Change subject: engine: Phase 1: Move console options to backend
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/37972
To unsubscribe, visit http://gerrit.o
Frank Kobzik has posted comments on this change.
Change subject: frontend: Adjust graphics column name
..
Patch Set 1:
I'll re-trigger jenkins.
--
To view, visit http://gerrit.ovirt.org/38004
To unsubscribe, visit http://gerr
Frank Kobzik has posted comments on this change.
Change subject: frontend: Adjust graphics column name
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/38004
To unsubscribe, visit http://gerrit.ovirt.org/se
Frank Kobzik has uploaded a new change for review.
Change subject: frontend: Adjust graphics column name
..
frontend: Adjust graphics column name
in main VM view.
Change-Id: Ibda16a4251022f869250f141019d3c90511ca91b
Signed-off-
Frank Kobzik has posted comments on this change.
Change subject: tools: Validate WebSocketProxy config value
..
Patch Set 2:
Eli, Yair: Can you please +2 if you like the patch?
--
To view, visit http://gerrit.ovirt.org/37498
Frank Kobzik has uploaded a new change for review.
Change subject: engine: Phase 4: Query for generating console descriptor
..
engine: Phase 4: Query for generating console descriptor
Move generating console descriptor file (aka
Frank Kobzik has uploaded a new change for review.
Change subject: engine: Phase 3: Configuring ConsoleOptions on backend
..
engine: Phase 3: Configuring ConsoleOptions on backend
Move filling ConsoleOptions from *ConsoleModel(s
Frank Kobzik has uploaded a new change for review.
Change subject: restapi: [WIP!] Phase 5: REST part for console descriptor
generator
..
restapi: [WIP!] Phase 5: REST part for console descriptor generator
Added
- virt viewer m
Frank Kobzik has abandoned this change.
Change subject: rest part
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/37473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-I
Frank Kobzik has uploaded a new change for review.
Change subject: frontend: Phase 2: Make console clients use ConsoleOptions
..
frontend: Phase 2: Make console clients use ConsoleOptions
VNC and SPICE clients now use ConsoleOpt
Frank Kobzik has uploaded a new change for review.
Change subject: engine: Phase 1: Move console options to backend
..
engine: Phase 1: Move console options to backend
This is the 1st step for generating .vv files on backend. Th
Frank Kobzik has abandoned this change.
Change subject: engine: move console options to backend
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/37472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Messag
Frank Kobzik has posted comments on this change.
Change subject: tools: Validate WebSocketProxy config value
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37498
To unsubscribe, visit http://gerrit.ovirt.
Frank Kobzik has posted comments on this change.
Change subject: tools: Validate WebSocketProxy config value
..
Patch Set 1: -Verified
(6 comments)
http://gerrit.ovirt.org/#/c/37498/1/backend/manager/tools/src/main/java/org/ov
Frank Kobzik has posted comments on this change.
Change subject: frontend: Remove unwanted query call
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37563
To unsubscribe, visit http://gerrit.ovirt.org/set
Frank Kobzik has uploaded a new change for review.
Change subject: frontend: Remove unwanted query call
..
frontend: Remove unwanted query call
This patch removes calling query for soundcard in
InstanceTypeManager. The query mak
Frank Kobzik has posted comments on this change.
Change subject: frontend: fix display and graphics combo boxes behavior
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/37561
To unsubscribe, visit http://g
Frank Kobzik has posted comments on this change.
Change subject: core: fix creating instance type via ui
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37562
To unsubscribe, visit http://gerrit.ovirt.org/
Frank Kobzik has uploaded a new change for review.
Change subject: core: fix creating instance type via ui
..
core: fix creating instance type via ui
Previously when user was creating an instance type via ui, graphics
device was
Frank Kobzik has uploaded a new change for review.
Change subject: frontend: fix display and graphics combo boxes behavior
..
frontend: fix display and graphics combo boxes behavior
Previously displayType list model contained en
Frank Kobzik has posted comments on this change.
Change subject: tools: Validate WebSocketProxy config value
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37498
To unsubscribe, visit http://gerrit.ovirt.
Frank Kobzik has uploaded a new change for review.
Change subject: tools: Validate WebSocketProxy config value
..
tools: Validate WebSocketProxy config value
Change-Id: I84b02d25a15762ba24544bd678328e6532d360ac
Bug-Url: https://
Frank Kobzik has posted comments on this change.
Change subject: core: Fix splitting logic for ip addresses
..
Patch Set 2:
I see, I was considering adding colums to 'select' to prevent the error. But
that's not a good idea.
Frank Kobzik has posted comments on this change.
Change subject: core: Fix splitting logic for ip addresses
..
Patch Set 2:
I don't think that's straightforward solution, for example:
- we want to get list of sorted vms by ip
Frank Kobzik has uploaded a new change for review.
Change subject: rest part
..
rest part
- virt viewer media type
- vv() resource (todo rename)
- helper for translating between options to backend entity
Change-Id: I08814006b41
Frank Kobzik has posted comments on this change.
Change subject: frontend: Prevent selecting web based console clients in IE
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/34836
To unsubscribe, visit http
Frank Kobzik has posted comments on this change.
Change subject: frontend: Prevent selecting web based console clients in IE
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/34836
To unsubscribe, visit http
Frank Kobzik has posted comments on this change.
Change subject: core: Fix splitting logic for ip addresses
..
Patch Set 2:
Ok, I got it. This patch is problematic
9e7edd0079331299b024829a5f1dfe82352090d8.
It adds 'DISTINCT'
Frank Kobzik has posted comments on this change.
Change subject: core: Fix splitting logic for ip addresses
..
Patch Set 2:
bump. Could you guys check this patch?
--
To view, visit http://gerrit.ovirt.org/36946
To unsubscribe
Frank Kobzik has posted comments on this change.
Change subject: userportal: clarify setting style for vm item
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36942
To unsubscribe, visit http://gerrit.ovir
Frank Kobzik has posted comments on this change.
Change subject: userportal: Information about console in use
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/36884
To unsubscribe, visit http://gerrit.ovirt
Frank Kobzik has posted comments on this change.
Change subject: core: Fix splitting logic for ip addresses
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/36946
To unsubscribe, visit http://gerrit.ovirt.o
Frank Kobzik has uploaded a new change for review.
Change subject: core: Fix splitting logic for ip addresses
..
core: Fix splitting logic for ip addresses
This patch fixes the stored procedure responsible for splitting if
addre
Frank Kobzik has uploaded a new change for review.
Change subject: userportal: clarify setting style for vm item
..
userportal: clarify setting style for vm item
Basic user portal: This patch makes it clear what style the vm ite
Frank Kobzik has posted comments on this change.
Change subject: frontend: Utilize builders for copying graphics devices to
params
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/36637
To unsubscribe, vis
Frank Kobzik has uploaded a new change for review.
Change subject: userportal: Information about console in use
..
userportal: Information about console in use
This patch adds a visual information whether some user is using a
co
Frank Kobzik has posted comments on this change.
Change subject: core: legacy VDSM fix - part 2
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Frank Kobzik has uploaded a new change for review.
Change subject: core: legacy VDSM fix - part 2
..
core: legacy VDSM fix - part 2
Adding forgotten part of legacy vdsm fix to
I48cd5f76ed870530208fcd0fc69c3d1a52b7249b which I fo
Frank Kobzik has posted comments on this change.
Change subject: frontend: Utilize builders for copying graphics devices to
params
..
Patch Set 3:
no notable changes against the last patch.
--
To view, visit http://gerrit.ov
Frank Kobzik has posted comments on this change.
Change subject: frontend: Utilize builders for copying graphics devices to
params
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/36637
To unsubscribe, vis
Frank Kobzik has posted comments on this change.
Change subject: engine: Fix clone and clone from snapshot functionality
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/36633
To unsubscribe, visit http://g
Frank Kobzik has posted comments on this change.
Change subject: core: adjusts default_display_type and video card for blank
template
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/36609
To unsubscribe,
Frank Kobzik has posted comments on this change.
Change subject: frontend: Utilize builders for copying graphics devices to
params
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/36637
To unsubscribe, vis
Frank Kobzik has posted comments on this change.
Change subject: engine: (Cleanup) Remove unused graphics attributes
..
Patch Set 67: Verified+1
--
To view, visit http://gerrit.ovirt.org/31200
To unsubscribe, visit http://gerr
Frank Kobzik has posted comments on this change.
Change subject: engine: fix graphics devices handling when creating pool
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/36618
To unsubscribe, visit http://
1 - 100 of 1083 matches
Mail list logo
