Frank Kobzik has posted comments on this change. Change subject: core: Fix splitting logic for ip addresses ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/36946/3/packaging/dbscripts/create_functions.sql File packaging/dbscripts/create_functions.sql: Line 893: CREATE OR REPLACE FUNCTION fn_get_comparable_ip_list(text) RETURNS inet[] IMMUTABLE STRICT Line 894: AS $procedure$ Line 895: BEGIN Line 896: CASE Line 897: WHEN ($1 IS NULL) OR ($1 ~ E'^\\s*$') THEN > Note that this probably breaks functionality on some versions of psql. See That's interesting. But when I look to the documentation I see note about escaping '\' in regexes also for older versions of postgres. http://www.postgresql.org/docs/8.4/static/functions-matching.html I'm gonna take a deeper look anyway. Line 898: RETURN NULL; Line 899: ELSE Line 900: RETURN regexp_split_to_array(trim(both from $1), E'\\s+')::inet[]; Line 901: END CASE; -- To view, visit https://gerrit.ovirt.org/36946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923e1d99185e9aca69036edda00293ed1718b92 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
