Frank Kobzik has posted comments on this change. Change subject: engine: Phase 1: Move console options to backend ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/37972/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java: Line 50: private boolean spiceProxyEnabled; Line 51: private List<WanDisableEffects> wanDisableEffects; Line 52: Line 53: public static final int TICKET_VALIDITY_SECONDS = 120; Line 54: public static final String SECURE_ATTENTION_MAPPING = "ctrl+alt+end";// $NON-NLS-1$ > i think there is no need for " // $NON-NLS-1$ " anymore, no? thankfully not. I'll remove it. Thanks. Line 55: Line 56: public ConsoleOptions() { } Line 57: Line 58: public ConsoleOptions(GraphicsType graphicsType) { -- To view, visit https://gerrit.ovirt.org/37972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib06110fd2b36f96f1baa55b6176240cd27a2cbf9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
