Frank Kobzik has uploaded a new change for review.

Change subject: Fix on mouse over behavior in basic user portal
......................................................................

Fix on mouse over behavior in basic user portal

previously hand cursor was not respected in certain situations (after
doubleclick and connecting to console the hand cursor disappeared.

fixed by adding hand cursor handling to common method that deals with
vm item style.

Change-Id: I2d765c10f59ff654b8943c4beccfacf91b0ee76b
Signed-off-by: Frantisek Kobzik <fkob...@redhat.com>
---
M 
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/38820/1

diff --git 
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
 
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
index 55c2774..6ae0cef 100644
--- 
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
+++ 
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
@@ -214,15 +214,11 @@
     @Override
     public void onMouseOut(MouseOutEvent event) {
         setVmStyle();
-        getView().hideDoubleClickBanner();
     }
 
     @Override
     public void onMouseOver(MouseOverEvent event) {
         setVmStyleMouseOver();
-        if (!model.isPool() && model.getVmConsoles().canConnectToConsole()) {
-            getView().showDoubleClickBanner();
-        }
     }
 
     @Override
@@ -286,6 +282,11 @@
                 }
             }
         }
+        if (!model.isPool() && model.getVmConsoles().canConnectToConsole()) {
+            getView().showDoubleClickBanner();
+        } else {
+            getView().hideDoubleClickBanner();
+        }
     }
 
     boolean isSelected() {


-- 
To view, visit https://gerrit.ovirt.org/38820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d765c10f59ff654b8943c4beccfacf91b0ee76b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to