Frank Kobzik has posted comments on this change.

Change subject: core: Fix splitting logic for ip addresses
......................................................................


Patch Set 2:

I see, I was considering adding colums to 'select' to prevent the error. But 
that's not a good idea.

What you say is correct but now I don't feel confident to make such change. I 
need to discuss this with Omer when he's back.

-- 
To view, visit http://gerrit.ovirt.org/36946
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6923e1d99185e9aca69036edda00293ed1718b92
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to