oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Configurable Default for Wipe After Delete per Storage
Domain
..
Patch Set 2: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Stop constant synchronization of admin@internal
..
Patch Set 3: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 5: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/2
Idan Shaby has posted comments on this change.
Change subject: core: Configurable Default for Wipe After Delete per Storage
Domain
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/35909
To unsubscribe, vis
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: remove user/group sync
..
Patch Set 6:
it was possible before as well... especially after 3.4 aaa cleanups. we had no
time to focus in that... so I left it
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: remove user/group sync
..
Patch Set 6:
Well, the code looks OK, butsorry for still insisting - as the flat_groups was
already touched - I think now is the
automat...@ovirt.org has posted comments on this change.
Change subject: core: Configurable Default for Wipe After Delete per Storage
Domain
..
Patch Set 2:
* Update tracker::#1073448::OK
* Check Bug-Url::OK
* Check Public Bug
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 5:
I still think that the caller is responsible to set this, the backend should
not assume if that is a refresh or not (exc
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: remove user/group sync
..
Patch Set 6:
I am pretty sure I have asked in the past why do we still keep the periodic
sync.
What have changed since the sessi
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 5:
* Update tracker::#1168842::OK
* Check Bug-Url::OK
* Check Public Bug::#1168842::OK, public bug
* Check Product::
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 4:
Frontend in your comment == both weba apps and rest-api, no?
Therefore I prefer to concentrate the logic at engine.
As
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/35897/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/G
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Configurable Default for Wipe After Delete per Storage
Domain
..
Patch Set 1: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Stop constant synchronization of admin@internal
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35871
To unsubscribe, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Stop constant synchronization of admin@internal
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/35871
To unsubscribe, visit http://ge
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Stop constant synchronization of admin@internal
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Stop constant synchronization of admin@internal
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/35871/2/packaging/dbscripts/upgrade/03_06_0590_fix
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core, webadmin: Remove unused columns in Users table
..
Patch Set 1: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engin
Idan Shaby has posted comments on this change.
Change subject: core: Configurable Default for Wipe After Delete per Storage
Domain
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35909
To unsubscribe, vis
automat...@ovirt.org has posted comments on this change.
Change subject: core: Configurable Default for Wipe After Delete per Storage
Domain
..
Patch Set 1:
* Update tracker::#1073448::OK
* Check Bug-Url::OK
* Check Public Bug
Idan Shaby has uploaded a new change for review.
Change subject: core: Configurable Default for Wipe After Delete per Storage
Domain
..
core: Configurable Default for Wipe After Delete per Storage Domain
This patch adds the abi
Alon Bar-Lev has posted comments on this change.
Change subject: core, webadmin: Remove unused columns in Users table
..
Patch Set 1:
(9 comments)
Unless I am missing something, the group names is not required at any part of
automat...@ovirt.org has posted comments on this change.
Change subject: core, webadmin: Remove unused columns in Users table
..
Patch Set 1:
* Update tracker::#1092744::OK
* Check Bug-Url::OK
* Check Public Bug::#1092744::OK,
Ravi Nori has uploaded a new change for review.
Change subject: core, webadmin: Remove unused columns in Users table
..
core, webadmin: Remove unused columns in Users table
Remove groupds, group_ids and active columns from
the u
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core, engine: Services for providing info to the Console Proxy
..
Patch Set 2: -Code-Review -Verified
Build Failed
http://jenkins.ovirt.org/job/ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core, engine, userportal, webadmin: VirtIO console access key
management
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_mast
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tools: tests: FirstMatchSimpleFilter ignore ordering
..
Patch Set 2:
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: services, setup: VirtIO console proxy [WIP]
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/51
automat...@ovirt.org has posted comments on this change.
Change subject: services, setup: VirtIO console proxy [WIP]
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Vitor de Lima has uploaded a new change for review.
Change subject: services, setup: VirtIO console proxy [WIP]
..
services, setup: VirtIO console proxy [WIP]
This is a work-in-progress implementation of the VirtIO console proxy
automat...@ovirt.org has posted comments on this change.
Change subject: core, engine: Services for providing info to the Console Proxy
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug ur
automat...@ovirt.org has posted comments on this change.
Change subject: core, engine, userportal, webadmin: VirtIO console access key
management
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: RedirectServlet: replace localhost to engine host
..
Patch Set 2:
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_g
automat...@ovirt.org has posted comments on this change.
Change subject: tools: tests: FirstMatchSimpleFilter ignore ordering
..
Patch Set 2:
* Update tracker::#1171160::OK
* Check Bug-Url::OK
* Check Public Bug::#1171160::OK,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tools: tests: FirstMatchSimpleFilter ignore ordering
..
Patch Set 1: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engin
automat...@ovirt.org has posted comments on this change.
Change subject: utils: RedirectServlet: replace localhost to engine host
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
Alon Bar-Lev has posted comments on this change.
Change subject: tools: tests: FirstMatchSimpleFilter ignore ordering
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35905
To unsubscribe, visit http://gerr
Alon Bar-Lev has uploaded a new change for review.
Change subject: tools: tests: FirstMatchSimpleFilter ignore ordering
..
tools: tests: FirstMatchSimpleFilter ignore ordering
ignore ordering of output events as it may be at any
automat...@ovirt.org has posted comments on this change.
Change subject: tools: tests: FirstMatchSimpleFilter ignore ordering
..
Patch Set 1:
* Update tracker::#1171160::OK
* Check Bug-Url::OK
* Check Public Bug::#1171160::OK,
Greg Sheremeta has posted comments on this change.
Change subject: engine: fix findbug warning in ResourceManager
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35903
To unsubscribe, visit http://gerri
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: remove user/group sync
..
Patch Set 6: Code-Review+1
ok, great, now we can remove the useless fields within users and groups, I hope.
--
To view, visit htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: backend: Add HostDev passthrough support
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: remove user/group sync
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/22270/ :
SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Maximum no of snapshots in general subtab
..
Patch Set 4: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: WIP-Sync job for gluster volume snapshots
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_ma
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: remove user/group sync
..
Patch Set 6:
* Update tracker::#1092744::OK
* Check Bug-Url::OK
* Check Public Bug::#1092744::OK, public bug
* Check Produc
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Maximum no of snapshots in general subtab
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
Shubhendu Tripathi has uploaded a new change for review.
Change subject: gluster: WIP-Sync job for gluster volume snapshots
..
gluster: WIP-Sync job for gluster volume snapshots
Sync job for gluster volume snapshots
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: WIP-Sync job for gluster volume snapshots
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Martin Betak has posted comments on this change.
Change subject: backend: Add HostDev passthrough support
..
Patch Set 3:
DRAFT STATUS:
VDSM response parsing complete (need to decide which fields may be missing and
add null-c
automat...@ovirt.org has posted comments on this change.
Change subject: backend: Add HostDev passthrough support
..
Patch Set 3:
* Update tracker::#1099760::OK
* Check Bug-Url::OK
* Check Public Bug::#1099760::OK, public bug
*
oVirt Jenkins CI Server has posted comments on this change.
Change subject: archive: reorganizing the final tarball archive
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-log-collector_master_create-rpms-
Sandro Bonazzola has submitted this change and it was merged.
Change subject: archive: reorganizing the final tarball archive
..
archive: reorganizing the final tarball archive
Adding a top level directory to the tarball archiv
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 4:
(3 comments)
this is better, but still probably should be set explicitly by frontend when
invoking command/query instea
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/35897/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Back
automat...@ovirt.org has posted comments on this change.
Change subject: archive: reorganizing the final tarball archive
..
Patch Set 2:
* Update tracker::#1168660::OK
--
To view, visit http://gerrit.ovirt.org/35751
To unsubs
Sandro Bonazzola has posted comments on this change.
Change subject: archive: reorganizing the final tarball archive
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35751
To unsubscribe, visit http://ge
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: remove user/group sync
..
Patch Set 5:
> is this the behavior we want?
yes, of course, the current behavior is a limitation. you want to see all
groups ava
Ravi Nori has posted comments on this change.
Change subject: aaa: remove user/group sync
..
Patch Set 5:
(2 comments)
@Alon
After the change to GetAuthzGroupsByUserIdQuery when I select alonbl in UI
Users tab and choose "Di
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Add/Edit VM disks from VM dialog
..
Patch Set 18: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_un
Alexander Wels has posted comments on this change.
Change subject: engine: fix findbug warning in ResourceManager
..
Patch Set 1: Verified+1
This fixes the findbugs warning that bas been plaguing my patches. If we could
merge,
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Add/Edit VM disks from VM dialog
..
Patch Set 18:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: fix findbug warning in ResourceManager
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/22
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 4: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/2
automat...@ovirt.org has posted comments on this change.
Change subject: engine: fix findbug warning in ResourceManager
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Alexander Wels has uploaded a new change for review.
Change subject: engine: fix findbug warning in ResourceManager
..
engine: fix findbug warning in ResourceManager
- Findbugs is reporting a warning in ResourceManager this
pa
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/35897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 4:
Followed Juan's request to move logic to backend.
--
To view, visit http://gerrit.ovirt.org/35897
To unsubscribe, vis
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/35897/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Ba
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 4:
* Update tracker::#1168842::OK
* Check Bug-Url::OK
* Check Public Bug::#1168842::OK, public bug
* Check Product::
oVirt Jenkins CI Server has posted comments on this change.
Change subject: backend: Add HostDev passthrough support
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-
automat...@ovirt.org has posted comments on this change.
Change subject: backend: Add HostDev passthrough support
..
Patch Set 2:
* Update tracker::#1099760::OK
* Check Bug-Url::OK
* Check Public Bug::#1099760::OK, public bug
*
Jiří Moskovčák has posted comments on this change.
Change subject: load also pyc files when loading submonitors
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35900
To unsubscribe, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: load also pyc files when loading submonitors
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-hosted-engine-ha_gerrit/508/ : SUCCE
automat...@ovirt.org has posted comments on this change.
Change subject: load also pyc files when loading submonitors
..
Patch Set 1:
* Update tracker::#1151344::OK
--
To view, visit http://gerrit.ovirt.org/35900
To unsubscri
Jiří Moskovčák has uploaded a new change for review.
Change subject: load also pyc files when loading submonitors
..
load also pyc files when loading submonitors
Change-Id: I0dae460264f5cb0b5d83637344331ea56f8bfadd
Bug-Url: http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fire CDI event with all reloaded VdcOptions upon
ReloadConfigurationsCommand
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: added constructor to allow being 'internally' called.
..
Patch Set 5: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovir
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: rest part of UpdateAndReorderVmNicsCommand
..
Patch Set 7: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/35897/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Back
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: add 'import' functionality in vms tab
..
Patch Set 32:
(1 comment)
Seems nice. One comment inline and one question - is it intentionally not added
to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: added command to update and reorder VmNics.
..
Patch Set 6: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_m
Tomas Jelinek has posted comments on this change.
Change subject: UI: datacenter/cluster running on host behavior
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35876/1/frontend/webadmin/modules/uicommonweb/src/main/j
Sandro Bonazzola has posted comments on this change.
Change subject: yaml: add report build on patch sent
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/35884/2/jobs/confs/yaml/jobs/ovirt-reports/ovirt-reports_gerrit-
Sandro Bonazzola has posted comments on this change.
Change subject: yaml: add report build on patch sent
..
Patch Set 2: Verified-1
fails on jenkins
--
To view, visit http://gerrit.ovirt.org/35884
To unsubscribe, visit http:
Sandro Bonazzola has posted comments on this change.
Change subject: Doing proper mock cleanup
..
Patch Set 8: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/35597/8/jobs/confs/shell-scripts/mock_cleanup.sh
File jobs/co
Martin Mucha has posted comments on this change.
Change subject: core: Fire CDI event with all reloaded VdcOptions upon
ReloadConfigurationsCommand
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/34657/3/backend/manag
automat...@ovirt.org has posted comments on this change.
Change subject: core: Fire CDI event with all reloaded VdcOptions upon
ReloadConfigurationsCommand
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: use UpdateAndReorderVmNicsCommand
..
Patch Set 8: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_un
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: command for updating template nics.
..
Patch Set 6: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_un
automat...@ovirt.org has posted comments on this change.
Change subject: core: command for updating template nics.
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: core: added command to update and reorder VmNics.
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: core: added constructor to allow being 'internally' called.
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url f
automat...@ovirt.org has posted comments on this change.
Change subject: restapi: rest part of UpdateAndReorderVmNicsCommand
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: use UpdateAndReorderVmNicsCommand
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
oVirt Jenkins CI Server has posted comments on this change.
Change subject: rest: Validation of the protocol values
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.5_unit_tests_gerrit/1908/ : SUCC
Juan Hernandez has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 3:
Yes, if some change is to be done to the RESTAPI it should be to make it less
session aware, not more session aware.
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 3:
Juan -
Ok, you probably meant Queries, not commands, I understood that.
Ok, so from your perspective, no change should
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: fix session timeout
..
Patch Set 3: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/2
Juan Hernandez has posted comments on this change.
Change subject: rest: Validation of the protocol values
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35898
To unsubscribe, visit http://gerrit.ovirt
1 - 100 of 141 matches
Mail list logo