Sandro Bonazzola has posted comments on this change. Change subject: Doing proper mock cleanup ......................................................................
Patch Set 8: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/35597/8/jobs/confs/shell-scripts/mock_cleanup.sh File jobs/confs/shell-scripts/mock_cleanup.sh: Line 43: echo "ERROR: Failed to kill orphans on $chroot." Line 44: failed=true Line 45: } Line 46: Line 47: mounts=($(mount | awk '{print $3}' | grep "$chroot")) || : > Yes, it does, but I had some problems when force umounting dirs, it complai ok, thanks for explanation. maybe a "fixme" or a "todo" comment here will be useful :-) Line 48: if [[ "$mounts" ]]; then Line 49: echo "Found mounted dirs inside the chroot $chroot. Trying to umount." Line 50: fi Line 51: for mount in "${mounts[@]}"; do -- To view, visit http://gerrit.ovirt.org/35597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20cb54fb968556f3d1bdcf3a9ab14e826c56b352 Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Barak Korren <bkor...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Paz Dangur <pdan...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaft...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
