Alon Bar-Lev has posted comments on this change. Change subject: core, webadmin: Remove unused columns in Users table ......................................................................
Patch Set 1: (9 comments) Unless I am missing something, the group names is not required at any part of our application but the users tab. But it can be some weired restapi presentation... so I am unsure. http://gerrit.ovirt.org/#/c/35908/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java: Line 91: } Line 92: Line 93: public void setGroupNames(Collection<String> value) { Line 94: groupNames = new HashSet<String>(value); Line 95: } where do we use group names? Line 96: Line 97: public void setGroupIds(Collection<Guid> groupIds) { Line 98: this.groupIds = groupIds; Line 99: } http://gerrit.ovirt.org/#/c/35908/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java: Line 67 Line 68 Line 69 Line 70 Line 71 why do we need group names? where do we use it? http://gerrit.ovirt.org/#/c/35908/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineSessionDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineSessionDAODbFacadeImpl.java: I believe this should go into the session patch. Line 1: package org.ovirt.engine.core.dao; Line 2: Line 3: import org.apache.commons.lang.StringUtils; Line 4: import org.ovirt.engine.core.common.businessentities.EngineSession; http://gerrit.ovirt.org/#/c/35908/1/packaging/dbscripts/create_functions.sql File packaging/dbscripts/create_functions.sql: Line 113 Line 114 Line 115 Line 116 Line 117 I think this should go into the session patch. Line 109: FROM permissions INNER JOIN Line 110: ( Line 111: -- get all groups of admin users Line 112: SELECT ad_groups.id group_id, engine_sessions.user_id Line 113: FROM ad_groups, engine_sessions - Line 114: WHERE ad_groups.id IN Line 115: (SELECT * FROM fnsplitteruuid(engine_sessions.group_ids)) Line 116: AND engine_sessions.user_id = v_userId ) temp Line 117: ON permissions.ad_element_id = temp.group_id; Line 675: AS $function$ Line 676: BEGIN Line 677: RETURN QUERY Line 678: select ad_groups.ID from ad_groups,engine_sessions where engine_sessions.user_id = v_id Line 679: and ad_groups.id in(select * from fnsplitteruuid(engine_sessions.group_ids)) this as well. Line 680: UNION Line 681: select v_id Line 682: UNION Line 683: -- user is also member of 'Everyone' http://gerrit.ovirt.org/#/c/35908/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 893: users_1.role as role, users_1.email as email, users_1.note as note, users_1.active as active, 0 as vm_admin, Line 894: users_1.last_admin_check_status as last_admin_check_status, engine_sessions.group_ids as group_ids, Line 895: users_1.external_id as external_id, users_1.namespace as namespace Line 896: FROM users AS users_1, engine_sessions Line 897: WHERE users_1.user_id = engine_sessions.user_id this as well. Line 898: UNION Line 899: SELECT 'group' as user_group, ad_groups.name as name, ad_groups.id as id, '' as surname, ad_groups.domain as domain, '' as username, '' as groups, '' as department, '' as role, Line 900: '' as email, '' as note, true as active, 1 as vm_admin, null as last_admin_check_status, '' as group_ids, Line 901: ad_groups.external_id as external_id, ad_groups.namespace as namespace http://gerrit.ovirt.org/#/c/35908/1/packaging/dbscripts/upgrade/03_06_0600_remove_user_groupids_column.sql File packaging/dbscripts/upgrade/03_06_0600_remove_user_groupids_column.sql: Line 2: -- Add groupds to engine_sessions table Line 3: Line 4: select fn_db_add_column('engine_sessions', 'groups', 'text'); Line 5: select fn_db_drop_column('users', 'groups'); Line 6: select fn_db_drop_column('users', 'group_ids'); and of course this :) http://gerrit.ovirt.org/#/c/35908/1/packaging/dbscripts/user_sp.sql File packaging/dbscripts/user_sp.sql: Line 221: v_id := CAST(v_tempId AS UUID); Line 222: select count(*) INTO v_result from users where user_id in(select ad_element_id as user_id from permissions,roles Line 223: where permissions.role_id = roles.id Line 224: and ad_element_id in((select ad_groups.id from ad_groups,engine_sessions where engine_sessions.user_id = v_id Line 225: and ad_groups.id in(select * from fnsplitteruuid(engine_sessions.group_ids)) I believe this should go into the session patch. Line 226: union Line 227: select v_id)) Line 228: and (roles.role_type = 1 or permissions.role_id = '00000000-0000-0000-0000-000000000001')); Line 229: update users set last_admin_check_status = -- To view, visit http://gerrit.ovirt.org/35908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id813d965d0ec33035b3cf499a19441df42cc9848 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
