Alon Bar-Lev has posted comments on this change. Change subject: aaa: fix session timeout ......................................................................
Patch Set 4: (3 comments) this is better, but still probably should be set explicitly by frontend when invoking command/query instead of guessing by type, no? http://gerrit.ovirt.org/#/c/35897/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValueQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValueQuery.java: Line 5: import org.ovirt.engine.core.common.config.ConfigValues; Line 6: import org.ovirt.engine.core.common.queries.GetConfigurationValueParameters; Line 7: Line 8: public class GetConfigurationValueQuery<P extends GetConfigurationValueParameters> extends QueriesCommandBase<P> { Line 9: should be dropped. Line 10: public GetConfigurationValueQuery(P parameters) { Line 11: super(parameters); Line 12: } Line 13: http://gerrit.ovirt.org/#/c/35897/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java: Line 20: import org.ovirt.engine.core.dao.ActionGroupDAO; Line 21: import org.ovirt.engine.core.dao.VdsDAO; Line 22: import org.ovirt.engine.core.dao.scheduling.AffinityGroupDao; Line 23: import org.ovirt.engine.core.utils.log.Logged; Line 24: import org.ovirt.engine.core.utils.log.Logged.LogLevel; should be dropped. Line 25: Line 26: @Logged(executionLevel = LogLevel.TRACE, errorLevel = LogLevel.WARN) Line 27: public abstract class QueriesCommandBase<P extends VdcQueryParametersBase> extends VdcCommandBase { Line 28: http://gerrit.ovirt.org/#/c/35897/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java: Line 51: return builder.toString(); Line 52: } Line 53: Line 54: private String privateVersion; Line 55: private ConfigurationValues _configValue; move above? Line 56: -- To view, visit http://gerrit.ovirt.org/35897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6640beef3ca28f95def87ac5e29d41f75b0fddd8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
