Tomas Jelinek has posted comments on this change. Change subject: webadmin: add 'import' functionality in vms tab ......................................................................
Patch Set 32: (1 comment) Seems nice. One comment inline and one question - is it intentionally not added to user portal? Or will this come in some later patch? http://gerrit.ovirt.org/#/c/29381/32/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExternalVm.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExternalVm.java: Line 2: Line 3: import org.ovirt.engine.core.common.businessentities.VM; Line 4: import org.ovirt.engine.ui.uicommonweb.models.EntityModel; Line 5: Line 6: public class ExternalVm extends EntityModel { this seems strange... It should either be ExternalVm extends EntityModel<VM> and than have the VM as setItem() and getItem, or do not extend the EntityModel at all. Line 7: Line 8: private VM vm; Line 9: Line 10: public ExternalVm(VM vm) { -- To view, visit http://gerrit.ovirt.org/29381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aaae633518b1268e63b36894ba9e077884d4694 Gerrit-PatchSet: 32 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
