[Engine-patches] Change in ovirt-engine[master]: core: fix vm pools behavior when DC is missing

2014-02-05 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: fix vm pools behavior when DC is missing .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24130 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: Add method to determine if StorageDomainType is of typ...

2014-02-05 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: Add method to determine if StorageDomainType is of type ISO or Export .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24135 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: Fix type in ActionType

2014-02-05 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: Fix type in ActionType .. Patch Set 1: please change also in: /packaging/dbscripts/insert_predefined_roles.sql /org/ovirt/engine/ui/uicompat/LocalizedEnums.jav

[Engine-patches] Change in ovirt-engine[master]: core: Fix type in ActionType

2014-02-05 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: Fix type in ActionType .. Patch Set 1: please change also in: /packaging/dbscripts/insert_predefined_roles.sql /org/ovirt/engine/ui/uicompat/LocalizedEnums.java

[Engine-patches] Change in ovirt-engine[master]: engine: Remove javadoc from one of DiskValidator APIs

2014-02-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Remove javadoc from one of DiskValidator APIs .. Patch Set 3: Code-Review+2 Don't know what happens here, I completely misunderstood this patch. My bad.

[Engine-patches] Change in ovirt-engine[master]: engine: Validate that IDE disk is not read-only

2014-02-05 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: engine: Validate that IDE disk is not read-only .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23953 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: [WIP] webadmin : Monitoring DashBoard

2014-02-05 Thread anbabu
anmolbabu has posted comments on this change. Change subject: [WIP] webadmin : Monitoring DashBoard .. Patch Set 2: @Einav We are yet to come up with a feature page for it.The design is not yet finalised. We will get in touch

[Engine-patches] Change in ovirt-engine[master]: [WIP] webadmin : Monitoring DashBoard

2014-02-05 Thread anbabu
anmolbabu has posted comments on this change. Change subject: [WIP] webadmin : Monitoring DashBoard .. Patch Set 2: @Einav Cohen Hi einav,we are planning to add the monitoring as a new feature to our RHSC. The plan is to provi

[Engine-patches] Change in ovirt-engine[master]: [WIP] webadmin : Monitoring DashBoard

2014-02-05 Thread anbabu
anmolbabu has posted comments on this change. Change subject: [WIP] webadmin : Monitoring DashBoard .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24035/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/eng

[Engine-patches] Change in ovirt-engine[master]: engine: event subscribtion support for gluster events

2014-02-05 Thread rnachimu
Ramesh N has posted comments on this change. Change subject: engine: event subscribtion support for gluster events .. Patch Set 3: Hi Alon, This is not a real patch, its just a POC what we trying with EventBus. We can make

[Engine-patches] Change in ovirt-engine[master]: 2. [WIP] core: creating extension-manager module

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: 2. [WIP] core: creating extension-manager module .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/

[Engine-patches] Change in ovirt-engine[master]: 3. [wip] core, api, webadmin: renaming "authentication" to "...

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: 3. [wip] core, api, webadmin: renaming "authentication" to "aaa". .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_

[Engine-patches] Change in ovirt-engine[master]: 1. [WIP] core: Cleaning up common from authentication code.

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: 1. [WIP] core: Cleaning up common from authentication code. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_te

[Engine-patches] Change in ovirt-engine[master]: webadmin: refresh bookmarks

2014-02-05 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: webadmin: refresh bookmarks .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24128 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: [WIP] webadmin : Monitoring DashBoard

2014-02-05 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: [WIP] webadmin : Monitoring DashBoard .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24035/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovir

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: label value title

2014-02-05 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal,webadmin: label value title .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24138 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: iso domain nfs export fixes

2014-02-05 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: iso domain nfs export fixes .. Patch Set 4: (6 comments) better! I beginning to understand. although I think we can simplify this farther. ht

[Engine-patches] Change in ovirt-dwh[master]: packaging: build: move to ant drop maven and jboss modules

2014-02-05 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: build: move to ant drop maven and jboss modules .. packaging: build: move to ant drop maven and jboss modules Change-Id: I39550f694d7e8c37bbe189c1b9bf

[Engine-patches] Change in ovirt-dwh[master]: packaging: build: move to ant drop maven and jboss modules

2014-02-05 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: build: move to ant drop maven and jboss modules .. Patch Set 1: yaniv, please check if all is working. -- To view, visit http://gerrit.ovirt.org/2414

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core:OnVdsDuringFailureTimer log message malformed

2014-02-05 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core:OnVdsDuringFailureTimer log message malformed .. core:OnVdsDuringFailureTimer log message malformed This patch only formats the original message in a

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: label value title

2014-02-05 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: label value title .. Patch Set 1: Alexander, this is a generic fix, correct? I noticed that the problem exists in the Hosts main tab (but not

[Engine-patches] Change in ovirt-engine[master]: doc: branding: style cleanups

2014-02-05 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: doc: branding: style cleanups .. doc: branding: style cleanups Change-Id: I339f60c54aa6e54ff78d82e525b00dff8ba36026 Signed-off-by: Alon Bar-Lev --- M README.bra

[Engine-patches] Change in ovirt-engine[master]: doc: branding: style cleanups

2014-02-05 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: doc: branding: style cleanups .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24141 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core:OnVdsDuringFailureTimer log message malformed

2014-02-05 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core:OnVdsDuringFailureTimer log message malformed .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23824 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core, engine: Prevent DC removal with clusters on it

2014-02-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core, engine: Prevent DC removal with clusters on it .. Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/24109/1/backend/manager/modules/dal/src/main/resource

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core:OnVdsDuringFailureTimer log message malformed

2014-02-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core:OnVdsDuringFailureTimer log message malformed .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23824/1/backend/manager/modules/vdsbroker/src/main/java/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Set default proxy preferences for existing Hosts

2014-02-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: Set default proxy preferences for existing Hosts .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23820/1/packaging/dbscripts/upgrade/03_04_0550_set_proxy_p

[Engine-patches] Change in ovirt-engine[master]: fixing integer out of range exception in search

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: fixing integer out of range exception in search .. Patch Set 8: -Verified Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_test

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Default DC & Cluster has fixed UUIDs

2014-02-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: Default DC & Cluster has fixed UUIDs .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24087/1/packaging/dbscripts/insert_data.sql File packaging/dbscripts/i

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: synchronous multiple action

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine, webadmin: synchronous multiple action .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/155

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: synchronous multiple action

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine, webadmin: synchronous multiple action .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ger

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: synchronous multiple action

2014-02-05 Thread awels
Alexander Wels has posted comments on this change. Change subject: engine, webadmin: synchronous multiple action .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/23032 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: fixing integer out of range exception in search

2014-02-05 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: fixing integer out of range exception in search .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23488 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: synchronous multiple action

2014-02-05 Thread awels
Alexander Wels has posted comments on this change. Change subject: engine, webadmin: synchronous multiple action .. Patch Set 1: You make a very valid point, especially since we have a parallellRunner already. I have modified

[Engine-patches] Change in ovirt-engine[master]: engine: Validate that IDE disk is not read-only

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Validate that IDE disk is not read-only .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent selection of IDE disk as read-only in UI

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_u

[Engine-patches] Change in ovirt-engine[master]: engine: Validate that IDE disk is not read-only

2014-02-05 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Validate that IDE disk is not read-only .. Patch Set 5: Verified+1 Rebase. -- To view, visit http://gerrit.ovirt.org/23953 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent selection of IDE disk as read-only in UI

2014-02-05 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/23998 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: iso domain nfs export fixes

2014-02-05 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: iso domain nfs export fixes .. Patch Set 4: Did not verify yet, but I already like it. No caching at all. If you agree with the design, w

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: Only top level elements in root class map

2014-02-05 Thread mishka8520
Michael Pasternak has posted comments on this change. Change subject: codegen: Only top level elements in root class map .. Patch Set 1: > I don't see where in the CLI we use the findRootClass method, so a > modification > the

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-05 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/24024 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Add empty export method to decorator base

2014-02-05 Thread mishka8520
Michael Pasternak has posted comments on this change. Change subject: sdk: Add empty export method to decorator base .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24131/3/src/ovirtsdk/infrastructure/common.py File sr

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Add empty export method to decorator base

2014-02-05 Thread mishka8520
Michael Pasternak has posted comments on this change. Change subject: sdk: Add empty export method to decorator base .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/24131/3//COMMIT_MSG Commit Message: Line 16: clas

[Engine-patches] Change in ovirt-engine[master]: tools: Fix permissions for users added by engine-manage-domains

2014-02-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: tools: Fix permissions for users added by engine-manage-domains .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24106 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Fix admin@internal permissions

2014-02-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Fix admin@internal permissions .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24107/1/packaging/dbscripts/insert_predefined_roles.sql File packaging

[Engine-patches] Change in ovirt-engine[master]: core: fix vm pools behavior when DC is missing

2014-02-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: fix vm pools behavior when DC is missing .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24130 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core, engine: Fix HotPlugCpuSupported config value

2014-02-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core, engine: Fix HotPlugCpuSupported config value .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24134/1/packaging/dbscripts/upgrade/pre_upgrade/_con

[Engine-patches] Change in ovirt-engine[master]: webadmin: Dialogue for attaching ISOs is not logically ordered

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit

[Engine-patches] Change in ovirt-engine[master]: engine: Rephrase confusing audit log message

2014-02-05 Thread derez
Daniel Erez has posted comments on this change. Change subject: engine: Rephrase confusing audit log message .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23956 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Dialogue for attaching ISOs is not logically ordered

2014-02-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24019 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Dialogue for attaching ISOs is not logically ordered

2014-02-05 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered .. webadmin: Dialogue for attaching ISOs is not logically ordered In install host dialog the

[Engine-patches] Change in ovirt-engine[master]: engine: Rephrase confusing audit log message

2014-02-05 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: engine: Rephrase confusing audit log message .. engine: Rephrase confusing audit log message Previous audit log message contained a contradiction. It prop

[Engine-patches] Change in ovirt-engine[master]: fixing integer out of range exception in search

2014-02-05 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: fixing integer out of range exception in search .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23488 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: fixing integer out of range exception in search

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: fixing integer out of range exception in search .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_g

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: label value title

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal,webadmin: label value title .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1550/ : S

[Engine-patches] Change in ovirt-engine[master]: fixing integer out of range exception in search

2014-02-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: fixing integer out of range exception in search .. Patch Set 7: Verified+1 Found a bug when doing paging in the Events TAB , not related to this one so I will open

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: label value title

2014-02-05 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: label value title .. Patch Set 1: Verified+1 Just the TextBoxLabels where showing the tooltip (as the title attribute was for them). Moved

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: label value title

2014-02-05 Thread awels
Alexander Wels has uploaded a new change for review. Change subject: userportal,webadmin: label value title .. userportal,webadmin: label value title - Moved the title code from TextBoxLabel to TextBoxLabelBase so that all sub

[Engine-patches] Change in ovirt-engine[master]: engine: Rephrase confusing audit log message

2014-02-05 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Rephrase confusing audit log message .. Patch Set 3: Verified+1 User name is back :-) -- To view, visit http://gerrit.ovirt.org/23956 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: core: Add method to determine if StorageDomainType is of typ...

2014-02-05 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: core: Add method to determine if StorageDomainType is of type ISO or Export .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24135 To un

[Engine-patches] Change in ovirt-engine[master]: core: Fix type in ActionType

2014-02-05 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: core: Fix type in ActionType .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24136 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: webadmin: Remove redundant comments in DataCenterStorageList...

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Remove redundant comments in DataCenterStorageListModel .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_

[Engine-patches] Change in ovirt-engine[master]: engine: event subscribtion support for gluster events

2014-02-05 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: event subscribtion support for gluster events .. Patch Set 3: Hi, we are working on [way too late] extension model for the engine, this will also addre

[Engine-patches] Change in ovirt-engine[master]: [WIP] webadmin : Monitoring DashBoard

2014-02-05 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: [WIP] webadmin : Monitoring DashBoard .. Patch Set 2: Hi Anmol, can you please elaborate on this patch a little? is that a new feature? do you have a feature-page

[Engine-patches] Change in ovirt-engine[master]: core: disk live migrate - snapshot only on migrated disks

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: disk live migrate - snapshot only on migrated disks .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_un

[Engine-patches] Change in ovirt-engine[master]: core: Add method to determine if StorageDomainType is of typ...

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add method to determine if StorageDomainType is of type ISO or Export .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engi

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen: Only top level elements in root class map

2014-02-05 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: codegen: Only top level elements in root class map .. Patch Set 1: I don't see where in the CLI we use the findRootClass method, so a modification there won't

[Engine-patches] Change in ovirt-engine[master]: webadmin: Remove redundant comments in DataCenterStorageList...

2014-02-05 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: webadmin: Remove redundant comments in DataCenterStorageListModel .. webadmin: Remove redundant comments in DataCenterStorageListModel Change-Id: I88f3fc822790a0c6

[Engine-patches] Change in ovirt-engine[master]: core: Fix type in ActionType

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix type in ActionType .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1548/ : SUCCESS ht

[Engine-patches] Change in ovirt-engine[master]: core: Add method to determine if StorageDomainType is of typ...

2014-02-05 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: core: Add method to determine if StorageDomainType is of type ISO or Export .. core: Add method to determine if StorageDomainType is of type ISO or Export The chec

[Engine-patches] Change in ovirt-engine[master]: core: adjustments needed to support instance types

2014-02-05 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: adjustments needed to support instance types .. Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/23828/12//COMMIT_MSG Commit Message: Line 9: Three th

[Engine-patches] Change in ovirt-engine[master]: core: Fix type in ActionType

2014-02-05 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: core: Fix type in ActionType .. core: Fix type in ActionType ActionType.MANIPUTLATE_HOST renamed to ActionType.MANIPULATE_HOST Change-Id: Iaa3e7c526fe3b05c1e7dbe9c

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: Move logs out of /usr

2014-02-05 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: Move logs out of /usr .. packaging: setup: Move logs out of /usr Move logging of fkvalidator.sh and taskcleaner.sh to the setup log file

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Move logs out of /usr

2014-02-05 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: Move logs out of /usr .. packaging: setup: Move logs out of /usr Move logging of fkvalidator.sh and taskcleaner.sh to the setup log file

[Engine-patches] Change in ovirt-engine[master]: core, engine: Fix HotPlugCpuSupported config value

2014-02-05 Thread vitor . lima
Vitor de Lima has posted comments on this change. Change subject: core, engine: Fix HotPlugCpuSupported config value .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24134 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: Set proper severity to a failed command

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Set proper severity to a failed command .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_g

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Add empty export method to decorator base

2014-02-05 Thread rnori
Ravi Nori has posted comments on this change. Change subject: sdk: Add empty export method to decorator base .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24131 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core, engine: Fix HotPlugCpuSupported config value

2014-02-05 Thread vitor . lima
Vitor de Lima has uploaded a new change for review. Change subject: core, engine: Fix HotPlugCpuSupported config value .. core, engine: Fix HotPlugCpuSupported config value The 'HotPlugCpuSupported' configuration value was not p

[Engine-patches] Change in ovirt-engine[master]: engine: Rephrase confusing audit log message

2014-02-05 Thread abaron
Ayal Baron has posted comments on this change. Change subject: engine: Rephrase confusing audit log message .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23956 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix disk alias recycling

2014-02-05 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin: Fix disk alias recycling .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24061 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: engine: Rephrase confusing audit log message

2014-02-05 Thread derez
Daniel Erez has posted comments on this change. Change subject: engine: Rephrase confusing audit log message .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23956/2/backend/manager/modules/dal/src/main/resources/bundle

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix disk alias recycling

2014-02-05 Thread tnisan
Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix disk alias recycling .. webadmin: Fix disk alias recycling When creating a new disk via webadmin, the suggested disk alias created the suggest

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix disk alias recycling

2014-02-05 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin: Fix disk alias recycling .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/24061 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] [oVirt Jenkins] ovirt_engine_master_find_bugs - Build # 6419 - Failure!

2014-02-05 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6419/ Build Number: 6419 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Add empty export method to decorator base

2014-02-05 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: sdk: Add empty export method to decorator base .. sdk: Add empty export method to decorator base Decorators for resources and collections extend a common base

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix disk alias recycling

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Fix disk alias recycling .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1545/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix disk alias recycling

2014-02-05 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin: Fix disk alias recycling .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24061/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/b

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix disk alias recycling

2014-02-05 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin: Fix disk alias recycling .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/24061/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/

[Engine-patches] Change in ovirt-engine[master]: webadmin: refresh bookmarks

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: refresh bookmarks .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1543/ : SUCCESS htt

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Add empty export method to decorator base

2014-02-05 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: sdk: Add empty export method to decorator base .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24131 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: core: Use FixturesTool in VmDAOTest

2014-02-05 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Use FixturesTool in VmDAOTest .. core: Use FixturesTool in VmDAOTest Removed local constants and hardcoded values and used FixturesTools constants

[Engine-patches] Change in ovirt-engine[master]: core: Use FixturesTool in VmDAOTest

2014-02-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Use FixturesTool in VmDAOTest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24037 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: restapi: Add support for adding and plugging disk to a runni...

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Add support for adding and plugging disk to a running VM .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_

[Engine-patches] Change in ovirt-engine[master]: core: fix vm pools behavior when DC is missing

2014-02-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: fix vm pools behavior when DC is missing .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24130 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: webadmin: refresh bookmarks

2014-02-05 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: refresh bookmarks .. Patch Set 1: Verified+1 Verified that this fixes the problem. I was concerned about how this got broken, and it appears to be co

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Move logs out of /usr

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: setup: Move logs out of /usr .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_find_bugs_gerrit/5274/ : SUCCE

[Engine-patches] Change in ovirt-engine-cli[master]: cli: Change action help text to match syntax

2014-02-05 Thread mishka8520
Michael Pasternak has posted comments on this change. Change subject: cli: Change action help text to match syntax .. Patch Set 1: Code-Review+2 if you just want to get rid of old syntax being adv., (but still support it), go

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: Move logs out of /usr

2014-02-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: setup: Move logs out of /usr .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/504/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: core: fix vm pools behavior when DC is missing

2014-02-05 Thread ofrenkel
Omer Frenkel has uploaded a new change for review. Change subject: core: fix vm pools behavior when DC is missing .. core: fix vm pools behavior when DC is missing When DC is missing (for example force-removed) then if any vm po

  1   2   3   4   >