Juan Hernandez has posted comments on this change. Change subject: codegen: Only top level elements in root class map ......................................................................
Patch Set 1: I don't see where in the CLI we use the findRootClass method, so a modification there won't affect the CLI. Letting the users use that findRootClass method ins't good idea either, as it won't work correctly if the same element name is used for more than one type, as it is the case with the recent changes in the XML schema. The use of this map should be limited to what its name indicates: locating the *root* class name. -- To view, visit http://gerrit.ovirt.org/23964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcdefe71f3d15ab0da841f35b4b94916d19d950d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
