Daniel Erez has posted comments on this change. Change subject: engine: Rephrase confusing audit log message ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23956/2/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 110: USER_FAILED_MOVED_VM_DISK=User ${UserName} failed to move disk ${DiskAlias} to domain ${StorageDomainName}. Line 111: USER_MOVED_VM_DISK_FINISHED_SUCCESS=User ${UserName} finished moving disk ${DiskAlias} to domain ${StorageDomainName}. Line 112: USER_MOVED_VM_DISK_FINISHED_FAILURE=User ${UserName} have failed to move disk ${DiskAlias} to domain ${StorageDomainName}. Line 113: USER_FINISHED_REMOVE_DISK=Disk ${DiskAlias} was successfully removed from domain ${StorageDomainName} (User ${UserName}. Line 114: USER_FINISHED_FAILED_REMOVE_DISK=Failed to remove disk ${DiskAlias} from storage domain ${StorageDomainName}. What about (User ${UserName}) ? Line 115: USER_ATTACH_DISK_TO_VM=Disk ${DiskAlias} was successfully attached to VM ${VmName} by ${UserName}. Line 116: USER_FAILED_ATTACH_DISK_TO_VM=Failed to attach Disk ${DiskAlias} to VM ${VmName} (User: ${UserName}). Line 117: USER_DETACH_DISK_FROM_VM=Disk ${DiskAlias} was successfully detached from VM ${VmName} by ${UserName}. Line 118: USER_FAILED_DETACH_DISK_FROM_VM=Failed to detach Disk ${DiskAlias} from VM ${VmName} (User: ${UserName}). -- To view, visit http://gerrit.ovirt.org/23956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3544d1fde9bb33422175e3212d87c0d190870ff4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: A Burden <abur...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
