Eli Mesika has posted comments on this change. Change subject: core, engine: Prevent DC removal with clusters on it ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/24109/1/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 458: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_IMAGES=Cannot remove Data Center while it contains disks.\n\ Line 459: -Please remove them first. Line 460: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_VMS=Cannot remove Data Center while there are VMs on it.\n\ Line 461: -Please remove all VMs and Templates first. Line 462: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_CLUSTERS=Cannot remove Data Center while there are clusters on it.\n\ Aren't we using in most cases Cannot ${action} ${type} while those are taken from enum and the values are in the property files ? I see that some errors here missed that , but we should prevent that on new code Line 463: -Please remove all clusters first. Line 464: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_NONMASTER_DOMAINS=Cannot remove Data Center while there are more than one Storage Domain attached. Line 465: ERROR_CANNOT_REMOVE_STORAGE_DOMAIN_DO_FORMAT=Cannot remove Storage Domain. Data storage must be formatted after remove.\n\ Line 466: -Please verify that Format option is enabled on the Data Domain. http://gerrit.ovirt.org/#/c/24109/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 1260: Line 1261: @DefaultStringValue("Cannot remove Data Center while there are VMs on it.\n-Please remove all VMs and Templates first.") Line 1262: String ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_VMS(); Line 1263: Line 1264: @DefaultStringValue("Cannot remove Data Center while there are clusters on it.\n-Please remove all clusters first.") same (see prev comments) Line 1265: String ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_CLUSTERS(); Line 1266: Line 1267: @DefaultStringValue("Cannot remove Data Center while there are more than one Storage Domains attached.") Line 1268: String ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_NONMASTER_DOMAINS(); http://gerrit.ovirt.org/#/c/24109/1/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 432: -Please remove them first. Line 433: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_VMS=Cannot remove Data Center while there are VMs on it.\n\ Line 434: -Please remove all VMs and Templates first. Line 435: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_CLUSTERS=Cannot remove Data Center while there are clusters on it.\n\ Line 436: -Please remove all clusters first. same (see prev comments) Line 437: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_NONMASTER_DOMAINS=Cannot remove Data Center when there are more than one Storage Domain attached. Line 438: ERROR_CANNOT_REMOVE_STORAGE_DOMAIN_DO_FORMAT=Cannot remove Storage Domain. Data storage must be formatted after remove.\n\ Line 439: -Please verify that Format option is enabled on the Data Domain. Line 440: ERROR_CANNOT_MANAGE_STORAGE_DOMAIN=Cannot manage Storage Domain. The domain is defined externally (such as through a provider). http://gerrit.ovirt.org/#/c/24109/1/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 462: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_IMAGES=Cannot remove Data Center while it contains disks.\n\ Line 463: -Please remove them first. Line 464: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_VMS=Cannot remove Data Center while there are VMs on it.\n\ Line 465: -Please remove all VMs and Templates first. Line 466: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_VMS=Cannot remove Data Center while there are clusters on it.\n\ same (see prev comments) Line 467: -Please remove all clusters first. Line 468: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_NONMASTER_DOMAINS=Cannot remove Data Center when there are more than one Storage Domain attached. Line 469: ERROR_CANNOT_REMOVE_STORAGE_DOMAIN_DO_FORMAT=Cannot remove Storage Domain. Data storage must be formatted after remove.\n\ Line 470: -Please verify that Format option is enabled on the Data Domain. -- To view, visit http://gerrit.ovirt.org/24109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9323c500b5a38f2535891e247ca88d2973157eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
