Michael Pasternak has posted comments on this change. Change subject: sdk: Add empty export method to decorator base ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24131/3/src/ovirtsdk/infrastructure/common.py File src/ovirtsdk/infrastructure/common.py: Line 47: def export(self, outfile, level, namespace_='', name_='', namespacedef_='', pretty_print=True): Line 48: # This empty method is necessary in order to avoid exceptions when the Line 49: # infrastructure tries to invoke it on a collection decorator that is Line 50: # used as a parameter. Line 51: pass Juan, well done!, but it's only a partial fix, you need to intercept setters with params.py.__setattr__, you can do that in params-codegen, please see explanations in commit.message thanks -- To view, visit http://gerrit.ovirt.org/24131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7843dea85c9f09de5fb3439f57dba71ce6a28898 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
