[Engine-patches] Change in ovirt-engine[master]: core: WIP: Adding JPA to ovirt

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: WIP: Adding JPA to ovirt .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1400/ : FA

[Engine-patches] Change in ovirt-engine[master]: core: fix error message on create template from VM when the ...

2014-02-03 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: core: fix error message on create template from VM when the VM is locked .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23807 To unsub

[Engine-patches] Change in ovirt-engine[master]: Incorrect mapping: DWH_STOPPED - History Service Started

2014-02-03 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: Incorrect mapping: DWH_STOPPED - History Service Started .. Patch Set 1: Code-Review+2 I don't know why I always forget that thanks :) -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: searchBackend: rename methods to begin with lowercase letter

2014-02-03 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: searchBackend: rename methods to begin with lowercase letter .. Patch Set 6: I think we have all the needed ACKs ACKs to merge this one. Let's wait for one day, s

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add warning when modifying management network

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Add warning when modifying management network .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_

[Engine-patches] Change in ovirt-engine[master]: compat: rename methods to begin with lowercase letter

2014-02-03 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: compat: rename methods to begin with lowercase letter .. Patch Set 4: Code-Review+1 I think we have all the needed ACKs ACKs to merge this one. Let's wait for one

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add warning when modifying management network

2014-02-03 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Add warning when modifying management network .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23892 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add warning when modifying management network

2014-02-03 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Add warning when modifying management network .. webadmin: Add warning when modifying management network Added warning that certain changes in t

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: gluster: fix cleaning up orphan tasks

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/479/ : SUCCESS

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: gluster: fix cleaning up orphan tasks

2014-02-03 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24025 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: gluster: fix cleaning up orphan tasks

2014-02-03 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24025 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: gluster: fix cleaning up orphan tasks

2014-02-03 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks .. Patch Set 1: * Tracker #1060994: OK * Set POST #1060994: OK -- To view, visit http://gerrit.ovirt.org/24025 To

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: gluster: fix cleaning up orphan tasks

2014-02-03 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: gluster: fix cleaning up orphan tasks .. gluster: fix cleaning up orphan tasks When there is rebalance task in progress and 'task list' is failed in vdsm for some

[Engine-patches] Change in ovirt-engine[master]: core: [Fix] NPE in GlusterSyncJob

2014-02-03 Thread sabose
Sahina Bose has posted comments on this change. Change subject: core: [Fix] NPE in GlusterSyncJob .. Patch Set 1: @Gustavo, Ok..but fixing a possible NPE is nevertheless good, as it will make sure the rest of the sync job will

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: support classless IN-ADDR.ARPA delegation

2014-02-03 Thread love . cairn
Mark Kachi has posted comments on this change. Change subject: packaging: setup: support classless IN-ADDR.ARPA delegation .. Patch Set 3: Verified+1 Hi Alon, Thank you for the patch set 3. I checked it with no problems. Tha

[Engine-patches] Change in ovirt-engine[master]: core: [Fix] NPE in GlusterSyncJob

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: [Fix] NPE in GlusterSyncJob .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/23817 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: Change used configured range for display port to 5900-6923

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: Change used configured range for display port to 5900-6923 .. Patch Set 1: anyway, config.sql was change since patch was first uploaded - please rebase manually.

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: Change used configured range for display port to 5900-6923

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: Change used configured range for display port to 5900-6923 .. Patch Set 1: sorry, i don't understand the comment. you are saying it goes with patch http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: webadmin: Confirmation window when putting storage domain on...

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: gluster:Datatype change for bytesRead & bytesWritten from in...

2014-02-03 Thread dnarayan
Darshan N has abandoned this change. Change subject: gluster:Datatype change for bytesRead & bytesWritten from int to long. .. Abandoned -- To view, visit http://gerrit.ovirt.org/23746 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-03 Thread sgotliv
Sergey Gotliv has uploaded a new change for review. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. webadmin: Add confirmation window when deactivating a VM disk Change-Id: I13d9aa5386efd676d7b9d

[Engine-patches] Change in ovirt-engine[master]: webadmin: Confirmation window when putting storage domain on...

2014-02-03 Thread sgotliv
Sergey Gotliv has uploaded a new change for review. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. webadmin: Confirmation window when putting storage domain on maintenance Change-Id:

[Engine-patches] Change in ovirt-engine[master]: webadmin: Use DirectoryStub at custom serializer.

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Use DirectoryStub at custom serializer. .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests

[Engine-patches] Change in ovirt-engine[master]: webadmin: Use DirectoryStub at custom serializer.

2014-02-03 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: webadmin: Use DirectoryStub at custom serializer. .. webadmin: Use DirectoryStub at custom serializer. Since UI needs only the attributes of the directory and

[Engine-patches] Change in ovirt-engine[master]: gluster: fix cleaning up orphan tasks

2014-02-03 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fix cleaning up orphan tasks .. gluster: fix cleaning up orphan tasks When there is rebalance task in progress and 'task list' is failed in vdsm

[Engine-patches] Change in ovirt-engine[master]: gluster: fix cleaning up orphan tasks

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1395/ : SU

[Engine-patches] Change in ovirt-engine[master]: webadmin: [WIP] Stop remove-brick - tech preview warning

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: [WIP] Stop remove-brick - tech preview warning .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests

[Engine-patches] Change in ovirt-engine[master]: webadmin: [WIP] Stop remove-brick - tech preview warning

2014-02-03 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: [WIP] Stop remove-brick - tech preview warning .. webadmin: [WIP] Stop remove-brick - tech preview warning Added 'Tech Preview' message for stopping rem

[Engine-patches] Change in ovirt-engine[master]: webadmin: Dialogue for attaching ISOs is not logically ordered

2014-02-03 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24019 To uns

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: _commands -> _setup

2014-02-03 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: setup: _commands -> _setup .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24005 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: _commands -> _setup

2014-02-03 Thread ydary
Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: _commands -> _setup .. packaging: setup: _commands -> _setup Probably copied from common. Change-Id: I1f456e0924cc5f3f3e85a185690de4fe10

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: _commands -> _setup

2014-02-03 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: setup: _commands -> _setup .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24005 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: gluster: fix cleaning up orphan tasks

2014-02-03 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23936 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: userportal: allow links in MOTD

2014-02-03 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: userportal: allow links in MOTD .. Patch Set 2: Code-Review-1 I tried login in to webadmin with a user with expired password. I receive a message with a URL, b

[Engine-patches] Change in ovirt-engine[master]: core: Split UPN in case of open ldap "get user by upn" query

2014-02-03 Thread yzaslavs
Yair Zaslavsky has abandoned this change. Change subject: core: Split UPN in case of open ldap "get user by upn" query .. Abandoned Fixed at http://gerrit.ovirt.org/#/c/17794/ -- To view, visit http://gerrit.ovirt.org/17631 T

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Overwrite iso nfs export only if new

2014-02-03 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Overwrite iso nfs export only if new .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23975/1/packaging/setup/plugins/ovirt-engine-setup

[Engine-patches] Change in ovirt-engine[master]: webadmin: Dialogue for attaching ISOs is not logically ordered

2014-02-03 Thread emesika
Eli Mesika has posted comments on this change. Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24019 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: Change used configured range for display port to 5900-6923

2014-02-03 Thread emesika
Eli Mesika has posted comments on this change. Change subject: Change used configured range for display port to 5900-6923 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23941 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 14: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-03 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/21052/13/build/helptag_checker.py File build/he

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-03 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 14: Verified-1 addressed Alon's last concern. Thanks for the help :) -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: [wip] webadmin: enable the spice-xpi extension for chrome

2014-02-03 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: [wip] webadmin: enable the spice-xpi extension for chrome .. Patch Set 1: Tomas, can you please pick this up? -- To view, visit http://gerrit.ovirt.org/9679

[Engine-patches] Change in ovirt-engine[master]: [WIP] : [db] create application objects within own schema

2014-02-03 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: [WIP] : [db] create application objects within own schema .. Patch Set 5: > ping? this is for future reference when and if the postgresql jdbc driver will be i

[Engine-patches] Change in ovirt-engine[master]: [wip] webadmin: enable the spice-xpi extension for chrome

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: [wip] webadmin: enable the spice-xpi extension for chrome .. Patch Set 1: no comment for 2 months, any reason not to abandon? -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: restapi: Include charset in JSON Content-Type

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: restapi: Include charset in JSON Content-Type .. Patch Set 3: ping? -- To view, visit http://gerrit.ovirt.org/20104 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: compat: rename methods to begin with lowercase letter

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: compat: rename methods to begin with lowercase letter .. Patch Set 4: ping? -- To view, visit http://gerrit.ovirt.org/14647 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: [WIP] : [db] create application objects within own schema

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: [WIP] : [db] create application objects within own schema .. Patch Set 5: ping? -- To view, visit http://gerrit.ovirt.org/14978 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: remove VdcObjectType from ActionGroup enum

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: remove VdcObjectType from ActionGroup enum .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/19280 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-hosted-engine-ha[master]: broker: check status of network bridge

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: broker: check status of network bridge .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/20602 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in mom[master]: Add collector that computes the amount of swap used by Qemu ...

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: Add collector that computes the amount of swap used by Qemu alone .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/21970 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: vdsm: use downloadImage instead of uploadVolume

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: vdsm: use downloadImage instead of uploadVolume .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/21923 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: searchBackend: rename methods to begin with lowercase letter

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: searchBackend: rename methods to begin with lowercase letter .. Patch Set 6: ping? -- To view, visit http://gerrit.ovirt.org/14649 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: rm unused members & getters from ActionGroup

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: rm unused members & getters from ActionGroup .. Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/21988 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: Split UPN in case of open ldap "get user by upn" query

2014-02-03 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: Split UPN in case of open ldap "get user by upn" query .. Patch Set 2: ping? -- To view, visit http://gerrit.ovirt.org/17631 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 13: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-03 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/21052/13/build/helptag_checker.py File build/help

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-03 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/21052/12/build/helptag_checker.py File build/help

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-03 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 13: Verified-1 addressed all of Alon's concerns. Java not building, but focusing on python

[Engine-patches] Change in ovirt-engine[master]: engine: refactor: add Model attribute for help tagging

2014-02-03 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging .. Patch Set 12: (11 comments) http://gerrit.ovirt.org/#/c/21052/12/build/helptag.py File build/helptag.

[Engine-patches] Change in ovirt-engine[master]: core: Enable ServletUtilsTest.testCanReadFile()

2014-02-03 Thread awels
Alexander Wels has posted comments on this change. Change subject: core: Enable ServletUtilsTest.testCanReadFile() .. Patch Set 1: Let me know if you can't merge it. -- To view, visit http://gerrit.ovirt.org/23713 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Enable ServletUtilsTest.testCanReadFile()

2014-02-03 Thread awels
Alexander Wels has posted comments on this change. Change subject: core: Enable ServletUtilsTest.testCanReadFile() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23713 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: Don't duplicate directory name in the DB

2014-02-03 Thread awels
Alexander Wels has posted comments on this change. Change subject: core: Don't duplicate directory name in the DB .. Patch Set 3: Code-Review+1 +1 on the UI part of this patch. -- To view, visit http://gerrit.ovirt.org/23902

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi: Validate unsigned short integers correctly

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Validate unsigned short integers correctly .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi: Validate unsigned short integers correctly

2014-02-03 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi: Validate unsigned short integers correctly .. Patch Set 3: * Tracker #1000796: OK * Set POST #1000796: OK, already on POST -- To view, visit ht

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi: Validate unsigned short integers correctly

2014-02-03 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: restapi: Validate unsigned short integers correctly .. restapi: Validate unsigned short integers correctly Recently, in commit 14e9da, we introduced a val

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi : ints and shorts overflow

2014-02-03 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: restapi : ints and shorts overflow .. restapi : ints and shorts overflow int and short values are overflown before they even reach the business code, allo

[Engine-patches] Change in ovirt-engine[master]: tools: Rename EventNotificationMethods to EventNotificationM...

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Rename EventNotificationMethods to EventNotificationMethod. .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_maste

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-03 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 1: (2 comments) well, I still do not see my code. I do not understand... why you insist to ab

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix action button regression fix

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Fix action button regression fix .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/477/ : SU

[Engine-patches] Change in ovirt-engine[master]: core, engine: Prevent VM suspend in the ppc64 arch

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core, engine: Prevent VM suspend in the ppc64 arch .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerri

[Engine-patches] Change in ovirt-engine[master]: tools: Support snmp trap as a notification method.

2014-02-03 Thread mtayer
mooli tayer has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. .. Patch Set 21: (1 comment) http://gerrit.ovirt.org/#/c/22909/21/packaging/services/ovirt-engine-notifier/ovir

[Engine-patches] Change in ovirt-engine[master]: webadmin: Dialogue for attaching ISOs is not logically ordered

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit

[Engine-patches] Change in ovirt-engine[master]: tools: Support snmp trap as a notification method.

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. .. Patch Set 21: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tes

[Engine-patches] Change in ovirt-engine[master]: webadmin: Dialogue for attaching ISOs is not logically ordered

2014-02-03 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered .. webadmin: Dialogue for attaching ISOs is not logically ordered In install host dialog the iso's li

[Engine-patches] Change in ovirt-engine[master]: webadmin: Dialogue for attaching ISOs is not logically ordered

2014-02-03 Thread rnori
Ravi Nori has posted comments on this change. Change subject: webadmin: Dialogue for attaching ISOs is not logically ordered .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24019 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: tools: Notification properties changes.

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Notification properties changes. .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1387/ :

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_t

[Engine-patches] Change in ovirt-engine[master]: tools: Required changes in events data mapping.

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Required changes in events data mapping. .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1383

[Engine-patches] Change in ovirt-engine[master]: tools: Remove auxiliary email address from EventSender inter...

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Remove auxiliary email address from EventSender interface .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_

[Engine-patches] Change in ovirt-engine[master]: utils: add getProperty with an optionalSuffix String.

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add getProperty with an optionalSuffix String. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit

[Engine-patches] Change in ovirt-engine[master]: tools: Reorganize packages

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Reorganize packages .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1382/ : FAILURE http://j

[Engine-patches] Change in ovirt-engine[master]: tools: This change introduces the EventSubscribersProvider i...

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: This change introduces the EventSubscribersProvider interface. .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_

[Engine-patches] Change in ovirt-engine[master]: tools: Refactor model and DB mapping of eventNotificationMet...

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Refactor model and DB mapping of eventNotificationMethods. .. Patch Set 28: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi: Validate unsigned short integers correctly

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Validate unsigned short integers correctly .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent VM suspend in the ppc64 arch

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Prevent VM suspend in the ppc64 arch .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/13

[Engine-patches] Change in ovirt-engine[master]: core, engine, webadmin: Retrieve Capabilities for each Archi...

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core, engine, webadmin: Retrieve Capabilities for each Architecture .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_maste

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix action button regression fix

2014-02-03 Thread awels
Alexander Wels has uploaded a new change for review. Change subject: webadmin: Fix action button regression fix .. webadmin: Fix action button regression fix - Fixed certain situations where the previous fix failed to fix the

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix action button regression fix

2014-02-03 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Fix action button regression fix .. Patch Set 1: * Tracker #1058214: OK * Set POST #1058214: OK -- To view, visit http://gerrit.ovirt.org/2401

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix action button regression fix

2014-02-03 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Fix action button regression fix .. Patch Set 1: Verified+1 Backport -- To view, visit http://gerrit.ovirt.org/24017 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core, engine: Prevent VM suspend in the ppc64 arch

2014-02-03 Thread vitor . lima
Vitor de Lima has uploaded a new change for review. Change subject: core, engine: Prevent VM suspend in the ppc64 arch .. core, engine: Prevent VM suspend in the ppc64 arch This change prevents the suspension of VMs in architect

[Engine-patches] Change in ovirt-engine[master]: utils: add getProperty with an optionalSuffix String.

2014-02-03 Thread mtayer
mooli tayer has posted comments on this change. Change subject: utils: add getProperty with an optionalSuffix String. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23979 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent VM suspend in the ppc64 arch

2014-02-03 Thread vitor . lima
Vitor de Lima has uploaded a new change for review. Change subject: webadmin: Prevent VM suspend in the ppc64 arch .. webadmin: Prevent VM suspend in the ppc64 arch This change prevents the suspension of VMs in architectures tha

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi : ints and shorts overflow

2014-02-03 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: restapi : ints and shorts overflow .. Patch Set 1: Code-Review+2 Note that this should be merged together with http://gerrit.ovirt.org/23950 , as they are part

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi: Validate unsigned short integers correctly

2014-02-03 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: restapi: Validate unsigned short integers correctly .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23950 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi: Validate unsigned short integers correctly

2014-02-03 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi: Validate unsigned short integers correctly .. Patch Set 2: * Tracker #1000796: OK * Set POST #1000796: OK, already on POST -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: Change NIC type from sPAPR VLAN to any other

2014-02-03 Thread leonardo . bianconi
Leonardo Bianconi has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24014 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Change NIC type from sPAPR VLAN to any other

2014-02-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerri

[Engine-patches] Change in ovirt-engine[master]: core: Change NIC type from sPAPR VLAN to any other

2014-02-03 Thread leonardo . bianconi
Leonardo Bianconi has uploaded a new change for review. Change subject: core: Change NIC type from sPAPR VLAN to any other .. core: Change NIC type from sPAPR VLAN to any other After created the VM, added a network interface and

[Engine-patches] Change in ovirt-reports[master]: packaging: setup: _commands -> _setup

2014-02-03 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: _commands -> _setup .. Patch Set 1: Code-Review+1 thanks! -- To view, visit http://gerrit.ovirt.org/24005 To unsubscribe, visit http://gerrit.

  1   2   3   4   >