Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. ......................................................................
Patch Set 1: (2 comments) well, I still do not see my code. I do not understand... why you insist to abstract everything without any need? http://gerrit.ovirt.org/#/c/24018/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventFilter.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventFilter.java: Line 1: package org.ovirt.engine.core.common.businessentities; Line 2: Line 3: public class EventFilter { this class is not needed Line 4: Line 5: private boolean include; Line 6: Line 7: private String eventName; http://gerrit.ovirt.org/#/c/24018/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 45: * Filter Line 46: */ Line 47: public static final String FILTER = "FILTER"; Line 48: public static final Pattern FILTER_ELEMENT_PATTERN = Pattern.compile( Line 49: "(?<include>include|exclude):(?<event>\\*|\\w+)(\\((?<method>snmp|smtp):((?<recipient>[^)]+))?\\))?"); why do you care if it is something other, just warn when event is dispatched that transport is not registered. Line 50: Line 51: /** Line 52: * Email parameters Line 53: */ -- To view, visit http://gerrit.ovirt.org/24018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
