Greg Sheremeta has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/21052/13/build/helptag_checker.py File build/helptag_checker.py: Line 61: filename = os.path.join(parent, fname) Line 62: if filename.endswith('.java') and os.path.isfile(filename): Line 63: with open(filename, 'r') as f: Line 64: lines = f.readlines() Line 65: yield (lines, fname) > I believe the yield should be outside of with scope to close the file, but fixed, thanks. Line 66: Line 67: Line 68: def findVariableHashNames(sourcedir): Line 69: for (lines, fname) in walkSource(sourcedir): -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
