Alon Bar-Lev has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/21052/12/build/helptag_checker.py File build/helptag_checker.py: Line 42: \s* Line 43: \)\s*; Line 44: .* Line 45: """ Line 46: ) > The expressions are slightly different. I think it's easier to understand a ok... I think that while you work using templates, you would like to find the pattern that covers your actual needs, in this case I do not think the ';' is enough to differentiate... but that's the farthest I can stretch you :))) that's ok, I think that you now have some of the power of python... to take back into Java. Line 47: Line 48: __RE_QUOTED_STRING = re.compile( Line 49: flags=re.VERBOSE, Line 50: pattern=r'"[^"]*"' -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
