Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Overwrite iso nfs export only if new ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23975/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py: Line 110: self.environment[ Line 111: osetupcons.ConfigEnv.ISO_DOMAIN_NFS_MOUNT_POINT Line 112: ], Line 113: ) Line 114: ) I understand why you want to cache information, but we really just need the fact that we are going to move the line. but why do that in validation? if we do this in misc, we can have one stage that: @always checks() { 1. determine source file 2. determine destination file 3. should we move (exports -> exports.d move) 4. should we generate (acl != null) } @if generate re-write() { put in destination } @if move move() { read old line remove from source if not generate: put old in destination } maybe this what you have done... I just want code to be constructed like the above, unless I am missing something. Line 115: Line 116: @plugin.event( Line 117: stage=plugin.Stages.STAGE_MISC, Line 118: condition=lambda self: ( -- To view, visit http://gerrit.ovirt.org/23975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12c50b30c5df9f0da446ddbbf54c7ca73b7dd3d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
