Shubhendu Tripathi has uploaded a new change for review.
Change subject: gluster: VDS Cmd: gluster remove bricks status
..
gluster: VDS Cmd: gluster remove bricks status
VDS Command for remove bricks status
Change-Id: I21da52b0
Allon Mureinik has posted comments on this change.
Change subject: core: rename methods to start with lowercase
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19098
To unsubscribe, visit http://gerrit.
Gilad Chaplik has posted comments on this change.
Change subject: core: ExternalSchedulerDiscoveryResult map iter
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18997
To unsubscribe, visit http://gerri
Daniel Erez has posted comments on this change.
Change subject: webadmin: new VM guide dialog does not get updated
..
Patch Set 1:
NewGuideVmInterfaceModel seems to be deprecated (it's never used..). Has the
issue been resolve
Daniel Erez has posted comments on this change.
Change subject: frontend: MaxVmNameLength(Non)Windows ignored
..
Patch Set 2: Code-Review+2
(2 comments)
Looks good. Please fix typos.
..
Daniel Erez has posted comments on this change.
Change subject: webadmin: unescape cell tooltips string values
..
Patch Set 2:
btw, looking forward, we can adopt the concept of HTML based tool-tips instead;
i.e. something simi
Mike Kolesnik has posted comments on this change.
Change subject: engine: Network interface name is mandatory
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19056
To unsubscribe, visit http://gerrit.ov
Daniel Erez has uploaded a new change for review.
Change subject: core: move unplugged disks while VM is running
..
core: move unplugged disks while VM is running
Refactor/rewrite of MoveDisksCommand to support the following:
*
Allon Mureinik has posted comments on this change.
Change subject: core: fix not closing statement resource leak
..
Patch Set 1: Code-Review+2
@Alissa - please verify so this can be merged.
--
To view, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: core: LocalAdminPassword exception after engine restart
..
Patch Set 3:
(1 comment)
File
backend/manager/
Daniel Erez has posted comments on this change.
Change subject: webadmin: unescape cell tooltips string values
..
Patch Set 2: Verified+1
Since the fix from Patch-set-1 still didn't eliminate the
escacped characters issue, I Ih
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Add AddTabActionButton to
exclude-filters.xml
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19000
To unsubscribe,
mooli tayer has posted comments on this change.
Change subject: engine: application touches a file to detect un orderly shutdown
..
Patch Set 2:
1.) Regarding the pid file I'm not sure I understand what you mean. are you
talki
Sergey Gotliv has posted comments on this change.
Change subject: core: Avoid marking imported images as illegal when removing a
guest from an import domain.
..
Patch Set 5: Code-Review+1
(1 comment)
.
Yair Zaslavsky has posted comments on this change.
Change subject: engine : VdsUpdateRuntimeInfo updates the data of a specific
VDS.
..
Patch Set 21:
(1 comment)
File
back
Allon Mureinik has submitted this change and it was merged.
Change subject: backend: don't cache isoPrefix when empty
..
backend: don't cache isoPrefix when empty
In rare occasions (e.g. when an iso domain was unreachable at
co
Allon Mureinik has posted comments on this change.
Change subject: backend: don't cache isoPrefix when empty
..
Patch Set 2: Verified+1 Code-Review+2
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/18934
T
Vojtech Szocs has posted comments on this change.
Change subject: engine: Add branded link to console resources
..
Patch Set 7:
(3 comments)
File
frontend/webadmin/modules/
Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: i18n remove user role dialog
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18936
To unsubscribe, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: core: Avoid marking imported images as illegal when removing a
guest from an import domain.
..
Patch Set 4: Code-Review+1
(3 comments)
Basically +1, please se
mooli tayer has posted comments on this change.
Change subject: engine: application touches a file to detect un orderly shutdown
..
Patch Set 1:
(1 comment)
File pom.xml
Lin
Allon Mureinik has posted comments on this change.
Change subject: core, webadmin: allow edit unattached storage conn
..
Patch Set 2: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/190
Allon Mureinik has submitted this change and it was merged.
Change subject: core, webadmin: allow edit unattached storage conn
..
core, webadmin: allow edit unattached storage conn
Allow editing (updating) the path (connection)
Allon Mureinik has posted comments on this change.
Change subject: webadmin: remove unused UriValidator class
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19096
To unsubscribe, visit http://gerrit.ov
Omer Frenkel has posted comments on this change.
Change subject: engine: nullify EmulatedMachine field only on cluster level
change
..
Patch Set 4:
(2 comments)
what about fixtures.xml for new field dao tests?
..
Vojtech Szocs has posted comments on this change.
Change subject: frontend: Adding FQDN column to VmViews
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17865
To unsubscribe, visit http://gerrit.ovirt.
Vojtech Szocs has posted comments on this change.
Change subject: Use FQDN from guest agent for RDP
..
Patch Set 13: Code-Review+1
+1 for the frontend part.
--
To view, visit http://gerrit.ovirt.org/17709
To unsubscribe, visi
Shubhendu Tripathi has uploaded a new change for review.
Change subject: gluster: BLL Cmd: commit remove bricks async task
..
gluster: BLL Cmd: commit remove bricks async task
BLL command for commiting the remove brick asynchron
Allon Mureinik has posted comments on this change.
Change subject: core: rename method Perform to start with lowercase
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19101
To unsubscribe, visit http://
Tal Nisan has posted comments on this change.
Change subject: core: rename executeVdsBrokerCommand to start with lowercase
..
Patch Set 3:
Yes, verifying first
--
To view, visit http://gerrit.ovirt.org/18970
To unsubscribe, v
Allon Mureinik has posted comments on this change.
Change subject: core: rename methods to start with lowercase
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19098
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: core: rename executeVdsBrokerCommand to start with lowercase
..
Patch Set 3: Code-Review+2
@Tal - are you merging this?
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: call connectStorageServer when add a domain
..
Patch Set 2: Verified+1 Code-Review+2
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org
Allon Mureinik has submitted this change and it was merged.
Change subject: core: call connectStorageServer when add a domain
..
core: call connectStorageServer when add a domain
If a storage domain is created with an already e
Tal Nisan has posted comments on this change.
Change subject: core: rename method Perform to start with lowercase
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19101
To unsubscribe, visit http://gerri
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal,webadmin: i18n remove user role dialog
..
userportal,webadmin: i18n remove user role dialog
- Fixed user role removal dialog not being i18ned
Allon Mureinik has posted comments on this change.
Change subject: restapi: add storage domain with existing conn id
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19027
To unsubscribe, visit http://ge
Allon Mureinik has posted comments on this change.
Change subject: core: call connectStorageServer when add a domain
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19028
To unsubscribe, visit http://ge
mooli tayer has uploaded a new change for review.
Change subject: engine: application touches a file to detect un orderly shutdown
..
engine: application touches a file to detect un orderly shutdown
Used to diagnose unexpected e
Allon Mureinik has posted comments on this change.
Change subject: restapi: add connections subresource for domain
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19045
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: core: ExternalSchedulerDiscoveryResult map iter
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18997
To unsubscribe, visit http://gerrit.
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Added sorting of hosts by SPM priority upon activating
..
webadmin: Added sorting of hosts by SPM priority upon activating
When sending a multiple
Omer Frenkel has posted comments on this change.
Change subject: core: rename methods to start with lowercase
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19098
To unsubscribe, visit http://gerrit.ov
Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: i18n remove user role dialog
..
Patch Set 3: Verified+1 Code-Review+2
Merging based on previous acks.
--
To view, visit http://gerrit.ovir
Tal Nisan has posted comments on this change.
Change subject: webadmin: Added sorting of hosts by SPM priority upon activating
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19092
To unsubsc
Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: i18n remove user role dialog
..
Patch Set 3:
Rebased (no changes since last time).
--
To view, visit http://gerrit.ovirt.org/18936
To unsu
Daniel Erez has posted comments on this change.
Change subject: webadmin: Added sorting of hosts by SPM priority upon activating
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19092
To unsubscribe, vis
Omer Frenkel has posted comments on this change.
Change subject: core: rename executeVdsBrokerCommand to start with lowercase
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18970
To unsubscribe, visit
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Partial revert of
20d4297bf8d85505f9ed9b4aabcce13a6e5e1f90
..
engine: Partial revert of 20d4297bf8d85505f9ed9b4aabcce13a6e5e1f90
Reverted part
Allon Mureinik has posted comments on this change.
Change subject: engine: Partial revert of
20d4297bf8d85505f9ed9b4aabcce13a6e5e1f90
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19097
To
Allon Mureinik has uploaded a new change for review.
Change subject: engine: Partial revert of
20d4297bf8d85505f9ed9b4aabcce13a6e5e1f90
..
engine: Partial revert of 20d4297bf8d85505f9ed9b4aabcce13a6e5e1f90
Reverted part of 20d4
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Add AddTabActionButton to
exclude-filters.xml
..
Patch Set 1:
(1 comment)
File fronte
Allon Mureinik has posted comments on this change.
Change subject: core: Consolidate duplicate exception handling
..
Patch Set 4: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18871
T
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Consolidate duplicate exception handling
..
core: Consolidate duplicate exception handling
This patch removes duplicate blocks of exception handl
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove ReflectionUtils.getSizeAnnotation
..
core: Remove ReflectionUtils.getSizeAnnotation
This method is not used anywhere in the codebase, and
Allon Mureinik has posted comments on this change.
Change subject: core: VdcActionUtils: declare variables as Maps
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18851
Allon Mureinik has posted comments on this change.
Change subject: core: Remove ReflectionUtils.getSizeAnnotation
..
Patch Set 2: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18996
T
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Show only supported displays
..
Patch Set 3:
(1 comment)
I think the logic to select the proper display protocol is missing from the
NewPoolModelBeha
Allon Mureinik has posted comments on this change.
Change subject: engine: VdcActionUtils: method names
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18853
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: VdcActionUtils: apply code formatter
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18848
To un
Allon Mureinik has posted comments on this change.
Change subject: core: VdcActionUtils: Replace FQCNs with imports
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18849
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdsDynamic: [get|set]status->[get|set]Status
..
core: VdsDynamic: [get|set]status->[get|set]Status
Renamed getstatus() and setstatus(VdsStatus) t
Allon Mureinik has submitted this change and it was merged.
Change subject: core: simpler syntax for snapshotEntityStatus
..
core: simpler syntax for snapshotEntityStatus
Added the
CompensationContext#snapshotEntityStatus(Busin
Allon Mureinik has posted comments on this change.
Change subject: engine: StoragePool.getStatus/setStatus
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, resovled conflicts.
--
To view, visit http://gerrit.ovirt.org/18846
Allon Mureinik has posted comments on this change.
Change subject: core: Introducing VdcActionUtilsTest
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18847
To unsubscr
Omer Frenkel has posted comments on this change.
Change subject: gluster: VDS Cmd: Gluster Volume Rebalance Stop
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18442
To unsubscribe, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: core: VdsDynamic: [get|set]status->[get|set]Status
..
Patch Set 4: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/188
Allon Mureinik has posted comments on this change.
Change subject: core: VdcActionUtils: Use EnumSets
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18850
To unsubscrib
Allon Mureinik has posted comments on this change.
Change subject: engine: VdcActionUtils: Remove reflection
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18855
To uns
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StoragePoolIsoMap: rename status methods
..
core: StoragePoolIsoMap: rename status methods
Ranamed getstatus() and setstatus(StorageDomainStatus)
Allon Mureinik has posted comments on this change.
Change subject: core: VdcActionUtils: Unwrap else blocks
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18852
To unsu
Allon Mureinik has posted comments on this change.
Change subject: core: VdcActionUtils: Remove null check
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18854
To unsub
Allon Mureinik has posted comments on this change.
Change subject: core: StoragePoolIsoMap: rename status methods
..
Patch Set 4: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18857
T
Allon Mureinik has posted comments on this change.
Change subject: core: Apply BusinessEntityWithStatus
..
Patch Set 4: Verified+1 Code-Review+2
Rebased, resolved conflicts.
--
To view, visit http://gerrit.ovirt.org/18858
To
Roy Golan has posted comments on this change.
Change subject: core: share a tranlation table of osinfo with DWH
..
Patch Set 9:
ydary please review the last changes
--
To view, visit http://gerrit.ovirt.org/17767
To unsubscri
Allon Mureinik has posted comments on this change.
Change subject: core: simpler syntax for snapshotEntityStatus
..
Patch Set 5: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18859
To
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdcActionUtils: Remove null check
..
core: VdcActionUtils: Remove null check
Removed a redundant null check from VdcActionUtils.getStatusProperty
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdcActionUtils: apply code formatter
..
core: VdcActionUtils: apply code formatter
Applied the project's code formatter in order to facilitate ea
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: StoragePool.getStatus/setStatus
..
engine: StoragePool.getStatus/setStatus
Renamed StoragePool's getstatus() and setstatus(StoragePoolStatus) t
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdcActionUtils: Use EnumSets
..
core: VdcActionUtils: Use EnumSets
Since all the objects handled by the Sets in this class are Enums, the
usage o
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdcActionUtils: declare variables as Maps
..
core: VdcActionUtils: declare variables as Maps
Declared variables as Maps instead of HashMaps, as p
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Apply BusinessEntityWithStatus
..
core: Apply BusinessEntityWithStatus
Applied the newly introduced BusinessEntityWithStatus to all the
relevant
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdcActionUtils: Replace FQCNs with imports
..
core: VdcActionUtils: Replace FQCNs with imports
Imported relevant classes to make the code more re
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdcActionUtils: Unwrap else blocks
..
core: VdcActionUtils: Unwrap else blocks
Unwrapped redundant else blocks in order to make the class more
re
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Introducing VdcActionUtilsTest
..
core: Introducing VdcActionUtilsTest
Introducing a new test suite for VdcActionUtils before refactoring.
Chang
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: VdcActionUtils: method names
..
engine: VdcActionUtils: method names
Rename methods to start with lower case letters, as per proper Java
conven
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: VdcActionUtils: Remove reflection
..
engine: VdcActionUtils: Remove reflection
Improved VdcActionUtils performance and readability by removing
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Added sorting of hosts by SPM priority upon activating
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19092
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: engine: Network interface name is mandatory
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19056
To unsubscribe, visit http://gerrit.ovirt.o
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Added sorting of hosts by SPM priority upon activating
..
webadmin: Added sorting of hosts by SPM priority upon activating
When sending a multiple activat
Allon Mureinik has posted comments on this change.
Change subject: engine: StoragePool.getStatus/setStatus
..
Patch Set 2:
(1 comment)
File
backend/manager/modules/bll/src/
Itamar Heim has posted comments on this change.
Change subject: packaging: spec: use system jars
..
Patch Set 1:
why is the postgres one too low in .el6?
--
To view, visit http://gerrit.ovirt.org/19060
To unsubscribe, visit h
Moti Asayag has uploaded a new change for review.
Change subject: engine: Network interface name is mandatory
..
engine: Network interface name is mandatory
The network interface name is used to identify the nic,
therefore it ca
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fix synchornization issue in
handleEndActionRuntimeException
..
core: Fix synchornization issue in handleEndActionRuntimeException
This issue was discov
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Don't allow to boot from unplugged NIC
..
webadmin: Don't allow to boot from unplugged NIC
PXE boot used to be available for VMs whose VNICs wer
Moti Asayag has posted comments on this change.
Change subject: webadmin: Don't allow to boot from unplugged NIC
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19041
To unsubscribe, visit ht
Tomas Jelinek has posted comments on this change.
Change subject: engine: Set single qxl display only in Linux OS
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19048
To unsubscribe, visit http://gerri
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Replaced String check with string conversion
..
Replaced String check with string conversion
Currently the string_check is destroying the data when the syste
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Adding Unit Tests and Functional Tests
..
Adding Unit Tests and Functional Tests
The functional tests so far are testing the retrieval
of data from the under
Tal Nisan has posted comments on this change.
Change subject: core: Introducing VdcActionUtilsTest
..
Patch Set 2: Code-Review+2
Nicely done!!!
--
To view, visit http://gerrit.ovirt.org/18847
To unsubscribe, visit http://gerr
1 - 100 of 138 matches
Mail list logo
