Yair Zaslavsky has posted comments on this change. Change subject: core: LocalAdminPassword exception after engine restart ......................................................................
Patch Set 3: (1 comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java Line 218: @Override Line 219: public <T> T getValue(ConfigValues name, String version) { Line 220: T returnValue; Line 221: Map<String, Object> values = null; Line 222: if ((values = _vdcOptionCache.get(name.toString())) != null && (values.containsKey(version) || values.containsKey("general"))) { Can you please elaborate in the commit msg why this solves the issue? Line 223: returnValue = (T) values.get(version); Line 224: } else { Line 225: VdcOption option = new VdcOption(); Line 226: option.setoption_name(name.toString()); -- To view, visit http://gerrit.ovirt.org/18065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I000bbb3cf5a6d1d636c49247e85858b02b2f358a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches