Daniel Erez has posted comments on this change.
Change subject: frontend: MaxVmNameLength(Non)Windows ignored
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Looks good. Please fix typos.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 3266: new IdQueryParameters(providerId),
Line 3267: aQuery);
Line 3268: }
Line 3269:
Line 3270: public static Integer getMaxVmNameLenghtWin() {
s/Lenght/Length
Line 3271: Integer maxVmNameLengthWindows = (Integer)
AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MaxVmNameLengthWindows);
Line 3272: return maxVmNameLengthWindows == null ? 15 :
maxVmNameLengthWindows;
Line 3273: }
Line 3274:
Line 3271: Integer maxVmNameLengthWindows = (Integer)
AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MaxVmNameLengthWindows);
Line 3272: return maxVmNameLengthWindows == null ? 15 :
maxVmNameLengthWindows;
Line 3273: }
Line 3274:
Line 3275: public static Integer getMaxVmNameLenghtNonWin() {
s/Lenght/Length
Line 3276: Integer maxVmNameLengthNonWindows = (Integer)
AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MaxVmNameLengthNonWindows);
Line 3277: return maxVmNameLengthNonWindows == null ? 64 :
maxVmNameLengthNonWindows;
Line 3278: }
--
To view, visit http://gerrit.ovirt.org/18989
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a1ac29aadc731f6fe4a0e62db7e78a5160ededa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
