Moti Asayag has uploaded a new change for review. Change subject: engine: Network interface name is mandatory ......................................................................
engine: Network interface name is mandatory The network interface name is used to identify the nic, therefore it cannot be omitted. The patch adds a NotNull constraint for the interface name. Change-Id: I26f33bf12e9b53c3e31719b93a689e11e974acca Bug-Url: https://bugzilla.redhat.com/979751 Signed-off-by: Moti Asayag <masa...@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/19056/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java index c6c7c0d..f74cccc 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java @@ -28,6 +28,7 @@ VdsNetworkInterface nic = new VdsNetworkInterface(); params.setInterfaces(Arrays.asList(nic)); + nic.setName("nic"); nic.setNetworkName("otherThenMgmtNetwork"); nic.setGateway("1.1.1.1"); diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java index 66b47ab..4c75a56 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java @@ -2,6 +2,7 @@ import java.io.Serializable; +import javax.validation.constraints.NotNull; import javax.validation.constraints.Pattern; import javax.validation.constraints.Size; @@ -49,6 +50,7 @@ @Override @Size(min = 1, max = BusinessEntitiesDefinitions.HOST_NIC_NAME_LENGTH) + @NotNull(message = "VALIDATION_NAME_NULL") public String getName() { return super.getName(); } -- To view, visit http://gerrit.ovirt.org/19056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I26f33bf12e9b53c3e31719b93a689e11e974acca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
