Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fix synchornization issue in
handleEndActionRuntimeException
......................................................................
core: Fix synchornization issue in handleEndActionRuntimeException
This issue was discovered by coverity -
Removing an element from _multiTasksByCommandIds should be protected
by the _lockObject
Change-Id: Iaa324313a7f4f9036a8219e93d8f4c5c0f9d3355
Signed-off-by: Yair Zaslavsky <yzasl...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/19054/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
index 6b1a5b3..76a61f9 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
@@ -198,7 +198,9 @@
log.infoFormat(
"CommandAsyncTask::HandleEndActionRuntimeException:
Removing CommandMultiAsyncTasks object for entity '{0}'",
commandInfo.getCommandId());
- _multiTasksByCommandIds.remove(commandInfo.getCommandId());
+ synchronized (_lockObject) {
+ _multiTasksByCommandIds.remove(commandInfo.getCommandId());
+ }
}
}
--
To view, visit http://gerrit.ovirt.org/19054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa324313a7f4f9036a8219e93d8f4c5c0f9d3355
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
