[Engine-patches] Change in ovirt-engine[master]: engine: User who has manipulate_permissions can't see other ...

2013-06-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: User who has manipulate_permissions can't see other users .. Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) Minor com

[Engine-patches] Change in ovirt-engine[master]: gluster: VDS comand for start/stop of services

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: VDS comand for start/stop of services .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/533/ : SUC

[Engine-patches] Change in ovirt-log-collector[master]: config: avoid to change existing configuration files

2013-06-04 Thread knesenko
Kiril Nesenko has posted comments on this change. Change subject: config: avoid to change existing configuration files .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: unify new server/desktop to newVm

2013-06-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: unify new server/desktop to newVm .. Patch Set 6: Looks good to me, approved (1 inline comment) one last comment.. .

[Engine-patches] Change in ovirt-engine[master]: engine: updating GlusterService entities and enum

2013-06-04 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: engine: updating GlusterService entities and enum .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/15360 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-log-collector[master]: config: avoid to change existing configuration files

2013-06-04 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: config: avoid to change existing configuration files .. config: avoid to change existing configuration files When reading configurarion files, just warn the

[Engine-patches] Change in ovirt-log-collector[master]: config: avoid to change existing configuration files

2013-06-04 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: config: avoid to change existing configuration files .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15366 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: restapi: adding custom properties to vm interface

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: adding custom properties to vm interface .. Patch Set 11: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/530/

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmDevice

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Adds custom properties to VmDevice .. Patch Set 14: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/529/ : FAILUR

[Engine-patches] Change in ovirt-engine[master]: restapi: Cannot remove custom properties from a vm

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Cannot remove custom properties from a vm .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/531

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmNetworkInterface

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Adds custom properties to VmNetworkInterface .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/528/

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding custom properties to vnic dialog

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: adding custom properties to vnic dialog .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/527/ :

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmDevice

2013-06-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adds custom properties to VmDevice .. Patch Set 14: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14814 To uns

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmNetworkInterface

2013-06-04 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Adds custom properties to VmNetworkInterface .. Patch Set 18: (1 inline comment) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmDevice

2013-06-04 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Adds custom properties to VmDevice .. Patch Set 13: (2 inline comments) File backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: core: Custom properties error handling cleanup

2013-06-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Custom properties error handling cleanup .. Patch Set 1: (2 inline comments) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmDevice

2013-06-04 Thread mperina
Martin Peřina has abandoned this change. Change subject: core: Adds custom properties to VmDevice .. Patch Set 1: Abandoned Pushed by mistake -- To view, visit http://gerrit.ovirt.org/15365 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: tools: Add script to dump heap

2013-06-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Add script to dump heap .. Patch Set 1: (1 inline comment) File packaging/bin/engine-heap-dump.sh Li

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: support older psycopg2

2013-06-04 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: support older psycopg2 .. Patch Set 1: (1 inline comment) File packaging/setup/ovirt_en

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: some params on make template ignored

2013-06-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: some params on make template ignored .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: gluster: Bll command to refresh gluster hooks in engine

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Bll command to refresh gluster hooks in engine .. Patch Set 1: No score Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs

[Engine-patches] Change in ovirt-engine[master]: restapi: Cannot remove custom properties from a vm

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Cannot remove custom properties from a vm .. Patch Set 7: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/526

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmNetworkInterface

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Adds custom properties to VmNetworkInterface .. Patch Set 19: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/524

[Engine-patches] Change in ovirt-engine[master]: core: Changes type of VmDevice from String to enum

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Changes type of VmDevice from String to enum .. Patch Set 9: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/523/

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding custom properties to vnic dialog

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: adding custom properties to vnic dialog .. Patch Set 15: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/522/

[Engine-patches] Change in ovirt-engine[master]: core: Custom properties error handling cleanup

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Custom properties error handling cleanup .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/520/ : F

[Engine-patches] Change in ovirt-engine[master]: restapi: adding custom properties to vm interface

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: adding custom properties to vm interface .. Patch Set 10: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/525/

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmDevice

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Adds custom properties to VmDevice .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/521/ : FAILURE

[Engine-patches] Change in ovirt-engine[master]: engine: updating GlusterService entities and enum

2013-06-04 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine: updating GlusterService entities and enum .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15360 T

[Engine-patches] Change in ovirt-engine[master]: gluster: Host detach case sync message corrected

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Host detach case sync message corrected .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/513/ : S

[Engine-patches] Change in ovirt-engine[master]: core: remove memory image on remove snapshot

2013-06-04 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: remove memory image on remove snapshot .. Patch Set 16: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14687 To

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected the event log message

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Corrected the event log message .. Patch Set 6: No score Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/512/ :

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo

2013-06-04 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: Fix typo .. Patch Set 1: Looks good to me, but someone else must approve I'd add in what method in the commit message. -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: gluster: VDS comand for start/stop of services

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: VDS comand for start/stop of services .. Patch Set 6: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected the event log message

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Corrected the event log message .. Patch Set 6: No score; I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org

[Engine-patches] Change in jenkins[master]: jenkins: adding manainnace script for nightly builds

2013-06-04 Thread ewoud
Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: jenkins: adding manainnace script for nightly builds .. Patch Set 1: I would prefer that you didn't submit this (7 inline comments) ...

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - restapi support

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: watchdog - restapi support .. Patch Set 30: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/504/ : SUCCESS -- To

[Engine-patches] Change in ovirt-engine[master]: engine: rest cleanup [wip]

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: rest cleanup [wip] .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/503/ : SUCCESS -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: engine: rest cleanup [wip]

2013-06-04 Thread lhornyak
Laszlo Hornyak has uploaded a new change for review. Change subject: engine: rest cleanup [wip] .. engine: rest cleanup [wip] The second put with the CdRom.class key was overriding the previous one. Testing needed. Change-Id: I

[Engine-patches] Change in ovirt-engine[master]: webadmin: host gluster-swift sub tab

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: host gluster-swift sub tab .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/502/ : SUCCESS -- T

[Engine-patches] Change in ovirt-engine[master]: core: save memory state on live snapshot with memory

2013-06-04 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: save memory state on live snapshot with memory .. Patch Set 17: (4 inline comments) partial responds, I'll respond to the rest of the comments later

[Engine-patches] Change in ovirt-engine[master]: engine: updating GlusterService entities and enum

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: updating GlusterService entities and enum .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/500/

[Engine-patches] Change in ovirt-engine[master]: gluster: Added queries for service list

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added queries for service list .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/498/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: engine: refactored GlusterServiceStatus enum

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: refactored GlusterServiceStatus enum .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/497/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: webadmin: [WIP] host gluster-swift sub tab

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: [WIP] host gluster-swift sub tab .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/496/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: engine: User who has manipulate_permissions can't see other ...

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: User who has manipulate_permissions can't see other users .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bu

[Engine-patches] Change in ovirt-engine[master]: engine: refactored GlusterServiceStatus enum

2013-06-04 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: engine: refactored GlusterServiceStatus enum .. engine: refactored GlusterServiceStatus enum -Removed the FAILED status as vdsm won't return this. -Changed NOT_IN

[Engine-patches] Change in ovirt-engine[master]: engine: User who has manipulate_permissions can't see other ...

2013-06-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine: User who has manipulate_permissions can't see other users .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/14346 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Fix CommonModel search string regressio...

2013-06-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin,userportal: Fix CommonModel search string regression .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15086 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: engine: add comment field to DataCenter

2013-06-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: engine: add comment field to DataCenter .. Patch Set 5: (4 inline comments) I think it's preferable to merge along with the other business entities (i.e. only whe

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix typo .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/494/ : SUCCESS -- To view, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Introducing Batch updates to DAOs

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Introducing Batch updates to DAOs .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/493/ : SUCCESS -

[Engine-patches] Change in ovirt-engine[master]: core: save memory state on live snapshot with memory

2013-06-04 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: save memory state on live snapshot with memory .. Patch Set 17: (5 inline comments) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: WIP Support foreman SSL provider

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP Support foreman SSL provider .. Patch Set 4: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/ovirt_engine_

[Engine-patches] Change in ovirt-engine[master]: tools: Add script to dump heap

2013-06-04 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: tools: Add script to dump heap .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15359 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: extract general code from HibernateVmCommand

2013-06-04 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: extract general code from HibernateVmCommand .. Patch Set 13: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1429

[Engine-patches] Change in ovirt-engine[master]: tools: Add script to dump heap

2013-06-04 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: tools: Add script to dump heap .. tools: Add script to dump heap This change adds the engine-heap-dump.sh script that generates an histogram of the use of memo

[Engine-patches] Change in ovirt-engine[master]: gluster: Added queries for service list

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added queries for service list .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/485/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: add memory snapshots capability to VdsBroker

2013-06-04 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: add memory snapshots capability to VdsBroker .. Patch Set 14: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14201 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: save memory state on live snapshot with memory

2013-06-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: save memory state on live snapshot with memory .. Patch Set 17: (6 inline comments) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: core: add memory volume to snapshot entity

2013-06-04 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: add memory volume to snapshot entity .. Patch Set 17: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14053 To uns

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo

2013-06-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Fix typo .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15357 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: core: add memory snapshot feature support

2013-06-04 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: add memory snapshot feature support .. Patch Set 16: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14167 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: getAllTasksList\Status with spUUID retrieves info only if ho...

2013-06-04 Thread ybronhei
Yaniv Bronhaim has abandoned this change. Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM .. Patch Set 12: Abandoned due to http://gerrit.ovirt.org/#/c/15345/ - this change does not re

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 4458 - Fixed!

2013-06-04 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4458/ Build Number: 4458 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo

2013-06-04 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: Fix typo .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15357 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: extract general code from HibernateVmCommand

2013-06-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: extract general code from HibernateVmCommand .. Patch Set 13: (2 inline comments) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: support older psycopg2

2013-06-04 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: support older psycopg2 .. packaging: setup: support older psycopg2 rhel and centos have version 2.0.14 with autocommit unsupported. Change-Id:

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: support older psycopg2

2013-06-04 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: support older psycopg2 .. Patch Set 1: Alex, can you please check if there are more issues? Thanks! -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: add get*Type to template DAO

2013-06-04 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: add get*Type to template DAO .. Patch Set 10: (1 inline comment) File backend/manager/modules/dal/src/ma

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo

2013-06-04 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: Fix typo .. core: Fix typo change Compatilibily to Compatibility Change-Id: I4a1e956d453d35b4cd5968df6ef5e6de7de975d2 Signed-off-by: Maor Lipchuk --- M

[Engine-patches] Change in ovirt-engine[master]: add Image and Instance type interfaces

2013-06-04 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: add Image and Instance type interfaces .. Patch Set 11: Looks good to me, but someone else must approve (2 inline comments) two minor comments ...

[Engine-patches] Change in ovirt-engine[master]: webadmin: Hide checkbox in reinit dc with no SDs

2013-06-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Hide checkbox in reinit dc with no SDs .. Patch Set 1: (1 inline comment) File frontend/webadmin/mo

[Engine-patches] Change in ovirt-engine[master]: webadmin: Hide V Format field in storage domain

2013-06-04 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: webadmin: Hide V Format field in storage domain .. Patch Set 1: Fails following Daniel's comment, it's problematic to hide the format field for the following rea

[Engine-patches] Change in ovirt-engine[master]: core: restore memory from snapshot on run vm

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: restore memory from snapshot on run vm .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/484/ : SUCC

[Engine-patches] Change in ovirt-engine[master]: core: add memory volume to snapshot entity

2013-06-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: add memory volume to snapshot entity .. Patch Set 17: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14053 To uns

[Engine-patches] Change in ovirt-engine[master]: core: add memory volume to snapshot entity

2013-06-04 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: add memory volume to snapshot entity .. Patch Set 17: (2 inline comments) File backend/manager/dbscripts

[Engine-patches] Change in ovirt-engine[master]: webadmin: add memory column to snapshot subtab

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add memory column to snapshot subtab .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/482/ : SU

[Engine-patches] Change in ovirt-engine[master]: core: remove memory image on remove snapshot

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: remove memory image on remove snapshot .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/483/ : SUCC

[Engine-patches] Change in ovirt-engine[master]: core: restore memory from snapshot on run vm

2013-06-04 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: restore memory from snapshot on run vm .. Patch Set 14: (2 inline comments) File backend/manager/modules

[Engine-patches] Change in ovirt-engine[master]: webadmin: Hide V Format field in storage domain

2013-06-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Hide V Format field in storage domain .. Patch Set 1: The format is relevant for new domain. The DC format is specified in the dropdown list only after

[Engine-patches] Change in ovirt-engine[master]: core: add memory volume to snapshot entity

2013-06-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: add memory volume to snapshot entity .. Patch Set 17: (2 inline comments) File backend/manager/dbscrip

[Engine-patches] Change in ovirt-engine[master]: core: memory state handling on preview/commit/undo

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: memory state handling on preview/commit/undo .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/481/

[Engine-patches] Change in ovirt-engine[master]: core: [WIP] handling memory snapshots on export/import vm

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: [WIP] handling memory snapshots on export/import vm .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerri

[Engine-patches] Change in ovirt-engine[master]: WIP Support foreman SSL provider

2013-06-04 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: WIP Support foreman SSL provider .. Patch Set 3: (7 inline comments) File backend/manager/modules/bll/src/ma

[Engine-patches] Change in ovirt-engine[master]: core: Introducing Batch updates to DAOs

2013-06-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Introducing Batch updates to DAOs .. Patch Set 9: Allon, Kolesnik - please review, Liran cleaned up the noise. -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: add memory snapshot feature support

2013-06-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: add memory snapshot feature support .. Patch Set 16: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14167 To unsu

[Engine-patches] Change in ovirt-engine[master]: restapi: support for creating snapshot with memory

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: support for creating snapshot with memory .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/479/

[Engine-patches] Change in ovirt-engine[master]: restapi: add memory attribute to snapshot

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: add memory attribute to snapshot .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/478/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: add memory snapshot feature support

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add memory snapshot feature support .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/477/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: restore memory from snapshot on run vm

2013-06-04 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: restore memory from snapshot on run vm .. Patch Set 15: Please address my comments from last patch -- To view, visit http://gerrit.ovirt.org/14860 To unsub

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 4457 - Failure!

2013-06-04 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4457/ Build Number: 4457 Build Status: Failure Triggered By: Started by an SCM change, Started by an SCM change - Changes Since Last Succes

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms_quick - Build # 30 - Still Failing!

2013-06-04 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/30/ Build Number: 30 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: webadmin: add memory option to create snapshot popup

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add memory option to create snapshot popup .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/474

[Engine-patches] Change in ovirt-log-collector[master]: core: modify copyright of base po

2013-06-04 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: core: modify copyright of base po .. Patch Set 1: (1 inline comment) File po/Makevars Line 17: # expected

[Engine-patches] Change in ovirt-engine[master]: core: cleanup CreateVmVDSCommand

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cleanup CreateVmVDSCommand .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/476/ : SUCCESS -- To v

[Engine-patches] Change in ovirt-engine[master]: core: remove memory from active snapshot

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: remove memory from active snapshot .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/475/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: engine-config: Adding man page

2013-06-04 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: engine-config: Adding man page .. engine-config: Adding man page Adding engine-config.8 Change-Id: I546d90550ddf53707bc667c18e8c0d44e909593f Bug-Url:

[Engine-patches] Change in ovirt-engine[master]: engine-config: Adding man page

2013-06-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine-config: Adding man page .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11176 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: WIP Support foreman SSL provider

2013-06-04 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: WIP Support foreman SSL provider .. Patch Set 4: Changes in latest patch-sets: 1. Added BaseProviderProxy to handle getting the certificate chain. 2. Addressing s

  1   2   3   >