Yair Zaslavsky has posted comments on this change.
Change subject: engine: User who has manipulate_permissions can't see other
users
..
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
Minor com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: VDS comand for start/stop of services
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/533/ : SUC
Kiril Nesenko has posted comments on this change.
Change subject: config: avoid to change existing configuration files
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15
Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: unify new server/desktop to newVm
..
Patch Set 6: Looks good to me, approved
(1 inline comment)
one last comment..
.
Kanagaraj M has posted comments on this change.
Change subject: engine: updating GlusterService entities and enum
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/15360
To unsubscribe, visit http://gerrit.ovir
Sandro Bonazzola has uploaded a new change for review.
Change subject: config: avoid to change existing configuration files
..
config: avoid to change existing configuration files
When reading configurarion files, just warn the
Sandro Bonazzola has posted comments on this change.
Change subject: config: avoid to change existing configuration files
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15366
To unsubscribe, visit http://ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: adding custom properties to vm interface
..
Patch Set 11: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/530/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
..
Patch Set 14: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/529/ : FAILUR
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Cannot remove custom properties from a vm
..
Patch Set 8: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/531
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Adds custom properties to VmNetworkInterface
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/528/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: adding custom properties to vnic dialog
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/527/ :
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
..
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14814
To uns
Martin Peřina has posted comments on this change.
Change subject: core: Adds custom properties to VmNetworkInterface
..
Patch Set 18: (1 inline comment)
File
backend/manager
Martin Peřina has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
..
Patch Set 13: (2 inline comments)
File
backend/manager/modules/
Yair Zaslavsky has posted comments on this change.
Change subject: core: Custom properties error handling cleanup
..
Patch Set 1: (2 inline comments)
File
backend/manager/mo
Martin Peřina has abandoned this change.
Change subject: core: Adds custom properties to VmDevice
..
Patch Set 1: Abandoned
Pushed by mistake
--
To view, visit http://gerrit.ovirt.org/15365
To unsubscribe, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Add script to dump heap
..
Patch Set 1: (1 inline comment)
File packaging/bin/engine-heap-dump.sh
Li
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: support older psycopg2
..
Patch Set 1: (1 inline comment)
File packaging/setup/ovirt_en
Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: some params on make template ignored
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Bll command to refresh gluster hooks in engine
..
Patch Set 1: No score
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Cannot remove custom properties from a vm
..
Patch Set 7: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/526
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Adds custom properties to VmNetworkInterface
..
Patch Set 19: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/524
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Changes type of VmDevice from String to enum
..
Patch Set 9: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/523/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: adding custom properties to vnic dialog
..
Patch Set 15: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/522/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Custom properties error handling cleanup
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/520/ : F
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: adding custom properties to vm interface
..
Patch Set 10: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/525/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/521/ : FAILURE
Sahina Bose has posted comments on this change.
Change subject: engine: updating GlusterService entities and enum
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15360
T
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Host detach case sync message corrected
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/513/ : S
Vered Volansky has posted comments on this change.
Change subject: core: remove memory image on remove snapshot
..
Patch Set 16: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14687
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Corrected the event log message
..
Patch Set 6: No score
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/512/ :
Vered Volansky has posted comments on this change.
Change subject: core: Fix typo
..
Patch Set 1: Looks good to me, but someone else must approve
I'd add in what method in the commit message.
--
To view, visit http://gerrit.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: VDS comand for start/stop of services
..
Patch Set 6: I would prefer that you didn't submit this
Build Unstable
http://jenkins.ovirt.org/job
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Corrected the event log message
..
Patch Set 6: No score; I would prefer that you didn't submit this
Build Unstable
http://jenkins.ovirt.org
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: jenkins: adding manainnace script for nightly builds
..
Patch Set 1: I would prefer that you didn't submit this
(7 inline comments)
...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: watchdog - restapi support
..
Patch Set 30:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/504/ : SUCCESS
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: rest cleanup [wip]
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/503/ : SUCCESS
--
To view, vi
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: rest cleanup [wip]
..
engine: rest cleanup [wip]
The second put with the CdRom.class key was overriding the previous one.
Testing needed.
Change-Id: I
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: host gluster-swift sub tab
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/502/ : SUCCESS
--
T
Arik Hadas has posted comments on this change.
Change subject: core: save memory state on live snapshot with memory
..
Patch Set 17: (4 inline comments)
partial responds, I'll respond to the rest of the comments later
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: updating GlusterService entities and enum
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/500/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Added queries for service list
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/498/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: refactored GlusterServiceStatus enum
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/497/ : SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: [WIP] host gluster-swift sub tab
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/496/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: User who has manipulate_permissions can't see other
users
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bu
Kanagaraj M has uploaded a new change for review.
Change subject: engine: refactored GlusterServiceStatus enum
..
engine: refactored GlusterServiceStatus enum
-Removed the FAILED status as vdsm won't return this.
-Changed NOT_IN
Ravi Nori has posted comments on this change.
Change subject: engine: User who has manipulate_permissions can't see other
users
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/14346
To unsubscribe, visit htt
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Fix CommonModel search string regression
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15086
To unsubsc
Daniel Erez has posted comments on this change.
Change subject: engine: add comment field to DataCenter
..
Patch Set 5: (4 inline comments)
I think it's preferable to merge along with the other business entities (i.e.
only whe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix typo
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/494/ : SUCCESS
--
To view, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Introducing Batch updates to DAOs
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/493/ : SUCCESS
-
Omer Frenkel has posted comments on this change.
Change subject: core: save memory state on live snapshot with memory
..
Patch Set 17: (5 inline comments)
File
backend/manag
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 4: I would prefer that you didn't submit this
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_
Juan Hernandez has posted comments on this change.
Change subject: tools: Add script to dump heap
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Omer Frenkel has posted comments on this change.
Change subject: core: extract general code from HibernateVmCommand
..
Patch Set 13: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1429
Juan Hernandez has uploaded a new change for review.
Change subject: tools: Add script to dump heap
..
tools: Add script to dump heap
This change adds the engine-heap-dump.sh script that generates an
histogram of the use of memo
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Added queries for service list
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/485/ : SUCCESS
Omer Frenkel has posted comments on this change.
Change subject: core: add memory snapshots capability to VdsBroker
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14201
To unsubscribe, vis
Maor Lipchuk has posted comments on this change.
Change subject: core: save memory state on live snapshot with memory
..
Patch Set 17: (6 inline comments)
File
backend/manag
Omer Frenkel has posted comments on this change.
Change subject: core: add memory volume to snapshot entity
..
Patch Set 17: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14053
To uns
Daniel Erez has posted comments on this change.
Change subject: core: Fix typo
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15357
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Omer Frenkel has posted comments on this change.
Change subject: core: add memory snapshot feature support
..
Patch Set 16: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14167
To unsubscribe, visit http:/
Yaniv Bronhaim has abandoned this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 12: Abandoned
due to http://gerrit.ovirt.org/#/c/15345/ - this change does not re
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4458/
Build Number: 4458
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Alissa Bonas has posted comments on this change.
Change subject: core: Fix typo
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15357
To unsubscribe, visit http://gerrit
Maor Lipchuk has posted comments on this change.
Change subject: core: extract general code from HibernateVmCommand
..
Patch Set 13: (2 inline comments)
File
backend/manager
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: setup: support older psycopg2
..
packaging: setup: support older psycopg2
rhel and centos have version 2.0.14 with autocommit unsupported.
Change-Id:
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: support older psycopg2
..
Patch Set 1:
Alex, can you please check if there are more issues?
Thanks!
--
To view, visit http://gerrit.ovirt.org/
Arik Hadas has posted comments on this change.
Change subject: core: add get*Type to template DAO
..
Patch Set 10: (1 inline comment)
File
backend/manager/modules/dal/src/ma
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Fix typo
..
core: Fix typo
change Compatilibily to Compatibility
Change-Id: I4a1e956d453d35b4cd5968df6ef5e6de7de975d2
Signed-off-by: Maor Lipchuk
---
M
Arik Hadas has posted comments on this change.
Change subject: add Image and Instance type interfaces
..
Patch Set 11: Looks good to me, but someone else must approve
(2 inline comments)
two minor comments
...
Daniel Erez has posted comments on this change.
Change subject: webadmin: Hide checkbox in reinit dc with no SDs
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/mo
Alissa Bonas has posted comments on this change.
Change subject: webadmin: Hide V Format field in storage domain
..
Patch Set 1: Fails
following Daniel's comment, it's problematic to hide the format field for the
following rea
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: restore memory from snapshot on run vm
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/484/ : SUCC
Maor Lipchuk has posted comments on this change.
Change subject: core: add memory volume to snapshot entity
..
Patch Set 17: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14053
To uns
Arik Hadas has posted comments on this change.
Change subject: core: add memory volume to snapshot entity
..
Patch Set 17: (2 inline comments)
File
backend/manager/dbscripts
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: add memory column to snapshot subtab
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/482/ : SU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove memory image on remove snapshot
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/483/ : SUCC
Arik Hadas has posted comments on this change.
Change subject: core: restore memory from snapshot on run vm
..
Patch Set 14: (2 inline comments)
File
backend/manager/modules
Daniel Erez has posted comments on this change.
Change subject: webadmin: Hide V Format field in storage domain
..
Patch Set 1:
The format is relevant for new domain. The DC format is specified in the
dropdown list only after
Maor Lipchuk has posted comments on this change.
Change subject: core: add memory volume to snapshot entity
..
Patch Set 17: (2 inline comments)
File
backend/manager/dbscrip
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: memory state handling on preview/commit/undo
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/481/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: [WIP] handling memory snapshots on export/import vm
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerri
Alon Bar-Lev has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 3: (7 inline comments)
File
backend/manager/modules/bll/src/ma
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing Batch updates to DAOs
..
Patch Set 9:
Allon, Kolesnik - please review, Liran cleaned up the noise.
--
To view, visit http://gerrit.ovirt.org/
Maor Lipchuk has posted comments on this change.
Change subject: core: add memory snapshot feature support
..
Patch Set 16: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14167
To unsu
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: support for creating snapshot with memory
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/479/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: add memory attribute to snapshot
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/478/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: add memory snapshot feature support
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/477/ : SUCCESS
Maor Lipchuk has posted comments on this change.
Change subject: core: restore memory from snapshot on run vm
..
Patch Set 15:
Please address my comments from last patch
--
To view, visit http://gerrit.ovirt.org/14860
To unsub
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4457/
Build Number: 4457
Build Status: Failure
Triggered By: Started by an SCM change, Started by an SCM change
-
Changes Since Last Succes
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/30/
Build Number: 30
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: add memory option to create snapshot popup
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/474
Sandro Bonazzola has posted comments on this change.
Change subject: core: modify copyright of base po
..
Patch Set 1: (1 inline comment)
File po/Makevars
Line 17: # expected
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: cleanup CreateVmVDSCommand
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/476/ : SUCCESS
--
To v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove memory from active snapshot
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/475/ : SUCCESS
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine-config: Adding man page
..
engine-config: Adding man page
Adding engine-config.8
Change-Id: I546d90550ddf53707bc667c18e8c0d44e909593f
Bug-Url:
Yair Zaslavsky has posted comments on this change.
Change subject: engine-config: Adding man page
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11176
To unsubscribe, visit http:/
Oved Ourfali has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 4:
Changes in latest patch-sets:
1. Added BaseProviderProxy to handle getting the certificate chain.
2. Addressing s
1 - 100 of 268 matches
Mail list logo