Arik Hadas has posted comments on this change.
Change subject: core: restore memory from snapshot on run vm
......................................................................
Patch Set 14: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 452: protected CreateVmVDSCommandParameters initVdsCreateVmParams() {
Line 453: VM vmToBeCreated = getVm();
Line 454: if (vmToBeCreated.getStatus() != VMStatus.Suspended) {
Line 455: Snapshot activeSnapshotOfVmToBeCreated =
Line 456:
DbFacade.getInstance().getSnapshotDao().get(vmToBeCreated.getId(),
SnapshotType.ACTIVE);
this line is dropped in a later patch..
Line 457:
vmToBeCreated.setHibernationVolHandle(activeSnapshotOfVmToBeCreated.getMemoryVolume());
Line 458: CreateVmVDSCommandParameters parameters =
Line 459: new CreateVmVDSCommandParameters(getVdsId(),
vmToBeCreated);
Line 460: parameters.setClearHibernationVolumes(true);
Line 456:
DbFacade.getInstance().getSnapshotDao().get(vmToBeCreated.getId(),
SnapshotType.ACTIVE);
Line 457:
vmToBeCreated.setHibernationVolHandle(activeSnapshotOfVmToBeCreated.getMemoryVolume());
Line 458: CreateVmVDSCommandParameters parameters =
Line 459: new CreateVmVDSCommandParameters(getVdsId(),
vmToBeCreated);
Line 460: parameters.setClearHibernationVolumes(true);
it's different - if this flag is set, it means that the hibernateVolume should
be cleared <b>right after</b> the vm is started in the host (it should restore
the saved memory state when it starts)
Line 461: return parameters;
Line 462: }
Line 463: return new CreateVmVDSCommandParameters(getVdsId(),
vmToBeCreated);
Line 464: }
--
To view, visit http://gerrit.ovirt.org/14860
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id382ff479827af96fc529b57ec0ea1b0b7d21818
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
