Yair Zaslavsky has posted comments on this change.
Change subject: engine: User who has manipulate_permissions can't see other
users
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment, please fix
....................................................
File backend/manager/dbscripts/create_views.sql
Line 1424: JOIN roles ON permissions.role_id = roles.id
Line 1425: JOIN user_flat_groups ON user_flat_groups.granted_id =
permissions.ad_element_id
Line 1426: WHERE permissions.ad_element_id != getGlobalIds('everyone');
Line 1427:
Line 1428: -- Direct permissions assigned to user
Please change the comment (you probably copy pasted it).
Line 1429: CREATE OR REPLACE VIEW user_db_users_permissions_view AS
Line 1430: SELECT DISTINCT permissions.ad_element_id, roles_groups.role_id,
roles_groups.action_group_id
Line 1431: FROM permissions
Line 1432: JOIN roles_groups ON permissions.role_id = roles_groups.role_id
--
To view, visit http://gerrit.ovirt.org/14346
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35852738d60af36ca4f44a175e2c4f8523148732
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
