Maor Lipchuk has posted comments on this change.
Change subject: core: extract general code from HibernateVmCommand
......................................................................
Patch Set 13: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 540: }
Line 541: return null;
Line 542: }
Line 543:
Line 544: protected static boolean
doesStorageDomainhaveSpaceForRequest(StorageDomain storageDomain, long
sizeRequested) {
Use upper case for does...Have...Request instead does...have...Request
Line 545: // not calling validate in order not to add the messages per
domain
Line 546: return (new
StorageDomainValidator(storageDomain).isDomainHasSpaceForRequest(sizeRequested)).isValid();
Line 547: }
Line 548: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1458: * @return - Memory size for allocation in bytes.
Line 1459: */
Line 1460: @JsonIgnore
Line 1461: public long getTotalMemorySizeInBytes() {
Line 1462: return (long) (getVmMemSizeMb() + 200 + (64 *
getNumOfMonitors())) * 1024 * 1024;
Please use constants so it will be more readable. What does 200 means?
Line 1463: }
Line 1464:
Line 1465: ///////////////////////////////////////////////
Line 1466: /// Utility methods that check the VM state ///
--
To view, visit http://gerrit.ovirt.org/14290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15c4f3302d26eb5d161824f8bb19ecc5dd114a20
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
