Oved Ourfali has posted comments on this change. Change subject: WIP Support foreman SSL provider ......................................................................
Patch Set 4: Changes in latest patch-sets: 1. Added BaseProviderProxy to handle getting the certificate chain. 2. Addressing some of the comments by Alon... comments that I didn't address were discussed in person. 3. The current implementation fits the current use-case we wish to support - importing a certificate chain of a secured provider to a truststore. 4. Still need to do some changes in the UI. I might make this patch do the following when using "test provider": * Test * If fail on SSL issues, import the certificate chain. * Test again. Desired behaviour: * Test * If fail on SSL, get the certificate chain, and ask user for approval to import it * If user approves, import it, and then test again. -- To view, visit http://gerrit.ovirt.org/15128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35343409d74a4f90aae726b46781f27ce08a981a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
