Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: fix local state dirs ownership
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
.
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: fix local state dirs ownership
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/15117
To unsubscribe, visit http://gerrit.
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: force Apache proxy on upgrade
..
Patch Set 6: (2 inline comments)
File packaging/fedora/set
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: fix local state dirs ownership
..
Patch Set 2: (1 inline comment)
File packaging/setup/
Yair Zaslavsky has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 8: (1 inline comment)
..
Yair Zaslavsky has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 8: (1 inline comment)
..
Yair Zaslavsky has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 8: (2 inline comments)
.
Yaniv Bronhaim has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 8: (1 inline comment)
..
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: force Apache proxy on upgrade
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/15051
To unsubscribe, visit http://gerrit.o
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: force Apache proxy on upgrade
..
Patch Set 5: (2 inline comments)
File packaging/fedora
Allon Mureinik has posted comments on this change.
Change subject: engine: add comment field to DataCenter
..
Patch Set 4: Looks good to me, but someone else must approve
+1 on the backend side.
Please make sure a frontend main
Allon Mureinik has posted comments on this change.
Change subject: core: No Search for isVmTemlateWithSameNameExist
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15149
To unsubscribe, visit http://gerrit.ov
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: support lexical parsing of configuration
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
...
Allon Mureinik has uploaded a new change for review.
Change subject: core: No Search for isVmTemlateWithSameNameExist
..
core: No Search for isVmTemlateWithSameNameExist
Replaced VmTemplateCommand.isVmTemlateWithSameNameExist(St
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: support lexical parsing of configuration
..
Patch Set 2: (1 inline comment)
File backend/ma
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: use firewalld implementation of otopi
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: support lexical parsing of configuration
..
Patch Set 2: (1 inline comment)
File backen
Allon Mureinik has posted comments on this change.
Change subject: core: Remove call to super CDA
..
Patch Set 1: I would prefer that you didn't submit this
I tend to agree with Vered's review, although I don't feel really stro
Allon Mureinik has posted comments on this change.
Change subject: core: Change type and action when attaching a domain
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15090
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: Remove call to super CDA(2)
..
Patch Set 1: I would prefer that you didn't submit this
I tend to agree with Vered's review, although I don't feel really s
Allon Mureinik has posted comments on this change.
Change subject: core: SEAT compensate - prevent IndexOutOfBounds
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15133
To unsubscribe, visi
Allon Mureinik has posted comments on this change.
Change subject: core: SEAT compensate - prevent IndexOutOfBounds
..
Patch Set 3: (1 inline comment)
File
backend/manager/m
Allon Mureinik has posted comments on this change.
Change subject: core: Remove empty CDA
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15087
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused classes from uioverrides
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15147
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Clean up Compat.gwt.xml
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15146
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: webadmin: implicit quota defs in Common.gwt.xml
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15145
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has uploaded a new change for review.
Change subject: webadmin: implicit quota defs in Common.gwt.xml
..
webadmin: implicit quota defs in Common.gwt.xml
Removed the explicit entries for quota queries and actions,
Allon Mureinik has uploaded a new change for review.
Change subject: webadmin: Clean up Compat.gwt.xml
..
webadmin: Clean up Compat.gwt.xml
Removed unused and non-existent classes from Compat.gwt.xml to speed up
the build.
Chan
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove unused classes from uioverrides
..
core: Remove unused classes from uioverrides
Removed async_tasks, Encoding and StringBuilderCompat from uioverr
Roy Golan has posted comments on this change.
Change subject: core: [WIP] Use OS repository intead of VmOsType
..
Patch Set 5:
* switching to async queries in AsyncDataProvider
--
To view, visit http://gerrit.ovirt.org/15078
T
Vered Volansky has posted comments on this change.
Change subject: core: removed limitation of get topSizeVms query
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14558
Vered Volansky has posted comments on this change.
Change subject: core: SEAT compensate - prevent IndexOutOfBounds
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15133
Shubhendu Tripathi has posted comments on this change.
Change subject: tools: Adds UserDefinedVMProperties validator to engine-config
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Sharad Mishra has uploaded a new change for review.
Change subject: api: API to prepare VM disk for backup.
..
api: API to prepare VM disk for backup.
This new api gets the vm disk to be backed up and passes it to VDSM for
expos
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: support lexical parsing of configuration
..
Patch Set 2:
Escape password also in old setup
--
To view, visit http://gerrit.ovirt.org/15142
To u
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: support lexical parsing of configuration
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15142
To unsubscribe, visit http://g
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: setup: support lexical parsing of configuration
..
packaging: setup: support lexical parsing of configuration
the configuration file format is shell l
Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: branding support.
..
Patch Set 19:
* @Alex - can you please rebase manually (I get some conflicts...).
* @Yair - can you please take a look o
Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: branding support.
..
Patch Set 19: Looks good to me, but someone else must approve
@Alex - can you please rebase manually (I get some conflic
Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: redesign of vm related dialogs
..
Patch Set 5: Looks good to me, but someone else must approve
(now with better formatting :)
Code looks good
Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: redesign of vm related dialogs
..
Patch Set 5: (1 inline comment)
Code looks good.
A few questions regarding the design:
1. Why do we want the
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated fkvalidator SP to drop function before
recreating
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15141
To unsubscribe, visi
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated fkvalidator SP to drop function before
recreating
..
packaging: Updated fkvalidator SP to drop function before recreating
This package updates
Eldan Hildesheim has posted comments on this change.
Change subject: userportal,webadmin: redesign of vm related dialogs
..
Patch Set 4:
We should have the same white border in the left as well.
Thanks
--
To view, visit http:/
Tomáš Došek has uploaded a new change for review.
Change subject: engine: Fix for BZ#967890 - enhance logging of JndiAction level
in dEBUG mode
..
engine: Fix for BZ#967890 - enhance logging of JndiAction level in dEBUG mode
En
Daniel Erez has posted comments on this change.
Change subject: webadmin: adding custom properties to vnic dialog
..
Patch Set 9: (1 inline comment)
Commit Message
Line 5: Co
Daniel Erez has posted comments on this change.
Change subject: webadmin: adding custom properties to vnic dialog
..
Patch Set 9: Looks good to me, approved
(3 inline comments)
.
Moti Asayag has posted comments on this change.
Change subject: core: Adds custom properties to VmNetworkInterface
..
Patch Set 13: (2 inline comments)
File
backend/manager/
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Fixed potential NPE in URI
..
webadmin: Fixed potential NPE in URI
Justly noted by Findbugs.
Change-Id: Ie3216adef9caeaf32c2d0cf0f33c03807f62ba
Daniel Erez has posted comments on this change.
Change subject: webadmin: Fixed potential NPE in URI
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/15095
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: webadmin: Fixed potential NPE in URI
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15095
To unsubscribe, visit http://gerrit
Daniel Erez has submitted this change and it was merged.
Change subject: userportal,webadmin: uicommon cleanup
..
userportal,webadmin: uicommon cleanup
- Removed unused asyncSearch and associated methods.
Change-Id: Ica13e40ed
Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: uicommon cleanup
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/14654
To unsubscribe,
Einav Cohen has posted comments on this change.
Change subject: webadmin: Fixed potential NPE in URI
..
Patch Set 1:
Hi Alona, any chance that you can review this patch? this is a 'findbugs' fix
that has been introduced in htt
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding root command id
..
Patch Set 1: Verified
Verified by running DAO tests
--
To view, visit http://gerrit.ovirt.org/15138
To unsubscribe, visit http:
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: adding root command id
..
core: adding root command id
Adding root command Id to DAO and business
entity.
Root command Id represents the command Id of th
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Adds UserDefinedVMProperties validator to engine-config
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14914
To uns
Yair Zaslavsky has posted comments on this change.
Change subject: core: Prepare custom device properties support in
VmPropertiesUtils
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14813
Daniel Erez has posted comments on this change.
Change subject: core: seat compensate - prevent IndexOutOfBounds
..
Patch Set 3: (3 inline comments)
File
backend/manager/mod
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: force Apache proxy on upgrade
..
Patch Set 5: (2 inline comments)
Looks good, two minor comments.
.
Alon Bar-Lev has posted comments on this change.
Change subject: core: [WIP] Manage OS properties in a repository
..
Patch Set 5: (1 inline comment)
File backend/manager/modu
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Integrate noVNC support
..
Patch Set 7: (3 inline comments)
File backend/manager/modules/root/src/mai
Itamar Heim has posted comments on this change.
Change subject: core: [WIP] Manage OS properties in a repository
..
Patch Set 5: (1 inline comment)
File backend/manager/modul
Allon Mureinik has submitted this change and it was merged.
Change subject: core: improve CDA of AddStorageServerConnection
..
core: improve CDA of AddStorageServerConnection
Improve canDoAction of AddStorageServerConnectionCom
Allon Mureinik has submitted this change and it was merged.
Change subject: core: set action msg for ForceRemoveStorageDomain
..
core: set action msg for ForceRemoveStorageDomain
Set action message type (var action) in setActio
Allon Mureinik has posted comments on this change.
Change subject: core: improve CDA of AddStorageServerConnection
..
Patch Set 5: Verified; Looks good to me, approved
Rebased, no changes
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: set action msg for ForceRemoveStorageDomain
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no changes
--
To view, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: ConnectAllHostsToLun shouldn't run within transaction
..
Patch Set 2: Looks good to me, but someone else must approve
Looks good to me.
Alissa - please t
Allon Mureinik has posted comments on this change.
Change subject: core: improve CDA of AddStorageServerConnection
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
Allon Mureinik has posted comments on this change.
Change subject: core, webadmin: Move VmValidationUtils
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes.
+2 by Tal and Daniel, +1 by Omer and Tomas
--
Allon Mureinik has submitted this change and it was merged.
Change subject: core, webadmin: Move VmValidationUtils
..
core, webadmin: Move VmValidationUtils
This class has no business being in common - it's conceptually part of
Frank Kobzik has posted comments on this change.
Change subject: engine: Integrate noVNC support
..
Patch Set 7: (4 inline comments)
File backend/manager/modules/root/src/mai
Allon Mureinik has posted comments on this change.
Change subject: core: seat compensate - prevent IndexOutOfBounds
..
Patch Set 3:
please see inline - the method's name is the only serious issue.
Other than that, +2.
--
To v
Allon Mureinik has posted comments on this change.
Change subject: core: seat compensate - prevent IndexOutOfBounds
..
Patch Set 3: Looks good to me, but someone else must approve
(3 inline comments)
..
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: enforcing Apache proxy on new install
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Alexander Wels has posted comments on this change.
Change subject: userportal,webadmin: uicommon cleanup
..
Patch Set 3: Verified
Updated based on Daniels comments.
--
To view, visit http://gerrit.ovirt.org/14654
To unsubscrib
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: Remove method that is never called
..
findbugs: Remove method that is never called
findbugs reason:
UPM: Private method is never called (UPM_U
Shahar Havivi has posted comments on this change.
Change subject: findbugs: Remove method that is never called
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15135
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 1:
> Do you suggest to create a new script to create it? I can. I just guess it is
> pretty much similar commands,
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: unused local variables
..
findbugs: unused local variables
Remove unused local variables
findbugs reason:
DLS: Dead store to local variable (
Shahar Havivi has posted comments on this change.
Change subject: findbugs: unused local variables
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15092
To unsubscribe, visit http:
Oved Ourfali has posted comments on this change.
Change subject: findbugs: ignore: ignore unused host variable in parse dns
record
..
Patch Set 2:
Yair - have a look and tell us what you think.
I think it is okay to ignore.
-
Oved Ourfali has posted comments on this change.
Change subject: findbugs: ignore: ignore unused host variable in parse dns
record
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Oved Ourfali has posted comments on this change.
Change subject: findbugs: Remove method that is never called
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15135
To unsubscribe, visit http
Oved Ourfali has posted comments on this change.
Change subject: findbugs: unused local variables
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15092
To unsubscribe, visit http://gerrit.ov
Alona Kaplan has uploaded a new change for review.
Change subject: restapi: Cannot remove custom properties from a vnic
..
restapi: Cannot remove custom properties from a vnic
When passing to update vm, the custom properties
Alona Kaplan has posted comments on this change.
Change subject: webadmin: adding custom properties to vnic dialog
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/15020
To unsubscribe, visit http://gerrit.ovi
Alona Kaplan has posted comments on this change.
Change subject: restapi: adding custom properties to vm interface
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/15101
To unsubscribe, visit http://gerrit.ovi
Alona Kaplan has posted comments on this change.
Change subject: restapi: Cannot remove custom properties from a vnic
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15137
To unsubscribe, visit http://gerrit
Ravi Nori has posted comments on this change.
Change subject: core: Introducing "end command coordination" by command Id.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Ravi Nori has posted comments on this change.
Change subject: core: Introducing EntityInfo
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14992
To unsubscribe, visit ht
Daniel Erez has posted comments on this change.
Change subject: userportal: Refresh stops session timeout.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15134
To unsub
Ravi Nori has posted comments on this change.
Change subject: core: SPMAsyncTask -> change from associatedEntities + single
type to map
..
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
Just
Daniel Erez has posted comments on this change.
Change subject: findbugs: unused local variables
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15092
To unsubscribe, vi
Ravi Nori has posted comments on this change.
Change subject: core: Adding the ability to get async tasks by entity id
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: force Apache proxy on upgrade
..
Patch Set 5: Verified
verified only upgrading from yesterday nightly.
--
To view, visit http://gerrit.ovir
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: Remove method that is never called
..
findbugs: Remove method that is never called
findbugs reason:
UPM: Private method is never called (UPM_UNCALLED_
Alon Bar-Lev has posted comments on this change.
Change subject: core: [WIP] Manage OS properties in a repository
..
Patch Set 5: (2 inline comments)
File backend/manager/mod
Oved Ourfali has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 1: (3 inline comments)
Do you suggest to create a new script to create it?
I can. I just guess it is pretty much sim
Alexander Wels has posted comments on this change.
Change subject: userportal: Refresh stops session timeout.
..
Patch Set 1: Verified
Verified that automatic refresh does not reset the timeout for all the pages
that have an a
1 - 100 of 224 matches
Mail list logo
