Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: force Apache proxy on upgrade
......................................................................
Patch Set 5: (2 inline comments)
Looks good, two minor comments.
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 581: if handler.getParam("SSLCertificateKeyFile") ==
'/etc/pki/tls/private/localhost.key':
Line 582: handler.editParam("SSLCertificateKeyFile",
basedefs.FILE_APACHE_PRIVATE_KEY)
Line 583: if handler.getParam("SSLCertificateChainFile") == None:
Line 584: handler.editParam("SSLCertificateChainFile",
basedefs.FILE_APACHE_CA_CRT_SRC)
Line 585: handler.close()
finally? ^
Line 586:
Line 587: def commit(self):
Line 588: if os.path.exists(self.TMPAPACHECONF):
Line 589: shutil.move(self.TMPAPACHECONF,
basedefs.FILE_HTTPD_SSL_CONFIG)
Line 1089: fqdn = handler.getParam('ENGINE_FQDN')
Line 1090: proxyEnabled = handler.getParam('ENGINE_PROXY_ENABLED') == 'true'
Line 1091: if proxyEnabled:
Line 1092: logging.debug('oVirt engine Apache proxy was already
enabled')
Line 1093: handler.close()
close anyway?
Line 1094: else:
Line 1095: utils.editEngineSysconfigProtocols(
Line 1096: fqdn=fqdn,
Line 1097: http='80',
--
To view, visit http://gerrit.ovirt.org/15051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib46bcf40acff860cd3e52634ade683d7a8836cf6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
