Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: fix local state dirs ownership ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/system/localstate.py Line 83: ): Line 84: os.chown(root, uid, gid) Line 85: for name in dirs: Line 86: os.chown(os.path.join(root, name), uid, gid) Line 87: for name in files: Oh... I had this comment before, why not use the dirs + files magic above here too? :) Line 88: os.chown(os.path.join(root, name), uid, gid) Line 89: Line 90: -- To view, visit http://gerrit.ovirt.org/15117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I180fa0b1c3ded975c052405126819d91524a829f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
