Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: redesign of vm related dialogs ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (now with better formatting :) Code looks good. A few questions regarding the design: * Why do we want the static header only in VM dialog? * DC/Host are really relevant for all tabs? * Is it just a preparation for the final instance type dialog? * If it's indeed merely preparation, shouldn't it be merged only once we have the full picture of the new dialog? -- To view, visit http://gerrit.ovirt.org/14635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icad8098e286f821da25fac22fd0a840a42f105c9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eldan Hildesheim <i...@eldanet.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
