[Engine-patches] Change in ovirt-engine[master]: core: No Search for isVmTemlateWithSameNameExist

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: core: No Search for isVmTemlateWithSameNameExist
......................................................................

core: No Search for isVmTemlateWithSameNameExist

Replaced VmTemplateCommand.isVmTemlateWithSameNameExist(String)'s
implementation with a simple DAO call instead of invoking an expensive
Search query.

Change-Id: I5e9d57ad4d46b22d98529e07a2c67fed968d45cf
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
1 file changed, 1 insertion(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/15149/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
index 9103bf6..46f1232 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
@@ -11,7 +11,6 @@
 import org.ovirt.engine.core.common.VdcObjectType;
 import org.ovirt.engine.core.common.action.VmTemplateParametersBase;
 import org.ovirt.engine.core.common.businessentities.DiskImage;
-import org.ovirt.engine.core.common.businessentities.IVdcQueryable;
 import org.ovirt.engine.core.common.businessentities.ImageStatus;
 import org.ovirt.engine.core.common.businessentities.VmDeviceId;
 import org.ovirt.engine.core.common.businessentities.VmTemplate;
@@ -19,9 +18,6 @@
 import 
org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface;
 import org.ovirt.engine.core.common.config.Config;
 import org.ovirt.engine.core.common.config.ConfigValues;
-import org.ovirt.engine.core.common.interfaces.SearchType;
-import org.ovirt.engine.core.common.queries.SearchParameters;
-import org.ovirt.engine.core.common.queries.VdcQueryType;
 import org.ovirt.engine.core.compat.Guid;
 import org.ovirt.engine.core.compat.NotImplementedException;
 import org.ovirt.engine.core.dal.VdcBllMessages;
@@ -52,12 +48,7 @@
     }
 
     public static boolean isVmTemlateWithSameNameExist(String name) {
-        SearchParameters p = new SearchParameters("template : name=" + name, 
SearchType.VmTemplate);
-        p.setMaxCount(Integer.MAX_VALUE);
-        List<IVdcQueryable> list = (List<IVdcQueryable>) 
Backend.getInstance().runInternalQuery(VdcQueryType.Search, p)
-                .getReturnValue();
-
-        return list.size() > 0;
+        return DbFacade.getInstance().getVmTemplateDao().getByName(name, null, 
false) != null;
     }
 
     public static boolean isVmTemplateImagesReady(VmTemplate vmTemplate,


--
To view, visit http://gerrit.ovirt.org/15149
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e9d57ad4d46b22d98529e07a2c67fed968d45cf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches