Yair Zaslavsky has posted comments on this change.
Change subject: engine : Fail tasks that dont have Vdsm Id
..
Patch Set 7: (1 inline comment)
File
backend/manager/modules
Omer Frenkel has posted comments on this change.
Change subject: core: introduce VM status PrepareForHibernate
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14511
To unsubscribe, visit htt
Omer Frenkel has submitted this change and it was merged.
Change subject: core: reduce compensation scope from hibernate command
..
core: reduce compensation scope from hibernate command
This patch reduce the scope in which the
Omer Frenkel has posted comments on this change.
Change subject: core: reduce compensation scope from hibernate command
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14510
To uns
Sahina Bose has posted comments on this change.
Change subject: gluster: Change sp name for hook content read
..
Patch Set 1: No score
@Yair, there's already a test case for getGlusterHookContent
--
To view, visit http://gerri
Shubhendu Tripathi has posted comments on this change.
Change subject: engine:VDS command to update hook content
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14638
To
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Change sp name for hook content read
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1483
Maor Lipchuk has posted comments on this change.
Change subject: engine : Fail tasks that dont have Vdsm Id
..
Patch Set 7: (6 inline comments)
File
backend/manager/modules/
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Fail tasks that dont have Vdsm Id
..
Patch Set 7: (3 inline comments)
File
backend/manager/module
Yair Zaslavsky has posted comments on this change.
Change subject: core : Persist AsyncTask before submitting to vdsm
..
Patch Set 7: Looks good to me, but someone else must approve
Looks good, adding Allon and giving chance to
Yair Zaslavsky has posted comments on this change.
Change subject: core : Distingushing between entity and vdsm task ids
..
Patch Set 12: (2 inline comments)
In general - good work.
Some minor comments to be fixed.
...
Yair Zaslavsky has posted comments on this change.
Change subject: core : Distingushing between entity and vdsm task ids
..
Patch Set 12:
Arik - great question.
Currently we don't support upgrade with tasks (i.e - after upgrade
Yair Zaslavsky has posted comments on this change.
Change subject: core : Persist AsyncTask before submitting to vdsm
..
Patch Set 7:
Ravi -
Bare in mind that at this patch you still don't have Coco.
And also, as agreed in last
Yair Zaslavsky has posted comments on this change.
Change subject: core: Changes type of VmDevice from String to enum
..
Patch Set 1: (1 inline comment)
File
backend/manager
Yair Zaslavsky has posted comments on this change.
Change subject: core: Changes type of VmDevice from String to enum
..
Patch Set 1: (1 inline comment)
Roy, not sure I fully understand your idea.
1. What is DeviceName ?
2. I
Yair Zaslavsky has posted comments on this change.
Change subject: core: Changes type of VmDevice from String to enum
..
Patch Set 1:
All,
1. Added Eli here - as I see there are questions about device vs type.
2. AFAIK, you can
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds custom properties to VmNetworkInterface
..
Patch Set 1: (1 inline comment)
File
backend/manager
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: align Path field in NfsStorage dialog
..
webadmin: align Path field in NfsStorage dialog
Align the export path field and it's hint label in nfs
Daniel Erez has posted comments on this change.
Change subject: webadmin: align Path field in NfsStorage dialog
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14817
To unsubscribe
Daniel Erez has posted comments on this change.
Change subject: webadmin: align Path field in NfsStorage dialog
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14817
To unsubscribe, visit ht
Yair Zaslavsky has posted comments on this change.
Change subject: core: lock the vds manager while calling hibernate verb
..
Patch Set 4: Looks good to me, approved
I understand why this is done (similar to reusme) - i think t
Yair Zaslavsky has posted comments on this change.
Change subject: core: reduce compensation scope from hibernate command
..
Patch Set 5: Looks good to me, approved
(2 inline comments)
Based on Omer +1, and my review - giving
Arik Hadas has posted comments on this change.
Change subject: core: Introduce scheduling package
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14580
To unsubscribe, v
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: [WIP] preview snapshot with memory popup
..
webadmin: [WIP] preview snapshot with memory popup
New popup is now shown when the user choose to preview sna
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: [WIP] add memory option to create snapshot popup
..
webadmin: [WIP] add memory option to create snapshot popup
If the user choose to create snapshot for
Daniel Erez has submitted this change and it was merged.
Change subject: core: VmReplicateDiskFinish on SyncImageData failure
..
core: VmReplicateDiskFinish on SyncImageData failure
Requirements:
* VmReplicateDiskFinish should
Daniel Erez has posted comments on this change.
Change subject: core: VmReplicateDiskFinish on SyncImageData failure
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14722
To unsubs
Liron Ar has posted comments on this change.
Change subject: core: wip: handle failed import of template
..
Patch Set 4:
@Allon - validation that there are no floating disks with the same guid. after
this change, the failed to
Roy Golan has posted comments on this change.
Change subject: core: FQCN imports in the bll project
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14805
To unsubscribe, visit http://gerrit.
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4319/
Build Number: 4319
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Laszlo Hornyak has posted comments on this change.
Change subject: engine: cleanup after test fix
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Mike Kolesnik has posted comments on this change.
Change subject: (WIP) Adding caching capabilities to database access
..
Patch Set 4: (11 inline comments)
Please make sure the new code adheres to the rformatting by the formatt
Allon Mureinik has posted comments on this change.
Change subject: core: VmReplicateDiskFinish on SyncImageData failure
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14722
To unsubscribe,
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: ignore: added ignore missing break in switch-case
..
findbugs: ignore: added ignore missing break in switch-case
findbugs reason:
SF: Switch statement
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4318/
Build Number: 4318
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Liron Ar has posted comments on this change.
Change subject: core: wip: handle failed import of template
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/bll
Ofer Schreiber has submitted this change and it was merged.
Change subject: pki: solve ibm/openjdk incompatibility
..
pki: solve ibm/openjdk incompatibility
synthesis PKCS#12 using openssl to remove the friendly name causing th
Ofer Schreiber has posted comments on this change.
Change subject: pki: solve ibm/openjdk incompatibility
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14864
To unsubscribe, visi
Moti Asayag has posted comments on this change.
Change subject: core: Adds custom properties to VmNetworkInterface
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: added FQDN validation to engine-setup-2
..
packaging: setup: added FQDN validation to engine-setup-2
- Added missing FQDN falidation
Ofer Schreiber has posted comments on this change.
Change subject: packaging: setup: added FQDN validation to engine-setup-2
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14699
Roy Golan has posted comments on this change.
Change subject: core: Changes type of VmDevice from String to enum
..
Patch Set 1:
I would like to see a single data structure that has all the supported
types->names
enum VmDev
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 22: Verified
--
To view, visit http://gerrit.ovirt.org/13059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
..
Patch Set 18: Verified
just rebased, no change
--
To view, visit http://gerrit.ovirt.org/13057
To unsubscribe, visit
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rename methods in DiskImage
..
core: rename methods in DiskImage
Rename get/setActualSizeFromDiskImage to get/setActualSizeInBytes
to reflect bet
Allon Mureinik has posted comments on this change.
Change subject: core: rename methods in DiskImage
..
Patch Set 6: Verified; Looks good to me, approved
Rebased, no changes
--
To view, visit http://gerrit.ovirt.org/14768
To u
Allon Mureinik has posted comments on this change.
Change subject: core: Moves VmPropertiesUtils to CustomPropetiesUtils
..
Patch Set 1: (2 inline comments)
File
backend/man
Yair Zaslavsky has posted comments on this change.
Change subject: core: Moves VmPropertiesUtils to CustomPropetiesUtils
..
Patch Set 1:
For the sake of all, adding a comment here -
Martin - there is also missing functionality
Moti Asayag has posted comments on this change.
Change subject: core: Changes type of VmDevice from String to enum
..
Patch Set 1:
It was introduced with the stable device addresses feature, see:
http://www.ovirt.org/Features/
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: backup database before clearing
..
packaging: setup: backup database before clearing
move backup restore into utilities, to allow reu
Ofer Schreiber has posted comments on this change.
Change subject: packaging: setup: backup database before clearing
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14703
To unsubs
Michael Pasternak has posted comments on this change.
Change subject: restapi: FQCN imports in the jaxrs project
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14807
To
Michael Pasternak has posted comments on this change.
Change subject: restapi: FQCN imports in the types project
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14808
To
Michael Pasternak has posted comments on this change.
Change subject: core: Remove GetAllAdGroupsQuery
..
Patch Set 3:
not sure this is a right approach, BackendGroupsResource uses GetAllDbUsers to
fetch groups, while BackendG
Michael Pasternak has posted comments on this change.
Change subject: core: Remove GetAllAdGroupsQuery
..
Patch Set 3:
not sure this is a right approach, BackendGroupsResource uses
GetAllDbUsers to fetch groups, while BackendGr
Allon Mureinik has posted comments on this change.
Change subject: core: rename methods in DiskImage
..
Patch Set 5: Verified; Looks good to me, approved
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/14768
To
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: edit inactive when VM is running
..
webadmin: edit inactive when VM is running
Edit button shouldn't be grayed out for
inactive disks when the V
Daniel Erez has posted comments on this change.
Change subject: webadmin: edit inactive when VM is running
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14764
To unsubscribe, vis
Allon Mureinik has posted comments on this change.
Change subject: core: Changes type of VmDevice from String to enum
..
Patch Set 1: (1 inline comment)
A stupid question:
Why do we need VmDevice.type AND VmDevice.device?
what'
Daniel Erez has posted comments on this change.
Change subject: webadmin: edit inactive when VM is running
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14764
To unsubscribe, visit http://gerrit.ovirt.org/s
Oved Ourfali has posted comments on this change.
Change subject: foreman integration - showing foreman hosts in new host dialog
..
Patch Set 9:
1. Added a tester for the query
2. Now not showing hosts that were already added
3.
Moti Asayag has posted comments on this change.
Change subject: core: Adds custom properties to VmDevice
..
Patch Set 1: (6 inline comments)
File
backend/manager/modules/com
Michael Pasternak has posted comments on this change.
Change subject: core: rename methods in DiskImage
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14768
To unsubscr
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: added summary to engine-cleanup-2
..
packaging: setup: added summary to engine-cleanup-2
moved dialog summary from ovirt-engine-setup
Ofer Schreiber has posted comments on this change.
Change subject: packaging: setup: added summary to engine-cleanup-2
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14701
To unsu
Allon Mureinik has posted comments on this change.
Change subject: core: wip: handle failed import of template
..
Patch Set 2: (2 inline comments)
1. see inline.
2. what kind of CDA validation do you want there?
..
Daniel Erez has posted comments on this change.
Change subject: core: VmReplicateDiskFinish on SyncImageData failure
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14722
To unsubscribe, visit http://gerrit.o
Gilad Chaplik has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 22: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13059
To unsubscribe, visit http://gerrit.ovirt
Alissa Bonas has posted comments on this change.
Change subject: core: removed limitation of get topSizeVms query
..
Patch Set 6: Verified
Fixed Allon's comments
--
To view, visit http://gerrit.ovirt.org/14558
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: Removed unused Disk and LunDisk c'tors
..
Patch Set 1:
After this patch, only the default ctor will be left - why not remove it too?
I see no merit in exp
Allon Mureinik has posted comments on this change.
Change subject: core: rename methods in DiskImage
..
Patch Set 4:
Guys, please wait for Michael's ack to merge.
--
To view, visit http://gerrit.ovirt.org/14768
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: fix otopi implementation version locking
handling
..
Patch Set 4: (3 inline comments)
File
Roy Golan has posted comments on this change.
Change subject: core: Make GUID encoders singletons
..
Patch Set 3: Looks good to me, approved
basically yes but nevermind this patch is good. lets kick this in
--
To view, visit h
Tal Nisan has posted comments on this change.
Change subject: core: Removed user_action_map
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14792
To unsubscribe, visit http://gerrit.ovirt.or
Tal Nisan has posted comments on this change.
Change subject: core: FQCN imports in the bll project
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/m
Tal Nisan has posted comments on this change.
Change subject: restapi: FQCN imports in the types project
..
Patch Set 3:
With all due respect to REST maintainers, this is a plain and simple Java fix,
I fail to see why do we ne
Alon Bar-Lev has posted comments on this change.
Change subject: pki: solve ibm/openjdk incompatibility
..
Patch Set 1: Verified
resolve minor conflict in message.
--
To view, visit http://gerrit.ovirt.org/14864
To unsubscribe
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: solve ibm/openjdk incompatibility
..
pki: solve ibm/openjdk incompatibility
synthesis PKCS#12 using openssl to remove the friendly name causing the
openjdk
Yair Zaslavsky has posted comments on this change.
Change subject: core: Moves VmPropertiesUtils to CustomPropetiesUtils
..
Patch Set 1: (1 inline comment)
File
backend/mana
Maor Lipchuk has posted comments on this change.
Change subject: core: move image group command
..
Patch Set 6: (1 inline comment)
File
backend/manager/modules/bll/src/main/
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Improved duplicate host validation
..
Patch Set 1:
yaniv, you actually say that we need to activate a host in order to install it
:)
--
To view, visit h
Omer Frenkel has posted comments on this change.
Change subject: core: Removed user_action_map
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14792
To unsubscribe, visi
Alissa Bonas has posted comments on this change.
Change subject: core: rename methods in DiskImage
..
Patch Set 4: (1 inline comment)
File
frontend/webadmin/modules/webadmin
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: fix gluster hook mapping
..
engine: fix gluster hook mapping
Fixes gluster hook mapping.
Change-Id: Ia79d7c52aeb6d496d6966d8759b6e35a87d2ac18
Laszlo Hornyak has posted comments on this change.
Change subject: engine: claenup after test fix
..
Patch Set 1: Fails
oops, this one needs some organize import, sorry
--
To view, visit http://gerrit.ovirt.org/14863
To unsubs
Yair Zaslavsky has posted comments on this change.
Change subject: engine: fix gluster hook mapping
..
Patch Set 2: Verified; Looks good to me, approved
Had to merge, in order for DAOs not to break.
--
To view, visit http://ge
Laszlo Hornyak has posted comments on this change.
Change subject: engine: claenup after test fix
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Laszlo Hornyak has posted comments on this change.
Change subject: engine: fix gluster hook mapping
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14862
To unsubscribe, visit http://gerrit.ovirt.org/settings
Omer Frenkel has posted comments on this change.
Change subject: core: Remove ResetVDSCommand
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14797
To unsubscribe, visit http://gerrit.ovirt.
Omer Frenkel has posted comments on this change.
Change subject: core: Remove RunVmHyperChannelCommand
..
Patch Set 2: Looks good to me, approved
thanks
--
To view, visit http://gerrit.ovirt.org/14795
To unsubscribe, visit htt
Omer Frenkel has posted comments on this change.
Change subject: core: FQCN imports in the bll project
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Omer Frenkel has posted comments on this change.
Change subject: engine: Forbid star imports
..
Patch Set 3: Looks good to me, but someone else must approve
not sure who should do the final approve for that
--
To view, visit h
Moti Asayag has posted comments on this change.
Change subject: core: Moves VmPropertiesUtils to CustomPropetiesUtils
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: fix gluster hook mapping
..
engine: fix gluster hook mapping
Fixes gluster hook mapping.
Change-Id: Ia79d7c52aeb6d496d6966d8759b6e35a87d2ac18
Signed-o
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: claenup after test fix
..
engine: claenup after test fix
Signed-off-by: Laszlo Hornyak
Change-Id: I4c21b56d58eb2bd1a77301f1bc6473ce4da24908
---
M
bac
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Fix RunOnce from a CD-ROM
..
core: Fix RunOnce from a CD-ROM
Change-Id I2c10427764fa58faee54afaa89c4e5e62f5bad82 introduced a
regression that did n
Omer Frenkel has posted comments on this change.
Change subject: core: Fix RunOnce from a CD-ROM
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14818
To unsubscribe, visit http://
Omer Frenkel has posted comments on this change.
Change subject: core: Fix RunOnce from a CD-ROM
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14818
To unsubscribe, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: core: Changes type of VmDevice from String to enum
..
Patch Set 1: (2 inline comments)
File
backend/manage
1 - 100 of 189 matches
Mail list logo
