Arik Hadas has uploaded a new change for review.
Change subject: webadmin: [WIP] add memory option to create snapshot popup
......................................................................
webadmin: [WIP] add memory option to create snapshot popup
If the user choose to create snapshot for running VM, the create
snapshot popup will now provide an option whether to take snapshot for
the memory as well or not (disks only) by a checkbox.
Change-Id: I64cb8c705b0ae6c40b5b041876c55dfdc26c103f
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
4 files changed, 33 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/14867/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
index 42e9d2b..4431f37 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
@@ -154,6 +154,9 @@
@DefaultStringValue("Description")
String virtualMachineSnapshotCreatePopupDescriptionLabel();
+ @DefaultStringValue("Save Memory")
+ String virtualMachineSnapshotCreatePopupMemoryLabel();
+
@DefaultStringValue("Loading...")
String loadingLabel();
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java
index aa84a25..142c8c4 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java
@@ -3,6 +3,8 @@
import org.ovirt.engine.ui.common.CommonApplicationConstants;
import org.ovirt.engine.ui.common.idhandler.ElementIdHandler;
import org.ovirt.engine.ui.common.idhandler.WithElementId;
+import org.ovirt.engine.ui.common.widget.Align;
+import org.ovirt.engine.ui.common.widget.editor.EntityModelCheckBoxEditor;
import org.ovirt.engine.ui.common.widget.editor.EntityModelTextBoxEditor;
import
org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractModelBoundPopupWidget;
import org.ovirt.engine.ui.uicommonweb.models.vms.SnapshotModel;
@@ -37,6 +39,11 @@
@WithElementId("description")
EntityModelTextBoxEditor descriptionEditor;
+ @UiField(provided = true)
+ @Path(value = "memory.entity")
+ @WithElementId("memory")
+ EntityModelCheckBoxEditor memoryEditor;
+
@UiField
@Ignore
FlowPanel messagePanel;
@@ -44,6 +51,7 @@
private final Driver driver = GWT.create(Driver.class);
public VmSnapshotCreatePopupWidget(CommonApplicationConstants constants) {
+ memoryEditor = new EntityModelCheckBoxEditor(Align.RIGHT);
initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
localize(constants);
ViewIdHandler.idHandler.generateAndSetIds(this);
@@ -52,6 +60,7 @@
void localize(CommonApplicationConstants constants) {
descriptionEditor.setLabel(constants.virtualMachineSnapshotCreatePopupDescriptionLabel());
+
memoryEditor.setLabel(constants.virtualMachineSnapshotCreatePopupMemoryLabel());
}
@Override
@@ -65,6 +74,9 @@
if ("Message".equals(propName)) { //$NON-NLS-1$
appendMessage(model.getMessage());
}
+ else if ("VM".equals(propName)) { //$NON-NLS-1$
+
memoryEditor.setVisible(model.getVm().getStatus().isRunning());
+ }
}
});
}
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml
index 440fea7..96ec3f7 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml
@@ -7,7 +7,7 @@
.content {
}
- .descriptionEditor {
+ .memoryEditor,.descriptionEditor {
width: 100%;
}
@@ -20,6 +20,7 @@
<g:VerticalPanel verticalAlignment="ALIGN_MIDDLE"
addStyleNames="{style.content}">
<e:EntityModelTextBoxEditor ui:field="descriptionEditor"
addStyleNames="{style.descriptionEditor}" />
+ <e:EntityModelCheckBoxEditor ui:field="memoryEditor"
addStyleNames="{style.memoryEditor}" />
<g:FlowPanel ui:field="messagePanel"
addStyleNames="{style.messagePanel}">
</g:FlowPanel>
</g:VerticalPanel>
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
index 214d563..4e9c390 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
@@ -109,6 +109,18 @@
privateDescription = value;
}
+ private EntityModel memory;
+
+ public EntityModel getMemory()
+ {
+ return memory;
+ }
+
+ public void setMemory(EntityModel value)
+ {
+ memory = value;
+ }
+
private EntityModel isPropertiesUpdated;
public EntityModel getIsPropertiesUpdated()
@@ -155,6 +167,7 @@
public SnapshotModel()
{
setDescription(new EntityModel());
+ setMemory(new EntityModel(true));
setDisks(new ArrayList<DiskImage>());
setNics(new ArrayList<VmNetworkInterface>());
setApps(new ArrayList<String>());
@@ -310,7 +323,9 @@
VM vm = getVm();
ArrayList<VdcActionParametersBase> params = new
ArrayList<VdcActionParametersBase>();
CreateAllSnapshotsFromVmParameters param =
- new CreateAllSnapshotsFromVmParameters(vm.getId(), (String)
getDescription().getEntity());
+ new CreateAllSnapshotsFromVmParameters(vm.getId(),
+ (String)
getDescription().getEntity(),
+ (Boolean)
getMemory().getEntity());
param.setQuotaId(vm.getQuotaId());
params.add(param);
--
To view, visit http://gerrit.ovirt.org/14867
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64cb8c705b0ae6c40b5b041876c55dfdc26c103f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
