Yair Zaslavsky has posted comments on this change. Change subject: core: Changes type of VmDevice from String to enum ......................................................................
Patch Set 1: All, 1. Added Eli here - as I see there are questions about device vs type. 2. AFAIK, you can look at a "type" as a group and at a "device" as an instance at the sub group (or maybe a better analogy would be a parent class and sub classes). 3. AFAIK, the used strings are demand from libvirt. -- To view, visit http://gerrit.ovirt.org/14812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icada39e3918fb053cb0ad0388178ccf5c6338ca2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
