Alissa Bonas has posted comments on this change.

Change subject: core: rename methods in DiskImage
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java
Line 56:         addValueLabelToPanel(panel, new EnumLabel<VolumeType>(), 
disk.getVolumeType(), "120px"); //$NON-NLS-1$
Line 57:         addValueLabelToPanel(panel, new EnumLabel<DiskInterface>(), 
disk.getDiskInterface(), "120px"); //$NON-NLS-1$
Line 58:         addValueLabelToPanel(panel, new DateLabel(), 
disk.getCreationDate(), "90px"); //$NON-NLS-1$
Line 59:         TreeItem treeItem = new TreeItem(panel);
Line 60:         treeItem.setUserObject(disk.getId());
I'd guess the automatic refactoring did it, because I didn't touch nor format 
it.
Line 61:         return treeItem;
Line 62:     }
Line 63: 
Line 64:     @Override


--
To view, visit http://gerrit.ovirt.org/14768
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf26bda8e00c1ae2f12b1decf6e1b4a8d12bed31
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to