Moti Asayag has posted comments on this change. Change subject: core: Adds custom properties to VmNetworkInterface ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterface.java Line 26: private String vmName; Line 27: private NGuid vmTemplateId; Line 28: private boolean plugged = true; Line 29: Line 30: /** This is a step toward redundancy, since the information is already suppose to be kept on vm_devices table and on VmDevice which represents this vNic. Therefore i think the approach should be adding the VmDevice to compose the VmNetworkInterface and delegate the reference of customProperties to VmDevice.customProperties and same goes for VmNetworkInterface.isPluggable to VmDevice.isPluggable If we agree to go on that direction the DAL part of this patch should be changed. Adding Mike for inputs on this Line 31: * Device custom properties Line 32: */ Line 33: private String customProperties; Line 34: -- To view, visit http://gerrit.ovirt.org/14815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I218db49043ddf0524178f6ff903e605bc0fe661a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
