Sandro Bonazzola has posted comments on this change.
Change subject: packaging - starting ovirt-engine only after yum rollback
..
Patch Set 1: (2 inline comments)
File packag
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in StorageDataCenterListModel class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in StorageDiskListModel class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in StorageIsoListModel class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in frontend backup models
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in StorageModelBehavior class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in StorageModel class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/144
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in StorageListModel class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Kanagaraj M has uploaded a new change for review.
Change subject: engine: Cleaning up InitVdsOnUpCommand
..
engine: Cleaning up InitVdsOnUpCommand
Removed the '_' prefixes from the private fields.
Change-Id: I4023d9eb66504ff264
Laszlo Hornyak has posted comments on this change.
Change subject: engine: search cleanup (1/N)
..
Patch Set 1:
ok, indeed this is not a the best patch ever, but I would need to rewrite the
whole patchset to get rid of it. Is
Allon Mureinik has submitted this change and it was merged.
Change subject: findbugs: self comparison of user to itself
..
findbugs: self comparison of user to itself
Change-Id: Ifa88e752da82043857f27d334ba86ca1c5587bcd
Signed-
Allon Mureinik has posted comments on this change.
Change subject: findbugs: self comparison of user to itself
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14293
To unsubscribe,
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Synthetic emulators EcryptionUtilsTest
..
core: Synthetic emulators EcryptionUtilsTest
Changed members visibility from private to protected to so
Allon Mureinik has submitted this change and it was merged.
Change subject: core: EncryptoinUtilsTest @Before->@BeforeClass
..
core: EncryptoinUtilsTest @Before->@BeforeClass
Replaced the @Before method with @BeforeClass.
There
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Removed std from KDCLocatorTest
..
core: Removed std from KDCLocatorTest
Removed printing of results with System.out.println - this is no way to
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove stdout from SimpleAuthenticationCheck
..
core: Remove stdout from SimpleAuthenticationCheck
Removed an old System.out.println call from th
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Removed std from EncryptionUtilsTest
..
core: Removed std from EncryptionUtilsTest
Removed printing of results with System.out.println - and repl
Allon Mureinik has submitted this change and it was merged.
Change subject: tools: Proper error testing in EngineConfigCLITest
..
tools: Proper error testing in EngineConfigCLITest
Converted the error tests in EngineConfigCLITe
Allon Mureinik has posted comments on this change.
Change subject: core: Remove stdout from SimpleAuthenticationCheck
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14421
To unsub
Allon Mureinik has posted comments on this change.
Change subject: core: Removed std from KDCLocatorTest
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14422
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Removed std from EncryptionUtilsTest
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14423
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: Synthetic emulators EcryptionUtilsTest
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14425
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: EncryptoinUtilsTest @Before->@BeforeClass
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14426
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: tools: Proper error testing in EngineConfigCLITest
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14424
To unsub
Yair Zaslavsky has posted comments on this change.
Change subject: engine: custom properties: allow '=' in regex
..
Patch Set 4: Looks good to me, but someone else must approve
Engine part - looks good.
Michael - please review
Kanagaraj M has posted comments on this change.
Change subject: engine: adding gluster_server table and dao operations
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/14063
To unsubscribe, visit http://gerrit
Kanagaraj M has posted comments on this change.
Change subject: engine: adding vds_gluster table and dao operations
..
Patch Set 5: (13 inline comments)
new patch set to follow.
Shireesh Anjal has posted comments on this change.
Change subject: engine: search remove redundant constructor param (2/N)
..
Patch Set 1: Looks good to me, approved
I had kept it this way, so that it is easy to understand that
Shireesh Anjal has submitted this change and it was merged.
Change subject: engine:Sync gluster hooks
..
engine:Sync gluster hooks
This patch adds a periodic job to sync gluster hooks
on servers in the cluster with the hooks st
Shireesh Anjal has posted comments on this change.
Change subject: engine:Sync gluster hooks
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13943
To unsubscribe, visit http://gerr
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add log when task could not end action.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
...
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Proper error testing in EngineConfigCLITest
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14424
To unsubscribe, vi
Yair Zaslavsky has posted comments on this change.
Change subject: core: EncryptoinUtilsTest @Before->@BeforeClass
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14426
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove stdout from SimpleAuthenticationCheck
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14421
To unsubscribe, vi
Yair Zaslavsky has posted comments on this change.
Change subject: core: Removed std from KDCLocatorTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14422
To unsubscribe, visit http://ge
Yair Zaslavsky has posted comments on this change.
Change subject: core: Removed std from EncryptionUtilsTest
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14423
To unsubscribe, visit http
Yair Zaslavsky has posted comments on this change.
Change subject: core: Synthetic emulators EcryptionUtilsTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14425
To unsubscribe, visit ht
Einav Cohen has posted comments on this change.
Change subject: restapi : call to show files on iso domain no longer shows all
files
..
Patch Set 1: (1 inline comment)
File
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs error in SanTargetModel class
..
findbugs: Fix fingbugs error in SanTargetModel class
Change-Id: Ib4a4fd6bb5b2743d0dc939751d31f5247de6fc7f
Si
Tal Nisan has uploaded a new change for review.
Change subject: frontend: Removed unused classes
..
frontend: Removed unused classes
Remove the unused classes TypeUtil and UriValidator from frontend's
uicompat package
Change-Id
Tal Nisan has uploaded a new change for review.
Change subject: frontend: Removed MailAddress class
..
frontend: Removed MailAddress class
The class MainAddress though it's obscure name is an email address
regex validator which
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs error in StorageModel class
..
findbugs: Fix fingbugs error in StorageModel class
Change-Id: Id9281939079fa40e03170d3a2b0a43b348128a02
Signed
Tal Nisan has uploaded a new change for review.
Change subject: frontend: Remove IteratorUtils class
..
frontend: Remove IteratorUtils class
Removed the IteratorUtils class which only contained one helper method
not that helpful
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs error in StorageDataCenterListModel class
..
findbugs: Fix fingbugs error in StorageDataCenterListModel class
Change-Id: I02c4c364d9bb42728fb
Tal Nisan has uploaded a new change for review.
Change subject: frontend: Removed unused classes
..
frontend: Removed unused classes
Removed the unused classes Clipboard, DispatcherOepration, ICommand
and DispatcherOperationStat
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in DataCenterStorageListModel
class
..
findbugs: Fix fingbugs errors in DataCenterStorageListModel class
Also removed legacy comments
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in DataCenterGuideModel class
..
findbugs: Fix fingbugs errors in DataCenterGuideModel class
Change-Id: I12e685b09bf0f148324705a01b0ca
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in edit quota model classes
..
findbugs: Fix fingbugs errors in edit quota model classes
Change-Id: I79ec20031ecbb284b21dc8b3694841e01
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in DataCenterListModel &
DataCenterModel classes
..
findbugs: Fix fingbugs errors in DataCenterListModel & DataCenterModel classes
Ch
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in SanStorageModel class
..
findbugs: Fix fingbugs errors in SanStorageModel class
Change-Id: I9e2f1f7f1a258c1bb3db1cef9f681e450a68a29
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in BookmarkListModel class
..
findbugs: Fix fingbugs errors in BookmarkListModel class
Change-Id: I7315a2b9d7afbf6c8f91e283203ff668e69
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs error in frontend backup models
..
findbugs: Fix fingbugs error in frontend backup models
Fixed findbugs errors in ManageBackupModel, Templat
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs error in StorageListModel class
..
findbugs: Fix fingbugs error in StorageListModel class
Change-Id: Idb17363d996bfbddd9ffefcfa06de055da00a42
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in ClusterGuideModel class
..
findbugs: Fix fingbugs errors in ClusterGuideModel class
Change-Id: Ic13caac40ff1b4928f8b2c8b1c00df16421
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix redundant null checks warnings in uicommonweb
project
..
findbugs: Fix redundant null checks warnings in uicommonweb project
Change-Id: I0acb590a9cb5
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs error in SanStorageModelBase class
..
findbugs: Fix fingbugs error in SanStorageModelBase class
Change-Id: Icbeb62215591b5fb2892e23c5dc6dc6a3
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in ClusterListModel class
..
findbugs: Fix fingbugs errors in ClusterListModel class
Change-Id: I494e0a984540378fa90321da9a503f6296bec
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs error in IStorageModel interface
..
findbugs: Fix fingbugs error in IStorageModel interface
Change-Id: I1df2b42599af15dec379de44a51be44fd80f1
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs error in StorageModelBehavior class
..
findbugs: Fix fingbugs error in StorageModelBehavior class
Change-Id: I31a978a4180b749a71a910fce989efa
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix field is not final warnings in uicommonweb project
..
findbugs: Fix field is not final warnings in uicommonweb project
Change-Id: I10d4143c5b2adb031e5
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix field should be package protected warning in
uicommonweb project
..
findbugs: Fix field should be package protected warning in uicommonweb project
Ch
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix inner class should be static warnings in
uicommonweb project
..
findbugs: Fix inner class should be static warnings in uicommonweb project
Change-Id:
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Remove dead local storage in uicommonweb project
..
findbugs: Remove dead local storage in uicommonweb project
Change-Id: I1afe4e408b6a4f1b652a710369250c9
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs error in StorageIsoListModel class
..
findbugs: Fix fingbugs error in StorageIsoListModel class
Change-Id: Iaa51927d76bc20e5adc3a6d5ea69a0105
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in CommonModel class
..
findbugs: Fix fingbugs errors in CommonModel class
Change-Id: I5c70235fe828c1d662813773312c6529101e0a2b
Signed
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in system tree models classes
..
findbugs: Fix fingbugs errors in system tree models classes
Change-Id: Ia4821d7365cc26c09c60378a252c9
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in ListModel class
..
findbugs: Fix fingbugs errors in ListModel class
Change-Id: I1e2395f9657f2c602e5450a03bc57fc6ec1870f8
Signed-off
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in LoginModel class
..
findbugs: Fix fingbugs errors in LoginModel class
Change-Id: Ic6eab28be9e32b4f866d4cabc2b8685cb8cf
Signed-o
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs error in StorageDiskListModel class
..
findbugs: Fix fingbugs error in StorageDiskListModel class
Change-Id: Ib5c4504c7318bd90af4aa900090d6cb
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in EntityModel class
..
findbugs: Fix fingbugs errors in EntityModel class
Change-Id: I22664795e8f38628216f167978051f4c8c1ea81d
Signed
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in ConfirmationModel class
..
findbugs: Fix fingbugs errors in ConfirmationModel class
Change-Id: I97c39809c92cf679cc47c141e75bfdf8c71
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in NfsStorageModel class
..
findbugs: Fix fingbugs errors in NfsStorageModel class
Change-Id: Iddb575b6cbdfe69592cd2019f18be1a47e73c15
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in ImportStorageModelBehavior
class
..
findbugs: Fix fingbugs errors in ImportStorageModelBehavior class
Change-Id: Iaa29ca297218afbd
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in DisksAllocationModel class
..
findbugs: Fix fingbugs errors in DisksAllocationModel class
Change-Id: Icad3abfd0d1499f7125bafdd30e43
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in SearchableListModel class
..
findbugs: Fix fingbugs errors in SearchableListModel class
Change-Id: I3c4ef597b8bd10596d14e2479309c84
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in CustomPropertyValidation class
..
findbugs: Fix fingbugs errors in CustomPropertyValidation class
Change-Id: I330a0da5fd7211203e639
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in VolumeListModel class
..
findbugs: Fix fingbugs errors in VolumeListModel class
Change-Id: Ic2784af9e667294602813c5290ed3e2ae87e577
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in RemoveStorageModel class
..
findbugs: Fix fingbugs errors in RemoveStorageModel class
Change-Id: I80d831a80bd15c7f700d8298a264bea5e
Tal Nisan has uploaded a new change for review.
Change subject: findbugs: Fix fingbugs errors in MoveOrCopyDiskModel class
..
findbugs: Fix fingbugs errors in MoveOrCopyDiskModel class
Change-Id: I62d5bf1665b97a7e157aaf014d10146
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: use LocalConfig as configuration file
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/14376
To unsubscribe, visit http://gerrit.ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: move to the new service infrastructure
..
Patch Set 4: Verified
I found that there was duplication of validation within java code and shell...
so we ar
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: remove NotificationConfigurator as superseded by
LocalConfig
..
Patch Set 1: Verified
I do not know what am I doing this to my-self... but still, I can
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: use LocalConfig as configuration file
..
Patch Set 4:
Rebase
--
To view, visit http://gerrit.ovirt.org/14376
To unsubscribe, visit http://gerrit.ovirt.
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: handle port correctly
..
Patch Set 4: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/14375
To unsubscribe, visit http://gerrit.ovirt.org/set
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: switch to log4j
..
Patch Set 4: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/14377
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alon Bar-Lev has posted comments on this change.
Change subject: root: serve root customizable location resources
..
Patch Set 5: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/14354
To unsubscribe, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: pki: move configuration from vdc_options to configuration files
..
Patch Set 10: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/14333
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: provide expand string for configuration
..
Patch Set 1: Verified
This was within I94f845d36bb075c23 and split out to ease review.
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: split LocalConfig to allow code reuse
..
Patch Set 4: Verified
Reabase
--
To view, visit http://gerrit.ovirt.org/14374
To unsubscribe, visit http:/
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: support sensitive keys
..
Patch Set 4: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/14353
To unsubscribe, visit http://gerrit.ovirt.or
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: support optional properties
..
Patch Set 1: Verified
This is usable for the porting of the notifier, and in future to add some
'hidden' debug prope
Alon Bar-Lev has uploaded a new change for review.
Change subject: notifier: remove NotificationConfigurator as superseded by
LocalConfig
..
notifier: remove NotificationConfigurator as superseded by LocalConfig
cleanup validat
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: config: support optional properties
..
core: config: support optional properties
Change-Id: I61975ab2c6c5b72c7eb0fe85b1ccef9eb2ef8fd9
Signed-off-by: Alon B
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: config: provide expand string for configuration
..
core: config: provide expand string for configuration
allow to expand strings such as "${ENGINE_ETC}/con
Alon Bar-Lev has posted comments on this change.
Change subject: tools: Support for POSIX and GNU long params in
engine-manage-domains
..
Patch Set 2:
Hello Martin,
I fully understand your arguments, we have repeated these se
Martin Peřina has posted comments on this change.
Change subject: tools: Support for POSIX and GNU long params in
engine-manage-domains
..
Patch Set 2:
Hi Alon,
the primary goal is to support POSIX and GNU long parameters in
Allon Mureinik has posted comments on this change.
Change subject: core: fix typo in GetDefaultTimeZone
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14442
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: engine: hashcode method simplification
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14386
To unsubs
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Allow engine to configure management network
..
Patch Set 5: (1 inline comment)
File
backend/manager
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Allow engine to configure management network
..
Patch Set 5: (2 inline comments)
Thanks!
File
backe
1 - 100 of 217 matches
Mail list logo
