Alon Bar-Lev has posted comments on this change.
Change subject: engine: Allow engine to configure management network
......................................................................
Patch Set 5: (2 inline comments)
Thanks!
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 143: T parameters = getParameters();
Line 144: installer = new VdsDeploy(getVds());
Line 145: installer.setCorrelationId(getCorrelationId());
Line 146: boolean configureNetwork =
!FeatureSupported.setupNetworks(getVds().getVdsGroupCompatibilityVersion());
Line 147:
installer.setReboot(parameters.isRebootAfterInstallation() && configureNetwork);
technically we do support host-deploy without reboot.
the requirement for reboot comes from pm so we know host can survive future
reboots, better discover issues sooner than later.
so disabling reboot needs consult with pm... or at least discussed at wider
audience.
As the nature of our network configuration is persistent, a reboot may be
required after the bridge is configured to make sure the computer can survive
reboot.
Line 148: if (configureNetwork) {
Line 149:
installer.setManagementNetwork(NetworkUtils.getEngineNetwork());
Line 150: }
Line 151:
Line 184: public void run() {
Line 185:
getBackend().runInternalAction(VdcActionType.ActivateVds,
Line 186: new
VdsActionParameters(getVds().getId()));
Line 187: }
Line 188: });
Yes, this way the application logic (decision) will be at one place, no?
Line 189: }
Line 190: }
Line 191: log.infoFormat(
Line 192: "After Installation host {0}, {1}",
--
To view, visit http://gerrit.ovirt.org/14230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Martin Pavlik <xpavl...@gmail.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
